Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libdbus-1-dev and updated git to docker image #1464

Closed
wants to merge 2 commits into from
Closed

Add libdbus-1-dev and updated git to docker image #1464

wants to merge 2 commits into from

Conversation

andy31415
Copy link
Contributor

Problem

We need more things in the docker file

Summary of Changes

Adds libdbus-1-dev to the image, updates the git version (github actions will do real git checkouts) and adds pygit to the python packages that are supported.

Version bump by 2 because changes made in #1441 are already active as version 17.

fixes #1463 1463

@restyled-io restyled-io bot mentioned this pull request Jul 7, 2020
Closed
@andy31415
Copy link
Contributor Author

curl and gettext are for git compilation

@andy31415 andy31415 mentioned this pull request Jul 7, 2020
Merged
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

rwalker-apple
rwalker-apple reviewed Jul 8, 2020
View reviewed changes
integrations/docker/images/chip-build/Dockerfile
@@ -60,6 +62,19 @@ RUN set -x \
&& rm cmake-3.17.2.tar.gz \
&& : # last line

# Install newer git version, to allow for github workflow checkout
RUN set -x \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just updating us to ubuntu:focal, which already has this and an up-to-date cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that change already in?

I have already built the 0.2.18 image in dockerhub to unblock linux with libdbus-1-dev availability. I am afraid that if we keep the PRs the images and sources become out of sync.

@andy31415
Copy link
Contributor Author

#1508 makes this one obsolete.

@andy31415 andy31415 closed this Jul 9, 2020
@andy31415 andy31415 deleted the docker_dbus_and_git branch October 9, 2020 18:25
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@satyanaag-silabs @jmartinez-silabs
Pull request project-chip#1464: MATTER-2301: fix UMB and MPC build an…
eb4b841 
…d UT failure after latest CSA pull

Merge in WMN_TOOLS/matter from bugfix/NoJira-fix-UMB-and-MPC-build-failure-after-latest-CSA-pull to silabs

Squashed commit of the following:

commit cded9a0116dfc185928954cbf8ed17b9653de995
Author: sabollim <[email protected]>
Date:   Mon Jan 8 17:26:34 2024 +0530

    addrssing PR comments

commit 6c68f142f513848034f4052b7f9ad99a22b5c900
Author: sabollim <[email protected]>
Date:   Mon Jan 8 16:40:46 2024 +0530

    fix UMB UT failure after interface changes

commit ca9e430c9022aaad4cfadf1d918f3b20aa8bf8bf
Author: Suhas Shankar <[email protected]>
Date:   Fri Jan 5 19:21:55 2024 +0530

    Updated MPC UT as per latest UT framework

... and 2 more commits
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Jan 18, 2024
@satyanaag-silabs @jmartinez-silabs
Pull request project-chip#1464: MATTER-2301: fix UMB and MPC build an…
bc883aa 
…d UT failure after latest CSA pull

Merge in WMN_TOOLS/matter from bugfix/NoJira-fix-UMB-and-MPC-build-failure-after-latest-CSA-pull to silabs

Squashed commit of the following:

commit cded9a0116dfc185928954cbf8ed17b9653de995
Author: sabollim <[email protected]>
Date:   Mon Jan 8 17:26:34 2024 +0530

    addrssing PR comments

commit 6c68f142f513848034f4052b7f9ad99a22b5c900
Author: sabollim <[email protected]>
Date:   Mon Jan 8 16:40:46 2024 +0530

    fix UMB UT failure after interface changes

commit ca9e430c9022aaad4cfadf1d918f3b20aa8bf8bf
Author: Suhas Shankar <[email protected]>
Date:   Fri Jan 5 19:21:55 2024 +0530

    Updated MPC UT as per latest UT framework

... and 2 more commits
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
@satyanaag-silabs @jmartinez-silabs
Pull request project-chip#1464: MATTER-2301: fix UMB and MPC build an…
fd4f564 
…d UT failure after latest CSA pull

Merge in WMN_TOOLS/matter from bugfix/NoJira-fix-UMB-and-MPC-build-failure-after-latest-CSA-pull to silabs

Squashed commit of the following:

commit cded9a0116dfc185928954cbf8ed17b9653de995
Author: sabollim <[email protected]>
Date:   Mon Jan 8 17:26:34 2024 +0530

    addrssing PR comments

commit 6c68f142f513848034f4052b7f9ad99a22b5c900
Author: sabollim <[email protected]>
Date:   Mon Jan 8 16:40:46 2024 +0530

    fix UMB UT failure after interface changes

commit ca9e430c9022aaad4cfadf1d918f3b20aa8bf8bf
Author: Suhas Shankar <[email protected]>
Date:   Fri Jan 5 19:21:55 2024 +0530

    Updated MPC UT as per latest UT framework

... and 2 more commits
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
@satyanaag-silabs @jmartinez-silabs
Pull request project-chip#1464: MATTER-2301: fix UMB and MPC build an…
6541396 
…d UT failure after latest CSA pull

Merge in WMN_TOOLS/matter from bugfix/NoJira-fix-UMB-and-MPC-build-failure-after-latest-CSA-pull to silabs

Squashed commit of the following:

commit cded9a0116dfc185928954cbf8ed17b9653de995
Author: sabollim <[email protected]>
Date:   Mon Jan 8 17:26:34 2024 +0530

    addrssing PR comments

commit 6c68f142f513848034f4052b7f9ad99a22b5c900
Author: sabollim <[email protected]>
Date:   Mon Jan 8 16:40:46 2024 +0530

    fix UMB UT failure after interface changes

commit ca9e430c9022aaad4cfadf1d918f3b20aa8bf8bf
Author: Suhas Shankar <[email protected]>
Date:   Fri Jan 5 19:21:55 2024 +0530

    Updated MPC UT as per latest UT framework

... and 2 more commits
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@satyanaag-silabs @jmartinez-silabs
Pull request project-chip#1464: MATTER-2301: fix UMB and MPC build an…
e07df29 
…d UT failure after latest CSA pull

Merge in WMN_TOOLS/matter from bugfix/NoJira-fix-UMB-and-MPC-build-failure-after-latest-CSA-pull to silabs

Squashed commit of the following:

commit cded9a0116dfc185928954cbf8ed17b9653de995
Author: sabollim <[email protected]>
Date:   Mon Jan 8 17:26:34 2024 +0530

    addrssing PR comments

commit 6c68f142f513848034f4052b7f9ad99a22b5c900
Author: sabollim <[email protected]>
Date:   Mon Jan 8 16:40:46 2024 +0530

    fix UMB UT failure after interface changes

commit ca9e430c9022aaad4cfadf1d918f3b20aa8bf8bf
Author: Suhas Shankar <[email protected]>
Date:   Fri Jan 5 19:21:55 2024 +0530

    Updated MPC UT as per latest UT framework

... and 2 more commits
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@satyanaag-silabs @jmartinez-silabs
Pull request project-chip#1464: MATTER-2301: fix UMB and MPC build an…
f0623b4 
…d UT failure after latest CSA pull

Merge in WMN_TOOLS/matter from bugfix/NoJira-fix-UMB-and-MPC-build-failure-after-latest-CSA-pull to silabs

Squashed commit of the following:

commit cded9a0116dfc185928954cbf8ed17b9653de995
Author: sabollim <[email protected]>
Date:   Mon Jan 8 17:26:34 2024 +0530

    addrssing PR comments

commit 6c68f142f513848034f4052b7f9ad99a22b5c900
Author: sabollim <[email protected]>
Date:   Mon Jan 8 16:40:46 2024 +0530

    fix UMB UT failure after interface changes

commit ca9e430c9022aaad4cfadf1d918f3b20aa8bf8bf
Author: Suhas Shankar <[email protected]>
Date:   Fri Jan 5 19:21:55 2024 +0530

    Updated MPC UT as per latest UT framework

... and 2 more commits
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@satyanaag-silabs @jmartinez-silabs
Pull request project-chip#1464: MATTER-2301: fix UMB and MPC build an…
4a25f1a 
…d UT failure after latest CSA pull

Merge in WMN_TOOLS/matter from bugfix/NoJira-fix-UMB-and-MPC-build-failure-after-latest-CSA-pull to silabs

Squashed commit of the following:

commit cded9a0116dfc185928954cbf8ed17b9653de995
Author: sabollim <[email protected]>
Date:   Mon Jan 8 17:26:34 2024 +0530

    addrssing PR comments

commit 6c68f142f513848034f4052b7f9ad99a22b5c900
Author: sabollim <[email protected]>
Date:   Mon Jan 8 16:40:46 2024 +0530

    fix UMB UT failure after interface changes

commit ca9e430c9022aaad4cfadf1d918f3b20aa8bf8bf
Author: Suhas Shankar <[email protected]>
Date:   Fri Jan 5 19:21:55 2024 +0530

    Updated MPC UT as per latest UT framework

... and 2 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalker-apple rwalker-apple rwalker-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@mspang mspang mspang approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add libdbus-1-dev to the Docker image
5 participants
@andy31415 @CLAassistant @mspang @woody-apple @rwalker-apple