-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataModelLogger::LogAttribute for unknown attributes. #14775
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-attribute-logger
Feb 4, 2022
Merged
Fix DataModelLogger::LogAttribute for unknown attributes. #14775
jmartinez-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-attribute-logger
Feb 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogAttribute was missing break statements in its switches, so trying to read an attribute that controller-clusters does not have enabled (e.g. UniqueID from Bridged Device Basic Information) would start falling through to other clusters and possibly trying to treat it as another attribute that happens to have the same attribute id (in this case the Primary1Y attribute from Color Control). Then TLV decoding would fail due to type mismatch errors, which is not what we want here.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel and
LuDuda
February 4, 2022 05:46
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple and
xylophone21
February 4, 2022 05:46
PR #14775: Size comparison from 1fafe32 to a957447 Increases (2 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Feb 4, 2022
vivien-apple
approved these changes
Feb 4, 2022
jmartinez-silabs
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogAttribute was missing break statements in its switches, so trying
to read an attribute that controller-clusters does not have enabled
(e.g. UniqueID from Bridged Device Basic Information) would start
falling through to other clusters and possibly trying to treat it as
another attribute that happens to have the same attribute id (in this
case the Primary1Y attribute from Color Control).
Then TLV decoding would fail due to type mismatch errors, which is not
what we want here.
Problem
See above.
Change overview
Add breaks as needed.
Testing
Verified that trying to do:
does not fail out anymore.