Make in RAM NetworkCommissioning::Featuremap report kThreadDevice #14751
Conversation
This makes the default in-ram setting claim 'I am a thread device'.
This is because most wifi devices already support a spec-compliant
network cluster:
- linux reports as wifi
- esp32 reports as wifi
- darwin has an intentional 'report as 0' for unit tests which needs
to be altered and ZAP defaults will not apply anyway.
Found files to be changed and validated via:
fd 'zap$' | xargs rg 'Network Commissioning' | cut -f1 -d: | uniq | xargs -n1 jq '.endpointTypes[].clusters[] | select(.name == "Network Commissioning") | {name: .name, attr: .attributes[] | {name:.name, default:.defaultValue, file: input_filename}} | select(.attr.name == "FeatureMap" and .attr.default != "2")'
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02 and
msandstedt
|
PR #14751: Size comparison from 1ee9366 to 56cb75b Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #14751: Size comparison from 4267a9b to 9347931 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
No matter which default you pick, you're going to be in the wrong. Might as well pick the default that does the most good... Approved! |
|
Looks like thread test fails in cirque with this change See the log from all-cluster-app [1643927284.109888][68:68] CHIP:DMG: InvokeRequestMessage = it seems it fails to scan thread network... |
|
When test code do with this PR, it returns It seems thread scan network don't work. #14713 mentioned thread scan has not yet been implemented.... |
|
In current master branch, cirque thread test is using Endpoint0 for thread commissioning test the bad log is the code is here So do we allow network commissioning cluster's thread feature is enabled in two endpoints? From the log, if the device has been commissioned with thread network, it looks like not right to commissioning the thread network using another endpoint in same devce. So the workaround is that once one endpint's thread commisioning is complete, then skip the thread commissioning for another endpoint. |
…y we have 2 of them, likely they do not work
|
Thank you @yunhanw-google - I did not realize there were 2 endpoints with network configuration. Not sure what that even means and it seems unlikely that that is supported. I will set the featuremap on that endpoint to 0 and see if cirque passes. |
For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for lighting-app. Signed-off-by: Haoran Wang <[email protected]>
For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for thermostat-app. Signed-off-by: Haoran Wang <[email protected]>
For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for lighting-app. Signed-off-by: Haoran Wang <[email protected]>
For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for thermostat-app. Signed-off-by: Haoran Wang <[email protected]>
For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for lighting-app. Signed-off-by: Haoran Wang <[email protected]>
For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for thermostat-app. Signed-off-by: Haoran Wang <[email protected]>
* Add Network Commissioning cluster setup for lighting app Linux For issue #15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in #14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for lighting-app. Signed-off-by: Haoran Wang <[email protected]> * Add Network Commissioning cluster setup for thermostat app Linux For issue #15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in #14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for thermostat-app. Signed-off-by: Haoran Wang <[email protected]>
…16222) * Add Network Commissioning cluster setup for lighting app Linux For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for lighting-app. Signed-off-by: Haoran Wang <[email protected]> * Add Network Commissioning cluster setup for thermostat app Linux For issue project-chip#15261 the Linux lighting app failed to be commission by chip-tool pairing ble-wifi command. Based on the message in project-chip#14751, the Linux platform intented to support WiFi network by default instead Thread. This patch add Network Commissioning cluster setup for WiFi device for thermostat-app. Signed-off-by: Haoran Wang <[email protected]>
Problem
Thread devices fail to commission currently. #14713 is addressing that, however it may take a while to make all devices work.
Change overview
Switch the default to 2 (i.e. thread device) from previous values of 0 (invalid really) and 1 (wifi). Other wifi platforms are generally covered:
Testing
Commissioned a NRF device on thread using
chip-tool pairing ble-thread, it went past the cretendial selectionValidated all needed things changed via: