Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a Generic Network commissioning Thread Driver #14713

Merged
merged 11 commits into from
Feb 7, 2022
Merged

Implement a Generic Network commissioning Thread Driver #14713

merged 11 commits into from
Feb 7, 2022

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Feb 2, 2022 •
edited
Loading

Problem

Commissioning a Thread device is currently failing
Addresses #13170 #14595

Change overview

This adds a generic Network commissioning Thread Driver that can be used by all Thread end devices platforms
Instantiates the Thread Driver and the Network commissioning cluster in the thread Init

TODO Handle/execute ScanNetwork command. I will do it on a subsequent PR

Testing

Commissioned EFR32 light-app device successfully

I could not validate with any other platform than EFR32. CI can confirm builds

@restyled-io restyled-io bot mentioned this pull request Feb 2, 2022
Closed
@jmartinez-silabs jmartinez-silabs marked this pull request as ready for review February 3, 2022 03:16
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

PR #14713: Size comparison from 22f5d22 to be8c1d7

Increases (2 builds for esp32)
platform target config section 22f5d22 be8c1d7 change % change
esp32 all-clusters-app c3devkit (read only) 934044 934598 554 0.1
(read/write) 1400954 1401002 48 0.0
.flash.rodata 197744 197792 48 0.0
.flash.text 934044 934598 554 0.1
m5stack (read only) 982083 982723 640 0.1
(read/write) 465320 465360 40 0.0
.flash.rodata 224360 224400 40 0.0
.flash.text 976699 977339 640 0.1
Full report (2 builds for esp32)
platform target config section 22f5d22 be8c1d7 change % change
esp32 all-clusters-app c3devkit (read only) 934044 934598 554 0.1
(read/write) 1400954 1401002 48 0.0
.dram0.bss 70048 70048 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197744 197792 48 0.0
.flash.text 934044 934598 554 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982083 982723 640 0.1
(read/write) 465320 465360 40 0.0
.dram0.bss 74808 74808 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224360 224400 40 0.0
.flash.text 976699 977339 640 0.1
.iram0.text 123399 123399 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

PR #14713: Size comparison from 11182e6 to 854a46a

Full report (1 build for telink)
platform target config section 11182e6 854a46a change % change
telink lighting-app tlsr9518adk80d (read/write) 845810 845810 0 0.0
bss 85296 85296 0 0.0
noinit 37160 37160 0 0.0
text 592928 592928 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 3, 2022 •
edited
Loading

PR #14713: Size comparison from 11182e6 to 5394554

Increases above 0.2%:

platform target config section 11182e6 5394554 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577610 583498 5888 1.0
.app_xip_area 485104 490368 5264 1.1
.bss 75252 75876 624 0.8
lock cyw930739m2evb_01 (read/write) 535354 541242 5888 1.1
.app_xip_area 444416 449680 5264 1.2
.bss 73724 74348 624 0.8
ota-requestor cyw930739m2evb_01 (read/write) 559842 565734 5892 1.1
.app_xip_area 459584 464852 5268 1.1
.bss 82716 83340 624 0.8
efr32 lighting-app BRD4161A (read only) 844296 852256 7960 0.9
(read/write) 124784 125408 624 0.5
.bss 122896 123520 624 0.5
.text 844288 852248 7960 0.9
BRD4161A+rpc (read only) 831672 839704 8032 1.0
(read/write) 141448 142072 624 0.4
.bss 139456 140080 624 0.4
.text 831664 839696 8032 1.0
window-app BRD4161A (read only) 816372 824308 7936 1.0
(read/write) 123416 124040 624 0.5
.bss 121572 122196 624 0.5
.text 816364 824300 7936 1.0
k32w light k32w061+release (read/write) 661848 667716 5868 0.9
.bss 74948 75572 624 0.8
.text 579252 584496 5244 0.9
lock k32w061+release (read/write) 663308 669176 5868 0.9
.bss 75276 75900 624 0.8
.text 580344 585588 5244 0.9
qpg lighting-app qpg6105+debug (read only) 571464 576428 4964 0.9
.bss 87240 87864 624 0.7
.text 566144 571108 4964 0.9
lock-app qpg6105+debug (read only) 517308 522272 4964 1.0
.bss 86688 87312 624 0.7
.text 511988 516952 4964 1.0
telink lighting-app tlsr9518adk80d (read/write) 845810 852074 6264 0.7
bss 85296 85916 620 0.7
text 592928 597990 5062 0.9
Increases (13 builds for cyw30739, efr32, k32w, linux, qpg, telink)
platform target config section 11182e6 5394554 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577610 583498 5888 1.0
.app_xip_area 485104 490368 5264 1.1
.bss 75252 75876 624 0.8
lock cyw930739m2evb_01 (read/write) 535354 541242 5888 1.1
.app_xip_area 444416 449680 5264 1.2
.bss 73724 74348 624 0.8
ota-requestor cyw930739m2evb_01 (read/write) 559842 565734 5892 1.1
.app_xip_area 459584 464852 5268 1.1
.bss 82716 83340 624 0.8
efr32 lighting-app BRD4161A (read only) 844296 852256 7960 0.9
(read/write) 124784 125408 624 0.5
.bss 122896 123520 624 0.5
.text 844288 852248 7960 0.9
BRD4161A+rpc (read only) 831672 839704 8032 1.0
(read/write) 141448 142072 624 0.4
.bss 139456 140080 624 0.4
.text 831664 839696 8032 1.0
window-app BRD4161A (read only) 816372 824308 7936 1.0
(read/write) 123416 124040 624 0.5
.bss 121572 122196 624 0.5
.text 816364 824300 7936 1.0
k32w light k32w061+release (read/write) 661848 667716 5868 0.9
.bss 74948 75572 624 0.8
.text 579252 584496 5244 0.9
lock k32w061+release (read/write) 663308 669176 5868 0.9
.bss 75276 75900 624 0.8
.text 580344 585588 5244 0.9
linux chip-tool-ipv6only arm64 (read only) 7120532 7120628 96 0.0
.text 6127236 6127332 96 0.0
thermostat-no-ble arm64 (read only) 2091644 2091740 96 0.0
.text 1743168 1743264 96 0.0
qpg lighting-app qpg6105+debug (read only) 571464 576428 4964 0.9
.bss 87240 87864 624 0.7
.text 566144 571108 4964 0.9
lock-app qpg6105+debug (read only) 517308 522272 4964 1.0
.bss 86688 87312 624 0.7
.text 511988 516952 4964 1.0
telink lighting-app tlsr9518adk80d (read/write) 845810 852074 6264 0.7
bss 85296 85916 620 0.7
text 592928 597990 5062 0.9
Decreases (1 build for qpg)
platform target config section 11182e6 5394554 change % change
qpg persistent-storage-app qpg6105+debug (read only) 107140 99548 -7592 -7.1
.bss 38504 24004 -14500 -37.7
.data 288 176 -112 -38.9
.text 101820 94228 -7592 -7.5
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 11182e6 5394554 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577610 583498 5888 1.0
.app_xip_area 485104 490368 5264 1.1
.bss 75252 75876 624 0.8
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535354 541242 5888 1.1
.app_xip_area 444416 449680 5264 1.2
.bss 73724 74348 624 0.8
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559842 565734 5892 1.1
.app_xip_area 459584 464852 5268 1.1
.bss 82716 83340 624 0.8
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 844296 852256 7960 0.9
(read/write) 124784 125408 624 0.5
.bss 122896 123520 624 0.5
.data 1888 1888 0 0.0
.text 844288 852248 7960 0.9
BRD4161A+rpc (read only) 831672 839704 8032 1.0
(read/write) 141448 142072 624 0.4
.bss 139456 140080 624 0.4
.data 1988 1988 0 0.0
.text 831664 839696 8032 1.0
window-app BRD4161A (read only) 816372 824308 7936 1.0
(read/write) 123416 124040 624 0.5
.bss 121572 122196 624 0.5
.data 1844 1844 0 0.0
.text 816364 824300 7936 1.0
esp32 all-clusters-app c3devkit (read only) 934636 934636 0 0.0
(read/write) 1401074 1401074 0 0.0
.dram0.bss 70056 70056 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197848 197848 0 0.0
.flash.text 934636 934636 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982819 982819 0 0.0
(read/write) 465428 465428 0 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224460 224460 0 0.0
.flash.text 977435 977435 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661848 667716 5868 0.9
.bss 74948 75572 624 0.8
.data 1848 1848 0 0.0
.text 579252 584496 5244 0.9
lock k32w061+release (read/write) 663308 669176 5868 0.9
.bss 75276 75900 624 0.8
.data 1888 1888 0 0.0
.text 580344 585588 5244 0.9
linux chip-tool-ipv6only arm64 (read only) 7120532 7120628 96 0.0
(read/write) 284545 284545 0 0.0
.bss 47585 47585 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186712 186712 0 0.0
.dynamic 560 560 0 0.0
.got 45344 45344 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 391564 391564 0 0.0
.text 6127236 6127332 96 0.0
thermostat-no-ble arm64 (read only) 2091644 2091740 96 0.0
(read/write) 140401 140401 0 0.0
.bss 57713 57713 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 130764 130764 0 0.0
.text 1743168 1743264 96 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386320 2386320 0 0.0
.bss 188964 188964 0 0.0
.data 5280 5280 0 0.0
.text 1348920 1348920 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2339000 2339000 0 0.0
.bss 177888 177888 0 0.0
.data 5560 5560 0 0.0
.text 1301600 1301600 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302800 2302800 0 0.0
.bss 177784 177784 0 0.0
.data 5544 5544 0 0.0
.text 1265400 1265400 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293244 2293244 0 0.0
.bss 175052 175052 0 0.0
.data 5360 5360 0 0.0
.text 1255816 1255816 0 0.0
p6 all-clusters-app default (read/write) 2447176 2447176 0 0.0
.bss 117124 117124 0 0.0
.data 2568 2568 0 0.0
.text 1405440 1405440 0 0.0
light-app default (read/write) 2340816 2340816 0 0.0
.bss 103092 103092 0 0.0
.data 2400 2400 0 0.0
.text 1299080 1299080 0 0.0
lock-app default (read/write) 2305848 2305848 0 0.0
.bss 102804 102804 0 0.0
.data 2360 2360 0 0.0
.text 1264112 1264112 0 0.0
qpg lighting-app qpg6105+debug (read only) 571464 576428 4964 0.9
(read/write) 146936 146936 0 0.0
.bss 87240 87864 624 0.7
.data 1052 1052 0 0.0
.text 566144 571108 4964 0.9
lock-app qpg6105+debug (read only) 517308 522272 4964 1.0
(read/write) 146936 146936 0 0.0
.bss 86688 87312 624 0.7
.data 988 988 0 0.0
.text 511988 516952 4964 1.0
persistent-storage-app qpg6105+debug (read only) 107140 99548 -7592 -7.1
(read/write) 146940 146940 0 0.0
.bss 38504 24004 -14500 -37.7
.data 288 176 -112 -38.9
.text 101820 94228 -7592 -7.5
telink lighting-app tlsr9518adk80d (read/write) 845810 852074 6264 0.7
bss 85296 85916 620 0.7
noinit 37160 37160 0 0.0
text 592928 597990 5062 0.9

@andy31415 andy31415 mentioned this pull request Feb 3, 2022
Merged
@github-actions
Copy link

github-actions bot commented Feb 3, 2022 •
edited
Loading

PR #14713: Size comparison from 11182e6 to 7eee826

Increases above 0.2%:

platform target config section 11182e6 7eee826 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577610 592634 15024 2.6
.app_xip_area 485104 498608 13504 2.8
.bss 75252 76748 1496 2.0
.data 596 620 24 4.0
lock cyw930739m2evb_01 (read/write) 535354 550474 15120 2.8
.app_xip_area 444416 458016 13600 3.1
.bss 73724 75220 1496 2.0
.data 560 584 24 4.3
ota-requestor cyw930739m2evb_01 (read/write) 559842 574926 15084 2.7
.app_xip_area 459584 473148 13564 3.0
.bss 82716 84212 1496 1.8
.data 504 528 24 4.8
efr32 lighting-app BRD4161A (read only) 844296 863936 19640 2.3
(read/write) 124784 126512 1728 1.4
.bss 122896 124592 1696 1.4
.data 1888 1920 32 1.7
.text 844288 863928 19640 2.3
BRD4161A+rpc (read only) 831672 851384 19712 2.4
(read/write) 141448 143176 1728 1.2
.bss 139456 141152 1696 1.2
.data 1988 2020 32 1.6
.text 831664 851376 19712 2.4
window-app BRD4161A (read only) 816372 836084 19712 2.4
(read/write) 123416 125144 1728 1.4
.bss 121572 123268 1696 1.4
.data 1844 1876 32 1.7
.text 816364 836076 19712 2.4
k32w light k32w061+release (read/write) 661848 676904 15056 2.3
.bss 74948 76460 1512 2.0
.data 1848 1880 32 1.7
.text 579252 592764 13512 2.3
lock k32w061+release (read/write) 663308 678396 15088 2.3
.bss 75276 76772 1496 2.0
.data 1888 1920 32 1.7
.text 580344 593904 13560 2.3
linux bridge-app debug+rpc (read only) 1636565 1695485 58920 3.6
(read/write) 80552 84536 3984 4.9
.bss 36032 39296 3264 9.1
.data 1922 1986 64 3.3
.data.rel.ro 37440 38096 656 1.8
.init_array 544 560 16 2.9
.rodata 137620 139028 1408 1.0
.text 1383877 1440165 56288 4.1
chip-tool debug (read only) 7175053 7218549 43496 0.6
.data.rel.ro 145392 145736 344 0.2
.text 6398229 6440725 42496 0.7
chip-tool-ipv6only arm64 (read only) 7120532 7167300 46768 0.7
.text 6127236 6173140 45904 0.7
door-lock-app debug (read only) 1857801 1893057 35256 1.9
(read/write) 110464 110696 232 0.2
.data.rel.ro 61856 62048 192 0.3
.init_array 664 672 8 1.2
.rodata 170940 171804 864 0.5
.text 1538818 1572994 34176 2.2
lighting-app debug+rpc (read only) 1959233 1995353 36120 1.8
(read/write) 115584 115816 232 0.2
.data.rel.ro 65504 65696 192 0.3
.init_array 704 712 8 1.1
.rodata 160945 161777 832 0.5
.text 1643890 1678962 35072 2.1
ota-provider-app debug (read only) 1640257 1691313 51056 3.1
(read/write) 80040 80560 520 0.6
.data 1064 1096 32 3.0
.data.rel.ro 32376 32808 432 1.3
.init_array 608 616 8 1.3
.rodata 148486 149414 928 0.6
.text 1374354 1423858 49504 3.6
ota-requestor-app debug (read only) 1645849 1696513 50664 3.1
(read/write) 83024 83512 488 0.6
.data 1096 1128 32 2.9
.data.rel.ro 34248 34616 368 1.1
.init_array 616 624 8 1.3
.rodata 143831 144727 896 0.6
.text 1385778 1434946 49168 3.5
thermostat-no-ble arm64 (read only) 2091644 2121948 30304 1.4
.data.rel.ro 74624 74904 280 0.4
.init_array 328 336 8 2.4
.text 1743168 1772864 29696 1.7
tv-app debug (read only) 2412745 2512761 100016 4.1
(read/write) 138800 139640 840 0.6
.data.rel.ro 72504 73272 768 1.1
.init_array 872 880 8 0.9
.rodata 191852 193292 1440 0.8
.text 2049410 2146402 96992 4.7
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2339000 2347256 8256 0.4
.bss 177888 181080 3192 1.8
.data 5560 5592 32 0.6
.text 1301600 1309856 8256 0.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2302800 2311112 8312 0.4
.bss 177784 180960 3176 1.8
.data 5544 5576 32 0.6
.text 1265400 1273712 8312 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2293244 2301492 8248 0.4
.bss 175052 178244 3192 1.8
.data 5360 5392 32 0.6
.text 1255816 1264064 8248 0.7
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981199 1000235 19036 1.9
bss 118264 121164 2900 2.5
rodata 116452 117624 1172 1.0
text 668704 682560 13856 2.1
nrf52840dk_nrf52840+rpc (read/write) 966775 982155 15380 1.6
bss 115308 117020 1712 1.5
rodata 107924 109008 1084 1.0
text 665148 677724 12576 1.9
nrf52840dongle_nrf52840 (read/write) 997263 1017015 19752 2.0
bss 119436 122528 3092 2.6
rodata 115296 116512 1216 1.1
text 674080 688088 14008 2.1
nrf5340dk_nrf5340_cpuapp (read/write) 890414 909642 19228 2.2
bss 115048 117728 2680 2.3
rodata 109744 110916 1172 1.1
text 584892 600260 15368 2.6
lock-app nrf52840dk_nrf52840 (read/write) 913559 932391 18832 2.1
bss 116624 119500 2876 2.5
rodata 104724 105948 1224 1.2
text 614812 628456 13644 2.2
nrf5340dk_nrf5340_cpuapp (read/write) 823606 842630 19024 2.3
bss 113444 116092 2648 2.3
rodata 97928 99152 1224 1.2
text 531776 546928 15152 2.8
pump-app nrf52840dk_nrf52840 (read/write) 916227 935043 18816 2.1
bss 116384 119256 2872 2.5
rodata 105240 106464 1224 1.2
text 617156 630792 13636 2.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 911435 930107 18672 2.0
bss 116392 119264 2872 2.5
rodata 104344 105568 1224 1.2
text 613212 626732 13520 2.2
shell nrf52840dk_nrf52840 (read/write) 798959 802799 3840 0.5
bss 109780 110976 1196 1.1
text 534296 535724 1428 0.3
p6 light-app default (read/write) 2340816 2352496 11680 0.5
.bss 103092 106268 3176 3.1
.data 2400 2432 32 1.3
.text 1299080 1310760 11680 0.9
lock-app default (read/write) 2305848 2317608 11760 0.5
.bss 102804 105980 3176 3.1
.data 2360 2392 32 1.4
.text 1264112 1275872 11760 0.9
qpg lighting-app qpg6105+debug (read only) 571464 584280 12816 2.2
.bss 87240 88744 1504 1.7
.data 1052 1084 32 3.0
.text 566144 578960 12816 2.3
lock-app qpg6105+debug (read only) 517308 530244 12936 2.5
.bss 86688 88184 1496 1.7
.data 988 1020 32 3.2
.text 511988 524924 12936 2.5
telink lighting-app tlsr9518adk80d (read/write) 845810 864190 18380 2.2
bss 85296 89100 3804 4.5
text 592928 606216 13288 2.2
Increases (36 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 11182e6 7eee826 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577610 592634 15024 2.6
.app_xip_area 485104 498608 13504 2.8
.bss 75252 76748 1496 2.0
.data 596 620 24 4.0
lock cyw930739m2evb_01 (read/write) 535354 550474 15120 2.8
.app_xip_area 444416 458016 13600 3.1
.bss 73724 75220 1496 2.0
.data 560 584 24 4.3
ota-requestor cyw930739m2evb_01 (read/write) 559842 574926 15084 2.7
.app_xip_area 459584 473148 13564 3.0
.bss 82716 84212 1496 1.8
.data 504 528 24 4.8
efr32 lighting-app BRD4161A (read only) 844296 863936 19640 2.3
(read/write) 124784 126512 1728 1.4
.bss 122896 124592 1696 1.4
.data 1888 1920 32 1.7
.text 844288 863928 19640 2.3
BRD4161A+rpc (read only) 831672 851384 19712 2.4
(read/write) 141448 143176 1728 1.2
.bss 139456 141152 1696 1.2
.data 1988 2020 32 1.6
.text 831664 851376 19712 2.4
window-app BRD4161A (read only) 816372 836084 19712 2.4
(read/write) 123416 125144 1728 1.4
.bss 121572 123268 1696 1.4
.data 1844 1876 32 1.7
.text 816364 836076 19712 2.4
k32w light k32w061+release (read/write) 661848 676904 15056 2.3
.bss 74948 76460 1512 2.0
.data 1848 1880 32 1.7
.text 579252 592764 13512 2.3
lock k32w061+release (read/write) 663308 678396 15088 2.3
.bss 75276 76772 1496 2.0
.data 1888 1920 32 1.7
.text 580344 593904 13560 2.3
linux all-clusters-app debug (read only) 2308881 2310225 1344 0.1
.text 1942866 1944210 1344 0.1
bridge-app debug+rpc (read only) 1636565 1695485 58920 3.6
(read/write) 80552 84536 3984 4.9
.bss 36032 39296 3264 9.1
.data 1922 1986 64 3.3
.data.rel.ro 37440 38096 656 1.8
.init_array 544 560 16 2.9
.rodata 137620 139028 1408 1.0
.text 1383877 1440165 56288 4.1
chip-tool debug (read only) 7175053 7218549 43496 0.6
(read/write) 181832 182152 320 0.2
.data.rel.ro 145392 145736 344 0.2
.rodata 408469 408629 160 0.0
.text 6398229 6440725 42496 0.7
chip-tool-ipv6only arm64 (read only) 7120532 7167300 46768 0.7
(read/write) 284545 284929 384 0.1
.data.rel.ro 186712 187056 344 0.2
.got 45344 45376 32 0.1
.text 6127236 6173140 45904 0.7
door-lock-app debug (read only) 1857801 1893057 35256 1.9
(read/write) 110464 110696 232 0.2
.bss 42240 42272 32 0.1
.data.rel.ro 61856 62048 192 0.3
.init_array 664 672 8 1.2
.rodata 170940 171804 864 0.5
.text 1538818 1572994 34176 2.2
lighting-app debug+rpc (read only) 1959233 1995353 36120 1.8
(read/write) 115584 115816 232 0.2
.bss 43192 43224 32 0.1
.data.rel.ro 65504 65696 192 0.3
.init_array 704 712 8 1.1
.rodata 160945 161777 832 0.5
.text 1643890 1678962 35072 2.1
ota-provider-app debug (read only) 1640257 1691313 51056 3.1
(read/write) 80040 80560 520 0.6
.bss 41088 41152 64 0.2
.data 1064 1096 32 3.0
.data.rel.ro 32376 32808 432 1.3
.init_array 608 616 8 1.3
.rodata 148486 149414 928 0.6
.text 1374354 1423858 49504 3.6
ota-requestor-app debug (read only) 1645849 1696513 50664 3.1
(read/write) 83024 83512 488 0.6
.bss 42400 42464 64 0.2
.data 1096 1128 32 2.9
.data.rel.ro 34248 34616 368 1.1
.init_array 616 624 8 1.3
.rodata 143831 144727 896 0.6
.text 1385778 1434946 49168 3.5
shell debug (read only) 2283153 2283233 80 0.0
.text 1922322 1922402 80 0.0
thermostat-no-ble arm64 (read only) 2091644 2121948 30304 1.4
(read/write) 140401 140737 336 0.2
.bss 57713 57761 48 0.1
.data.rel.ro 74624 74904 280 0.4
.got 4144 4152 8 0.2
.init_array 328 336 8 2.4
.rodata 130764 131084 320 0.2
.text 1743168 1772864 29696 1.7
tv-app debug (read only) 2412745 2512761 100016 4.1
(read/write) 138800 139640 840 0.6
.bss 57184 57248 64 0.1
.data.rel.ro 72504 73272 768 1.1
.init_array 872 880 8 0.9
.rodata 191852 193292 1440 0.8
.text 2049410 2146402 96992 4.7
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2339000 2347256 8256 0.4
.bss 177888 181080 3192 1.8
.data 5560 5592 32 0.6
.text 1301600 1309856 8256 0.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2302800 2311112 8312 0.4
.bss 177784 180960 3176 1.8
.data 5544 5576 32 0.6
.text 1265400 1273712 8312 0.7
shell CY8CPROTO_062_4343W+release (read/write) 2293244 2301492 8248 0.4
.bss 175052 178244 3192 1.8
.data 5360 5392 32 0.6
.text 1255816 1264064 8248 0.7
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981199 1000235 19036 1.9
bss 118264 121164 2900 2.5
rodata 116452 117624 1172 1.0
text 668704 682560 13856 2.1
nrf52840dk_nrf52840+rpc (read/write) 966775 982155 15380 1.6
bss 115308 117020 1712 1.5
rodata 107924 109008 1084 1.0
text 665148 677724 12576 1.9
nrf52840dongle_nrf52840 (read/write) 997263 1017015 19752 2.0
bss 119436 122528 3092 2.6
rodata 115296 116512 1216 1.1
text 674080 688088 14008 2.1
nrf5340dk_nrf5340_cpuapp (read/write) 890414 909642 19228 2.2
bss 115048 117728 2680 2.3
rodata 109744 110916 1172 1.1
text 584892 600260 15368 2.6
lock-app nrf52840dk_nrf52840 (read/write) 913559 932391 18832 2.1
bss 116624 119500 2876 2.5
rodata 104724 105948 1224 1.2
text 614812 628456 13644 2.2
nrf5340dk_nrf5340_cpuapp (read/write) 823606 842630 19024 2.3
bss 113444 116092 2648 2.3
rodata 97928 99152 1224 1.2
text 531776 546928 15152 2.8
pump-app nrf52840dk_nrf52840 (read/write) 916227 935043 18816 2.1
bss 116384 119256 2872 2.5
rodata 105240 106464 1224 1.2
text 617156 630792 13636 2.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 911435 930107 18672 2.0
bss 116392 119264 2872 2.5
rodata 104344 105568 1224 1.2
text 613212 626732 13520 2.2
shell nrf52840dk_nrf52840 (read/write) 798959 802799 3840 0.5
bss 109780 110976 1196 1.1
rodata 78388 78532 144 0.2
text 534296 535724 1428 0.3
p6 light-app default (read/write) 2340816 2352496 11680 0.5
.bss 103092 106268 3176 3.1
.data 2400 2432 32 1.3
.text 1299080 1310760 11680 0.9
lock-app default (read/write) 2305848 2317608 11760 0.5
.bss 102804 105980 3176 3.1
.data 2360 2392 32 1.4
.text 1264112 1275872 11760 0.9
qpg lighting-app qpg6105+debug (read only) 571464 584280 12816 2.2
.bss 87240 88744 1504 1.7
.data 1052 1084 32 3.0
.text 566144 578960 12816 2.3
lock-app qpg6105+debug (read only) 517308 530244 12936 2.5
.bss 86688 88184 1496 1.7
.data 988 1020 32 3.2
.text 511988 524924 12936 2.5
telink lighting-app tlsr9518adk80d (read/write) 845810 864190 18380 2.2
bss 85296 89100 3804 4.5
text 592928 606216 13288 2.2
Decreases (4 builds for esp32, linux, qpg)
platform target config section 11182e6 7eee826 change % change
esp32 all-clusters-app c3devkit (read only) 934636 934622 -14 -0.0
.flash.text 934636 934622 -14 -0.0
m5stack (read only) 982819 982803 -16 -0.0
.flash.text 977435 977419 -16 -0.0
linux chip-tool-ipv6only arm64 .rodata 391564 391436 -128 -0.0
qpg persistent-storage-app qpg6105+debug (read only) 107140 99548 -7592 -7.1
.bss 38504 24004 -14500 -37.7
.data 288 176 -112 -38.9
.text 101820 94228 -7592 -7.5
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 11182e6 7eee826 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577610 592634 15024 2.6
.app_xip_area 485104 498608 13504 2.8
.bss 75252 76748 1496 2.0
.data 596 620 24 4.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535354 550474 15120 2.8
.app_xip_area 444416 458016 13600 3.1
.bss 73724 75220 1496 2.0
.data 560 584 24 4.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559842 574926 15084 2.7
.app_xip_area 459584 473148 13564 3.0
.bss 82716 84212 1496 1.8
.data 504 528 24 4.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 844296 863936 19640 2.3
(read/write) 124784 126512 1728 1.4
.bss 122896 124592 1696 1.4
.data 1888 1920 32 1.7
.text 844288 863928 19640 2.3
BRD4161A+rpc (read only) 831672 851384 19712 2.4
(read/write) 141448 143176 1728 1.2
.bss 139456 141152 1696 1.2
.data 1988 2020 32 1.6
.text 831664 851376 19712 2.4
window-app BRD4161A (read only) 816372 836084 19712 2.4
(read/write) 123416 125144 1728 1.4
.bss 121572 123268 1696 1.4
.data 1844 1876 32 1.7
.text 816364 836076 19712 2.4
esp32 all-clusters-app c3devkit (read only) 934636 934622 -14 -0.0
(read/write) 1401074 1401074 0 0.0
.dram0.bss 70056 70056 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197848 197848 0 0.0
.flash.text 934636 934622 -14 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982819 982803 -16 -0.0
(read/write) 465428 465428 0 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224460 224460 0 0.0
.flash.text 977435 977419 -16 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661848 676904 15056 2.3
.bss 74948 76460 1512 2.0
.data 1848 1880 32 1.7
.text 579252 592764 13512 2.3
lock k32w061+release (read/write) 663308 678396 15088 2.3
.bss 75276 76772 1496 2.0
.data 1888 1920 32 1.7
.text 580344 593904 13560 2.3
linux all-clusters-app debug (read only) 2308881 2310225 1344 0.1
(read/write) 139872 139872 0 0.0
.bss 54592 54592 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204037 204037 0 0.0
.text 1942866 1944210 1344 0.1
bridge-app debug+rpc (read only) 1636565 1695485 58920 3.6
(read/write) 80552 84536 3984 4.9
.bss 36032 39296 3264 9.1
.data 1922 1986 64 3.3
.data.rel.ro 37440 38096 656 1.8
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 544 560 16 2.9
.rodata 137620 139028 1408 1.0
.text 1383877 1440165 56288 4.1
chip-tool debug (read only) 7175053 7218549 43496 0.6
(read/write) 181832 182152 320 0.2
.bss 29352 29352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 145392 145736 344 0.2
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 408469 408629 160 0.0
.text 6398229 6440725 42496 0.7
chip-tool-ipv6only arm64 (read only) 7120532 7167300 46768 0.7
(read/write) 284545 284929 384 0.1
.bss 47585 47585 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186712 187056 344 0.2
.dynamic 560 560 0 0.0
.got 45344 45376 32 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 391564 391436 -128 -0.0
.text 6127236 6173140 45904 0.7
door-lock-app debug (read only) 1857801 1893057 35256 1.9
(read/write) 110464 110696 232 0.2
.bss 42240 42272 32 0.1
.data 962 962 0 0.0
.data.rel.ro 61856 62048 192 0.3
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 672 8 1.2
.rodata 170940 171804 864 0.5
.text 1538818 1572994 34176 2.2
lighting-app debug+rpc (read only) 1959233 1995353 36120 1.8
(read/write) 115584 115816 232 0.2
.bss 43192 43224 32 0.1
.data 1392 1392 0 0.0
.data.rel.ro 65504 65696 192 0.3
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 704 712 8 1.1
.rodata 160945 161777 832 0.5
.text 1643890 1678962 35072 2.1
ota-provider-app debug (read only) 1640257 1691313 51056 3.1
(read/write) 80040 80560 520 0.6
.bss 41088 41152 64 0.2
.data 1064 1096 32 3.0
.data.rel.ro 32376 32808 432 1.3
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 608 616 8 1.3
.rodata 148486 149414 928 0.6
.text 1374354 1423858 49504 3.6
ota-requestor-app debug (read only) 1645849 1696513 50664 3.1
(read/write) 83024 83512 488 0.6
.bss 42400 42464 64 0.2
.data 1096 1128 32 2.9
.data.rel.ro 34248 34616 368 1.1
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 616 624 8 1.3
.rodata 143831 144727 896 0.6
.text 1385778 1434946 49168 3.5
shell debug (read only) 2283153 2283233 80 0.0
(read/write) 141360 141360 0 0.0
.bss 62016 62016 0 0.0
.data 768 768 0 0.0
.data.rel.ro 72896 72896 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 204786 204786 0 0.0
.text 1922322 1922402 80 0.0
thermostat-no-ble arm64 (read only) 2091644 2121948 30304 1.4
(read/write) 140401 140737 336 0.2
.bss 57713 57761 48 0.1
.data 952 952 0 0.0
.data.rel.ro 74624 74904 280 0.4
.dynamic 560 560 0 0.0
.got 4144 4152 8 0.2
.init 24 24 0 0.0
.init_array 328 336 8 2.4
.rodata 130764 131084 320 0.2
.text 1743168 1772864 29696 1.7
tv-app debug (read only) 2412745 2512761 100016 4.1
(read/write) 138800 139640 840 0.6
.bss 57184 57248 64 0.1
.data 3104 3104 0 0.0
.data.rel.ro 72504 73272 768 1.1
.dynamic 592 592 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 872 880 8 0.9
.rodata 191852 193292 1440 0.8
.text 2049410 2146402 96992 4.7
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386320 2386320 0 0.0
.bss 188964 188964 0 0.0
.data 5280 5280 0 0.0
.text 1348920 1348920 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2339000 2347256 8256 0.4
.bss 177888 181080 3192 1.8
.data 5560 5592 32 0.6
.text 1301600 1309856 8256 0.6
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302800 2311112 8312 0.4
.bss 177784 180960 3176 1.8
.data 5544 5576 32 0.6
.text 1265400 1273712 8312 0.7
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293244 2301492 8248 0.4
.bss 175052 178244 3192 1.8
.data 5360 5392 32 0.6
.text 1255816 1264064 8248 0.7
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981199 1000235 19036 1.9
bss 118264 121164 2900 2.5
rodata 116452 117624 1172 1.0
text 668704 682560 13856 2.1
nrf52840dk_nrf52840+rpc (read/write) 966775 982155 15380 1.6
bss 115308 117020 1712 1.5
rodata 107924 109008 1084 1.0
text 665148 677724 12576 1.9
nrf52840dongle_nrf52840 (read/write) 997263 1017015 19752 2.0
bss 119436 122528 3092 2.6
rodata 115296 116512 1216 1.1
text 674080 688088 14008 2.1
nrf5340dk_nrf5340_cpuapp (read/write) 890414 909642 19228 2.2
bss 115048 117728 2680 2.3
rodata 109744 110916 1172 1.1
text 584892 600260 15368 2.6
lock-app nrf52840dk_nrf52840 (read/write) 913559 932391 18832 2.1
bss 116624 119500 2876 2.5
rodata 104724 105948 1224 1.2
text 614812 628456 13644 2.2
nrf5340dk_nrf5340_cpuapp (read/write) 823606 842630 19024 2.3
bss 113444 116092 2648 2.3
rodata 97928 99152 1224 1.2
text 531776 546928 15152 2.8
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916227 935043 18816 2.1
bss 116384 119256 2872 2.5
rodata 105240 106464 1224 1.2
text 617156 630792 13636 2.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 911435 930107 18672 2.0
bss 116392 119264 2872 2.5
rodata 104344 105568 1224 1.2
text 613212 626732 13520 2.2
shell nrf52840dk_nrf52840 (read/write) 798959 802799 3840 0.5
bss 109780 110976 1196 1.1
rodata 78388 78532 144 0.2
text 534296 535724 1428 0.3
p6 all-clusters-app default (read/write) 2447176 2447176 0 0.0
.bss 117124 117124 0 0.0
.data 2568 2568 0 0.0
.text 1405440 1405440 0 0.0
light-app default (read/write) 2340816 2352496 11680 0.5
.bss 103092 106268 3176 3.1
.data 2400 2432 32 1.3
.text 1299080 1310760 11680 0.9
lock-app default (read/write) 2305848 2317608 11760 0.5
.bss 102804 105980 3176 3.1
.data 2360 2392 32 1.4
.text 1264112 1275872 11760 0.9
qpg lighting-app qpg6105+debug (read only) 571464 584280 12816 2.2
(read/write) 146936 146936 0 0.0
.bss 87240 88744 1504 1.7
.data 1052 1084 32 3.0
.text 566144 578960 12816 2.3
lock-app qpg6105+debug (read only) 517308 530244 12936 2.5
(read/write) 146936 146936 0 0.0
.bss 86688 88184 1496 1.7
.data 988 1020 32 3.2
.text 511988 524924 12936 2.5
persistent-storage-app qpg6105+debug (read only) 107140 99548 -7592 -7.1
(read/write) 146940 146940 0 0.0
.bss 38504 24004 -14500 -37.7
.data 288 176 -112 -38.9
.text 101820 94228 -7592 -7.5
telink lighting-app tlsr9518adk80d (read/write) 845810 864190 18380 2.2
bss 85296 89100 3804 4.5
noinit 37160 37160 0 0.0
text 592928 606216 13288 2.2

bzbarsky-apple
bzbarsky-apple requested changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The important parts to fix are the comparison of random data and the pointer-to-unwound-stack problem.

examples/shell/mbed/main/include/CHIPProjectConfig.h Outdated Show resolved Hide resolved
examples/shell/nrfconnect/CHIPProjectConfig.h Outdated Show resolved Hide resolved
examples/shell/mbed/main/include/CHIPProjectConfig.h Outdated Show resolved Hide resolved
examples/shell/nrfconnect/CHIPProjectConfig.h Outdated Show resolved Hide resolved
examples/shell/nxp/k32w/k32w0/BUILD.gn Outdated Show resolved Hide resolved
src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp Outdated Show resolved Hide resolved
src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp Outdated Show resolved Hide resolved
src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp Show resolved Hide resolved
src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp Show resolved Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp Outdated Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple merged commit a92d1a8 into project-chip:master Feb 7, 2022
mkardous-silabs added a commit to mkardous-silabs/connectedhomeip that referenced this pull request Feb 7, 2022
@mkardous-silabs
Revert "Implement a Generic Network commissioning Thread Driver (proj…
51662b7 
…ect-chip#14713)"

This reverts commit a92d1a8.
@jmartinez-silabs jmartinez-silabs mentioned this pull request Feb 18, 2022
Closed
15 tasks
jmartinez-silabs added a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Feb 21, 2022
@jmartinez-silabs @restyled-commits
Implement a Generic Network commissioning Thread Driver (project-chip…
4985953 
…#14713)

* Create a generic Network commissioning Thread Driver

* Add OnThreadAttachFinished to send Connect network response

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Fix linux build

do not build GenericNetworkCommissioningThreadDriver for linux

* Fix a few sample app builds

* fix shell app for all

* cleaner fix for shell

* Remove OtScanResponseIterator, Scan handling not yet implement. Need rework to not use vector

* address PR comments

Co-authored-by: Restyled.io <[email protected]>
@jmartinez-silabs jmartinez-silabs mentioned this pull request Feb 21, 2022
Merged
andy31415 pushed a commit that referenced this pull request Feb 21, 2022
@jmartinez-silabs @restyled-commits
Cherry pick Generic Thread Network commissioning Driver (#15392)
61b9433 
* Implement a Generic Network commissioning Thread Driver (#14713)

* Create a generic Network commissioning Thread Driver

* Add OnThreadAttachFinished to send Connect network response

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Fix linux build

do not build GenericNetworkCommissioningThreadDriver for linux

* Fix a few sample app builds

* fix shell app for all

* cleaner fix for shell

* Remove OtScanResponseIterator, Scan handling not yet implement. Need rework to not use vector

* address PR comments

Co-authored-by: Restyled.io <[email protected]>

* support Thread Scan Network (#15105)

fix malloc and release issue

Cleanup + restyle

Co-authored-by: Restyled.io <[email protected]>
@jmartinez-silabs jmartinez-silabs deleted the network_commissioning branch March 31, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@selissia selissia selissia approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

Assignees
No one assigned
Labels
efr32 examples linux openthread platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmartinez-silabs @andy31415 @selissia @bzbarsky-apple @jmeg-sfy @restyled-commits