Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group] [Yaml] Add error if GroupId field isn't used properly in yaml test #14614

Merged
merged 2 commits into from
Feb 2, 2022
Merged

[Group] [Yaml] Add error if GroupId field isn't used properly in yaml test #14614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c84959
Add error if GroupId field isn't use properly
jepenven-silabs Feb 1, 2022
a440ee0
fix typo
jepenven-silabs Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/app/zap-templates/common/ClusterTestGeneration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,13 @@ function setDefaultTypeForCommand(test)
break;
}

// Sanity Check for GroupId usage
// Only two types of actions can be send to Group : Write attribute, and Commands
// Spec : Action 8.2.4
if ((kGroupId in test) && !test.isGroupCommand) {
printErrorAndExit(this, 'Wrong Yaml configuration. Action : ' + test.commandName + " can't be sent to group " + test[kGroupId]);
}

test.isWait = false;
}

Expand Down