-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] [Yaml] Add error if GroupId field isn't used properly in yaml test #14614
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:add_warning_in_yaml
Feb 2, 2022
Merged
[Group] [Yaml] Add error if GroupId field isn't used properly in yaml test #14614
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:add_warning_in_yaml
Feb 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
isiu-apple,
jelderton,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
mspang,
robszewczyk,
sagar-apple and
saurabhst
February 1, 2022 02:21
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 1, 2022 02:21
jepenven-silabs
changed the title
[Group] [Yaml] Add error if GroupId field isn't use properly in yaml test
[Group] [Yaml] Add error if GroupId field isn't used properly in yaml test
Feb 1, 2022
PR #14614: Size comparison from f09c5fc to 1836868 Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 1, 2022
jmeg-sfy
approved these changes
Feb 1, 2022
PR #14614: Size comparison from f09c5fc to 4aa0be8 Increases (9 builds for nrfconnect)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Feb 1, 2022
/rebase |
woody-apple
force-pushed
the
add_warning_in_yaml
branch
from
February 2, 2022 04:49
4aa0be8
to
a440ee0
Compare
PR #14614: Size comparison from 46ab4be to a440ee0 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast tracked since already approved by 3 reviewers and no big changes were made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No sanity check in ClusterTestGeneration for the usage of the GroupId field
Fix : #11851
Change overview
Error out is a GroupId is set for an action that doesn't support Group.
Testing
Tested by regenerating everything with a GroupId in a Read action (failed as expected)