Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop incorrectly flagging door lock events as fabric-scoped. #14582

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Stop incorrectly flagging door lock events as fabric-scoped. #14582

merged 1 commit into from
Jan 30, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #14365
Fixes #14573

Problem

See above.

Change overview

See above.

Testing

Looked at resulting codegen.

@boring-cyborg boring-cyborg bot added the app label Jan 29, 2022
@github-actions
Copy link

github-actions bot commented Jan 29, 2022 •
edited
Loading

PR #14582: Size comparison from 43a1e1a to 4775a04

Decreases (3 builds for esp32, p6)
platform target config section 43a1e1a 4775a04 change % change
esp32 all-clusters-app c3devkit (read only) 934340 934328 -12 -0.0
.flash.text 934340 934328 -12 -0.0
m5stack (read only) 982047 982043 -4 -0.0
.flash.text 976663 976659 -4 -0.0
p6 all-clusters-app default (read/write) 2444616 2444584 -32 -0.0
.text 1402880 1402848 -32 -0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 43a1e1a 4775a04 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 578558 0 0.0
.app_xip_area 484532 484532 0 0.0
.bss 76772 76772 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536618 536618 0 0.0
.app_xip_area 444160 444160 0 0.0
.bss 75244 75244 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843432 843432 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124416 124416 0 0.0
.data 1900 1900 0 0.0
.text 843424 843424 0 0.0
BRD4161A+rpc (read only) 830792 830792 0 0.0
(read/write) 142976 142976 0 0.0
.bss 140976 140976 0 0.0
.data 2000 2000 0 0.0
.text 830784 830784 0 0.0
window-app BRD4161A (read only) 816032 816032 0 0.0
(read/write) 124948 124948 0 0.0
.bss 123092 123092 0 0.0
.data 1856 1856 0 0.0
.text 816024 816024 0 0.0
esp32 all-clusters-app c3devkit (read only) 934340 934328 -12 -0.0
(read/write) 1399050 1399050 0 0.0
.dram0.bss 69992 69992 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195888 195888 0 0.0
.flash.text 934340 934328 -12 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982047 982043 -4 -0.0
(read/write) 463404 463404 0 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222508 222508 0 0.0
.flash.text 976663 976659 -4 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663264 663264 0 0.0
.bss 76468 76468 0 0.0
.data 1868 1868 0 0.0
.text 579128 579128 0 0.0
lock k32w061+release (read/write) 664328 664328 0 0.0
.bss 76780 76780 0 0.0
.data 1892 1892 0 0.0
.text 579856 579856 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6997916 6997916 0 0.0
(read/write) 284257 284257 0 0.0
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178728 178728 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398308 398308 0 0.0
.text 6014484 6014484 0 0.0
thermostat-no-ble arm64 (read only) 2084604 2084604 0 0.0
(read/write) 149713 149713 0 0.0
.bss 67329 67329 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4168 4168 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130812 130812 0 0.0
.text 1736224 1736224 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384008 2384008 0 0.0
.bss 188892 188892 0 0.0
.data 5288 5288 0 0.0
.text 1346608 1346608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338336 2338336 0 0.0
.bss 179424 179424 0 0.0
.data 5584 5584 0 0.0
.text 1300936 1300936 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302440 2302440 0 0.0
.bss 179296 179296 0 0.0
.data 5552 5552 0 0.0
.text 1265040 1265040 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293052 2293052 0 0.0
.bss 176572 176572 0 0.0
.data 5384 5384 0 0.0
.text 1255624 1255624 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981899 981899 0 0.0
bss 119780 119780 0 0.0
rodata 115744 115744 0 0.0
text 668568 668568 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967451 967451 0 0.0
bss 116824 116824 0 0.0
rodata 107224 107224 0 0.0
text 665012 665012 0 0.0
nrf52840dongle_nrf52840 (read/write) 997971 997971 0 0.0
bss 120952 120952 0 0.0
rodata 114580 114580 0 0.0
text 673980 673980 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 891074 891074 0 0.0
bss 116568 116568 0 0.0
rodata 109028 109028 0 0.0
text 584748 584748 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 914531 914531 0 0.0
bss 118132 118132 0 0.0
rodata 104384 104384 0 0.0
text 614616 614616 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824582 824582 0 0.0
bss 114948 114948 0 0.0
rodata 97592 97592 0 0.0
text 531576 531576 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 917379 917379 0 0.0
bss 117888 117888 0 0.0
rodata 104896 104896 0 0.0
text 617140 617140 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912563 912563 0 0.0
bss 117896 117896 0 0.0
rodata 104000 104000 0 0.0
text 613188 613188 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2444616 2444584 -32 -0.0
.bss 117044 117044 0 0.0
.data 2584 2584 0 0.0
.text 1402880 1402848 -32 -0.0
light-app default (read/write) 2339984 2339984 0 0.0
.bss 104604 104604 0 0.0
.data 2408 2408 0 0.0
.text 1298248 1298248 0 0.0
lock-app default (read/write) 2305496 2305496 0 0.0
.bss 104324 104324 0 0.0
.data 2360 2360 0 0.0
.text 1263760 1263760 0 0.0
qpg lighting-app qpg6105+debug (read only) 571208 571208 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88760 88760 0 0.0
.data 1060 1060 0 0.0
.text 565888 565888 0 0.0
lock-app qpg6105+debug (read only) 517384 517384 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88200 88200 0 0.0
.data 992 992 0 0.0
.text 512064 512064 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846378 846378 0 0.0
bss 86560 86560 0 0.0
noinit 37160 37160 0 0.0
text 592934 592934 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the door-lock-events-not-fabric-scoped branch from 4775a04 to 5dcc16a Compare January 29, 2022 17:05
@github-actions
Copy link

github-actions bot commented Jan 29, 2022 •
edited
Loading

PR #14582: Size comparison from ddb7ce7 to 5dcc16a

Decreases (3 builds for esp32, p6)
platform target config section ddb7ce7 5dcc16a change % change
esp32 all-clusters-app c3devkit (read only) 934340 934328 -12 -0.0
.flash.text 934340 934328 -12 -0.0
m5stack (read only) 982047 982043 -4 -0.0
.flash.text 976663 976659 -4 -0.0
p6 all-clusters-app default (read/write) 2444616 2444584 -32 -0.0
.text 1402880 1402848 -32 -0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ddb7ce7 5dcc16a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 578558 0 0.0
.app_xip_area 484532 484532 0 0.0
.bss 76772 76772 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536618 536618 0 0.0
.app_xip_area 444160 444160 0 0.0
.bss 75244 75244 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843432 843432 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124416 124416 0 0.0
.data 1900 1900 0 0.0
.text 843424 843424 0 0.0
BRD4161A+rpc (read only) 830792 830792 0 0.0
(read/write) 142976 142976 0 0.0
.bss 140976 140976 0 0.0
.data 2000 2000 0 0.0
.text 830784 830784 0 0.0
window-app BRD4161A (read only) 816032 816032 0 0.0
(read/write) 124948 124948 0 0.0
.bss 123092 123092 0 0.0
.data 1856 1856 0 0.0
.text 816024 816024 0 0.0
esp32 all-clusters-app c3devkit (read only) 934340 934328 -12 -0.0
(read/write) 1399050 1399050 0 0.0
.dram0.bss 69992 69992 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195888 195888 0 0.0
.flash.text 934340 934328 -12 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982047 982043 -4 -0.0
(read/write) 463404 463404 0 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222508 222508 0 0.0
.flash.text 976663 976659 -4 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663264 663264 0 0.0
.bss 76468 76468 0 0.0
.data 1868 1868 0 0.0
.text 579128 579128 0 0.0
lock k32w061+release (read/write) 664328 664328 0 0.0
.bss 76780 76780 0 0.0
.data 1892 1892 0 0.0
.text 579856 579856 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7026076 7026076 0 0.0
(read/write) 284257 284257 0 0.0
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178728 178728 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398324 398324 0 0.0
.text 6042628 6042628 0 0.0
thermostat-no-ble arm64 (read only) 2084604 2084604 0 0.0
(read/write) 149713 149713 0 0.0
.bss 67329 67329 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4168 4168 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130812 130812 0 0.0
.text 1736224 1736224 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384008 2384008 0 0.0
.bss 188892 188892 0 0.0
.data 5288 5288 0 0.0
.text 1346608 1346608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338336 2338336 0 0.0
.bss 179424 179424 0 0.0
.data 5584 5584 0 0.0
.text 1300936 1300936 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302440 2302440 0 0.0
.bss 179296 179296 0 0.0
.data 5552 5552 0 0.0
.text 1265040 1265040 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293052 2293052 0 0.0
.bss 176572 176572 0 0.0
.data 5384 5384 0 0.0
.text 1255624 1255624 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981899 981899 0 0.0
bss 119780 119780 0 0.0
rodata 115744 115744 0 0.0
text 668568 668568 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967451 967451 0 0.0
bss 116824 116824 0 0.0
rodata 107224 107224 0 0.0
text 665012 665012 0 0.0
nrf52840dongle_nrf52840 (read/write) 997971 997971 0 0.0
bss 120952 120952 0 0.0
rodata 114580 114580 0 0.0
text 673980 673980 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 891074 891074 0 0.0
bss 116568 116568 0 0.0
rodata 109028 109028 0 0.0
text 584748 584748 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 914531 914531 0 0.0
bss 118132 118132 0 0.0
rodata 104384 104384 0 0.0
text 614616 614616 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824582 824582 0 0.0
bss 114948 114948 0 0.0
rodata 97592 97592 0 0.0
text 531576 531576 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 917379 917379 0 0.0
bss 117888 117888 0 0.0
rodata 104896 104896 0 0.0
text 617140 617140 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912563 912563 0 0.0
bss 117896 117896 0 0.0
rodata 104000 104000 0 0.0
text 613188 613188 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2444616 2444584 -32 -0.0
.bss 117044 117044 0 0.0
.data 2584 2584 0 0.0
.text 1402880 1402848 -32 -0.0
light-app default (read/write) 2339984 2339984 0 0.0
.bss 104604 104604 0 0.0
.data 2408 2408 0 0.0
.text 1298248 1298248 0 0.0
lock-app default (read/write) 2305496 2305496 0 0.0
.bss 104324 104324 0 0.0
.data 2360 2360 0 0.0
.text 1263760 1263760 0 0.0
qpg lighting-app qpg6105+debug (read only) 571208 571208 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88760 88760 0 0.0
.data 1060 1060 0 0.0
.text 565888 565888 0 0.0
lock-app qpg6105+debug (read only) 517384 517384 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88200 88200 0 0.0
.data 992 992 0 0.0
.text 512064 512064 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846378 846378 0 0.0
bss 86560 86560 0 0.0
noinit 37160 37160 0 0.0
text 592934 592934 0 0.0

@andy31415 andy31415 merged commit 359fd43 into project-chip:master Jan 30, 2022
@bzbarsky-apple bzbarsky-apple deleted the door-lock-events-not-fabric-scoped branch January 30, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@LuDuda LuDuda LuDuda approved these changes

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
4 participants
@bzbarsky-apple @LuDuda @yunhanw-google @andy31415