Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event_is_fabric_scoped should be false for events that are not fabric-scoped! #14365

Closed
yunhanw-google opened this issue Jan 26, 2022 · 0 comments · Fixed by #14582
Closed

event_is_fabric_scoped should be false for events that are not fabric-scoped! #14365

yunhanw-google opened this issue Jan 26, 2022 · 0 comments · Fixed by #14582
Assignees
@yunhanw-google
Labels
V1.0

Comments

@yunhanw-google
Copy link
Contributor

This does not look right. event_is_fabric_scoped should be false for events that are not fabric-scoped!

Please do a followup to fix ZAP here and then fix this logic.

Originally posted by @bzbarsky-apple in #13907 (comment)
@yunhanw-google yunhanw-google self-assigned this Jan 26, 2022
@yunhanw-google yunhanw-google mentioned this issue Jan 26, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 29, 2022
@bzbarsky-apple
Stop incorrectly flagging door lock events as fabric-scoped.
4775a04 
Fixes project-chip#14365
Fixes project-chip#14573
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 29, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 29, 2022
@bzbarsky-apple
Stop incorrectly flagging door lock events as fabric-scoped.
5dcc16a 
Fixes project-chip#14365
Fixes project-chip#14573
andy31415 pushed a commit that referenced this issue Jan 30, 2022
@bzbarsky-apple
Stop incorrectly flagging door lock events as fabric-scoped. (#14582)
359fd43 
Fixes #14365
Fixes #14573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunhanw-google yunhanw-google

Labels
V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop incorrectly flagging door lock events as fabric-scoped. bzbarsky-apple/connectedhomeip
2 participants
@yunhanw-google @woody-apple