Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Update the template to allow chip-tool to issue wildcards commands #14361

Merged
merged 2 commits into from
Jan 27, 2022
Merged

[chip-tool] Update the template to allow chip-tool to issue wildcards commands #14361

merged 2 commits into from
Jan 27, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

chip-tool does not supports wildcards for reading/subscribing attributes/events.

Change overview

  • Add wildcards support

Testing

I still need to update the YAML framework to supports wildcards.

@vivien-apple vivien-apple self-assigned this Jan 26, 2022
@vivien-apple vivien-apple changed the title Chip tool wildcards land [chip-tool] Update the template to allow chip-tool to issue wildcards commands Jan 26, 2022
@restyled-io restyled-io bot mentioned this pull request Jan 26, 2022
Closed
@woody-apple
Copy link
Contributor

Fast tracking test/tooling changes, note still needs restyle.

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #14361: Size comparison from 5429dca to 98145fd

Decreases (1 build for linux)
platform target config section 5429dca 98145fd change % change
linux chip-tool-ipv6only arm64 (read only) 8904716 6534572 -2370144 -26.6
(read/write) 393649 275153 -118496 -30.1
.data.rel.ro 263656 174416 -89240 -33.8
.got 69728 40472 -29256 -42.0
.rodata 542916 377092 -165824 -30.5
.text 7514868 5595956 -1918912 -25.5
Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
platform target config section 5429dca 98145fd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580330 580330 0 0.0
.app_xip_area 485224 485224 0 0.0
.bss 77852 77852 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843316 843316 0 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843308 843308 0 0.0
BRD4161A+rpc (read only) 830672 830672 0 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830664 830664 0 0.0
window-app BRD4161A (read only) 815948 815948 0 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 815940 815940 0 0.0
esp32 all-clusters-app c3devkit (read only) 921116 921116 0 0.0
(read/write) 1384722 1384722 0 0.0
.dram0.bss 70872 70872 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180672 180672 0 0.0
.flash.text 921116 921116 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970111 970111 0 0.0
(read/write) 451744 451744 0 0.0
.dram0.bss 75616 75616 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209968 209968 0 0.0
.flash.text 964727 964727 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665192 665192 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579896 579896 0 0.0
lock k32w061+release (read/write) 666080 666080 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580496 580496 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8904716 6534572 -2370144 -26.6
(read/write) 393649 275153 -118496 -30.1
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 263656 174416 -89240 -33.8
.dynamic 560 560 0 0.0
.got 69728 40472 -29256 -42.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 542916 377092 -165824 -30.5
.text 7514868 5595956 -1918912 -25.5
thermostat-no-ble arm64 (read only) 2061828 2061828 0 0.0
(read/write) 148113 148113 0 0.0
.bss 66417 66417 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73712 73712 0 0.0
.dynamic 560 560 0 0.0
.got 4128 4128 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131428 131428 0 0.0
.text 1714416 1714416 0 0.0
p6 all-clusters-app default (read/write) 2415424 2415424 0 0.0
.bss 117924 117924 0 0.0
.data 2584 2584 0 0.0
.text 1373688 1373688 0 0.0
light-app default (read/write) 2338904 2338904 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297168 1297168 0 0.0
lock-app default (read/write) 2304440 2304440 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262704 1262704 0 0.0
qpg lighting-app qpg6105+debug (read only) 571964 571964 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566644 566644 0 0.0
lock-app qpg6105+debug (read only) 518060 518060 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512740 512740 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848046 848046 0 0.0
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592818 592818 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love all the code moving out of .zapt and into C++....

@vivien-apple vivien-apple force-pushed the ChipTool_WildcardsLand branch from 98145fd to 2fefc87 Compare January 27, 2022 09:27
@vivien-apple
Update the template to allow chip-tool to issue wildcards commands
da09f29 
Replace templates for attributes/events read/reports by built-in classes

Replace cluster 0xffffffff by Any and replace 0xffffffff attribute/event name by a commmand name read/report-by-id that lets use an arbitratry id
@vivien-apple
Update generated content
85d1224
@vivien-apple vivien-apple force-pushed the ChipTool_WildcardsLand branch from 2fefc87 to 85d1224 Compare January 27, 2022 09:35
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14361: Size comparison from 271f275 to 85d1224

Decreases (1 build for linux)
platform target config section 271f275 85d1224 change % change
linux chip-tool-ipv6only arm64 (read only) 8935692 6537388 -2398304 -26.8
(read/write) 394801 275153 -119648 -30.3
.data.rel.ro 264512 174424 -90088 -34.1
.got 70024 40472 -29552 -42.2
.rodata 544356 377140 -167216 -30.7
.text 7541700 5598724 -1942976 -25.8
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 271f275 85d1224 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 580442 0 0.0
.app_xip_area 485336 485336 0 0.0
.bss 77852 77852 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538446 538446 0 0.0
.app_xip_area 444884 444884 0 0.0
.bss 76348 76348 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843492 843492 0 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843484 843484 0 0.0
BRD4161A+rpc (read only) 830864 830864 0 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830856 830856 0 0.0
window-app BRD4161A (read only) 816108 816108 0 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 816100 816100 0 0.0
esp32 all-clusters-app c3devkit (read only) 923298 923298 0 0.0
(read/write) 1384986 1384986 0 0.0
.dram0.bss 70880 70880 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 180936 180936 0 0.0
.flash.text 923298 923298 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972227 972227 0 0.0
(read/write) 452016 452016 0 0.0
.dram0.bss 75624 75624 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 210232 210232 0 0.0
.flash.text 966843 966843 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665224 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579928 579928 0 0.0
lock k32w061+release (read/write) 666192 666192 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580608 580608 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8935692 6537388 -2398304 -26.8
(read/write) 394801 275153 -119648 -30.3
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264512 174424 -90088 -34.1
.dynamic 560 560 0 0.0
.got 70024 40472 -29552 -42.2
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544356 377140 -167216 -30.7
.text 7541700 5598724 -1942976 -25.8
thermostat-no-ble arm64 (read only) 2082804 2082804 0 0.0
(read/write) 151873 151873 0 0.0
.bss 69585 69585 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74208 74208 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1733616 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357384 2357384 0 0.0
.bss 189588 189588 0 0.0
.data 5296 5296 0 0.0
.text 1319984 1319984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2341088 0 0.0
.bss 181104 181104 0 0.0
.data 5584 5584 0 0.0
.text 1303688 1303688 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307840 2307840 0 0.0
.bss 181000 181000 0 0.0
.data 5568 5568 0 0.0
.text 1270440 1270440 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294044 2294044 0 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256616 1256616 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 983707 0 0.0
bss 120860 120860 0 0.0
rodata 116480 116480 0 0.0
text 668576 668576 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 967571 0 0.0
bss 117904 117904 0 0.0
rodata 108016 108016 0 0.0
text 663248 663248 0 0.0
nrf52840dongle_nrf52840 (read/write) 999827 999827 0 0.0
bss 122032 122032 0 0.0
rodata 115332 115332 0 0.0
text 674004 674004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 892930 0 0.0
bss 117648 117648 0 0.0
rodata 109780 109780 0 0.0
text 584756 584756 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916323 916323 0 0.0
bss 119240 119240 0 0.0
rodata 105120 105120 0 0.0
text 614560 614560 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826358 0 0.0
bss 116056 116056 0 0.0
rodata 98344 98344 0 0.0
text 531512 531512 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919187 0 0.0
bss 118992 118992 0 0.0
rodata 105632 105632 0 0.0
text 617096 617096 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914371 0 0.0
bss 119016 119016 0 0.0
rodata 104736 104736 0 0.0
text 613132 613132 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2418240 2418240 0 0.0
.bss 117932 117932 0 0.0
.data 2592 2592 0 0.0
.text 1376504 1376504 0 0.0
light-app default (read/write) 2339064 2339064 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297328 1297328 0 0.0
lock-app default (read/write) 2304584 2304584 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262848 1262848 0 0.0
qpg lighting-app qpg6105+debug (read only) 572036 572036 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566716 566716 0 0.0
lock-app qpg6105+debug (read only) 518164 518164 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512844 512844 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848158 848158 0 0.0
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592932 592932 0 0.0

@vivien-apple vivien-apple merged commit 40cc421 into project-chip:master Jan 27, 2022
vivien-apple added a commit to vivien-apple/connectedhomeip-1 that referenced this pull request Jan 27, 2022
@vivien-apple
[chip-tool] Use subscribe instead of report since it has been commite…
1c9a6db 
…d in project-chip#14231 but project-chip#14361 has landed right after with the keyword 'report'
@vivien-apple vivien-apple mentioned this pull request Jan 27, 2022
Merged
vivien-apple added a commit that referenced this pull request Jan 27, 2022
@vivien-apple
[chip-tool] Use subscribe instead of report since it has been commite…
30ed0c5 
…d in #14231 but #14361 has landed right after with the keyword 'report' (#14420)
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@vivien-apple @selissia
[chip-tool] Update the template to allow chip-tool to issue wildcards…
6c57520 
… commands (project-chip#14361)

* Update the template to allow chip-tool to issue wildcards commands

Replace templates for attributes/events read/reports by built-in classes

Replace cluster 0xffffffff by Any and replace 0xffffffff attribute/event name by a commmand name read/report-by-id that lets use an arbitratry id

* Update generated content
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@vivien-apple @selissia
[chip-tool] Use subscribe instead of report since it has been commite…
455ec29 
…d in project-chip#14231 but project-chip#14361 has landed right after with the keyword 'report' (project-chip#14420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

Assignees

@vivien-apple vivien-apple

Labels
app examples fast track
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @woody-apple @bzbarsky-apple