-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chip-tool commands to use subscribe instead of report #14231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d6aa50
to
778806e
Compare
PR #14231: Size comparison from f1808b7 to 778806e Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 25, 2022
bzbarsky-apple
approved these changes
Jan 25, 2022
chshu
approved these changes
Jan 26, 2022
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jan 27, 2022
…d in project-chip#14231 but project-chip#14361 has landed right after with the keyword 'report'
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…d in project-chip#14231 but project-chip#14361 has landed right after with the keyword 'report' (project-chip#14420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
examples/chip-tool
usesreport
command to subscribe to attributes andreport-event
command to subscribe to events. The names are quite confusing as it is the subscribe interaction that is initiated and it will be the other end that reports the data (attribute/event)Change overview
report -> subscribe
report-event -> subscribe-event
Testing