Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chip-tool commands to use subscribe instead of report #14231

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

dhrishi
Copy link
Contributor

@dhrishi dhrishi commented Jan 25, 2022

Problem

Currently, examples/chip-tool uses report command to subscribe to attributes and report-event command to subscribe to events. The names are quite confusing as it is the subscribe interaction that is initiated and it will be the other end that reports the data (attribute/event)

Change overview

  • Change the below commands:
    report -> subscribe
    report-event -> subscribe-event
  • Update generated code

Testing

  • Tested manual compilation of chip-tool
  • Verified that the changes are reflected in the help command:
$ ./out/debug/chip-tool switch
[1643113920.446514][379270:379270] CHIP:TOO: Missing command name
Usage:
  ./out/debug/chip-tool switch command_name [param1 param2 ...]

  +-------------------------------------------------------------------------------------+
  | Commands:                                                                           |
  +-------------------------------------------------------------------------------------+
  | * read                                                                              |
  | * subscribe                                                                         |
  | * read-event                                                                        |
  | * subscribe-event                                                                   |
  +-------------------------------------------------------------------------------------+
  • Verified using the actual subscribe, subscribe-event commands on all-clusters-app

@github-actions
Copy link

github-actions bot commented Jan 25, 2022

PR #14231: Size comparison from f1808b7 to 778806e

Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section f1808b7 778806e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573714 0 0.0
.app_xip_area 479016 479016 0 0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835484 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835476 0 0.0
BRD4161A+rpc (read only) 822864 822864 0 0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 822856 0 0.0
window-app BRD4161A (read only) 806324 806324 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806316 0 0.0
k32w light k32w061+release (read/write) 660864 660864 0 0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575972 575972 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576616 576616 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8639540 8639540 0 0.0
(read/write) 390961 390961 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260976 260976 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532716 532716 0 0.0
.text 7267860 7267860 0 0.0
thermostat-no-ble arm64 (read only) 2050492 2050492 0 0.0
(read/write) 145969 145969 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73160 73160 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706144 1706144 0 0.0
p6 all-clusters-app default (read/write) 2407448 2407448 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1365712 1365712 0 0.0
light-app default (read/write) 2330256 2330256 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288520 1288520 0 0.0
lock-app default (read/write) 2299664 2299664 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257928 1257928 0 0.0
qpg lighting-app qpg6105+debug (read only) 567092 567092 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561772 561772 0 0.0
lock-app qpg6105+debug (read only) 515752 515752 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510432 510432 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841062 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588184 588184 0 0.0

@woody-apple woody-apple merged commit d24d5b0 into project-chip:master Jan 26, 2022
vivien-apple added a commit to vivien-apple/connectedhomeip-1 that referenced this pull request Jan 27, 2022
vivien-apple added a commit that referenced this pull request Jan 27, 2022
…d in #14231 but #14361 has landed right after with the keyword 'report' (#14420)
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants