Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite reset loop in m5stack init #14268

Closed
wants to merge 1 commit into from

Conversation

msandstedt
Copy link
Contributor

Problem

Some new OTA code is causing the m5stack all-clusters-app to reset
during init, which results in an infinite reset loop.

Change overview

Root cause is that InitServer is dispatched to the work queue. But InitOTARequestor is executed immediately after this is dispatched, and yet depends upon InitServer. The solution is to call InitOTARequestor from InitServer.

Fixes #14267

Testing

Manually tested. m5stack all-clusters-app no longer exhibits the infinite reset loop with the fix.

Some new OTA code is causing the m5stack all-clusters-app to reset
during init, which results in an infinite reset loop.  This fixes it.

Fixes project-chip#14267
@msandstedt
Copy link
Contributor Author

Apparently fixed with #13849.

@msandstedt msandstedt closed this Jan 25, 2022
@github-actions
Copy link

github-actions bot commented Jan 25, 2022

PR #14268: Size comparison from de95567 to 046730d

Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section de95567 046730d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578006 578006 0 0.0
.app_xip_area 483064 483064 0 0.0
.bss 77688 77688 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 839388 839388 0 0.0
(read/write) 127228 127228 0 0.0
.bss 125328 125328 0 0.0
.data 1900 1900 0 0.0
.text 839380 839380 0 0.0
BRD4161A+rpc (read only) 826760 826760 0 0.0
(read/write) 143888 143888 0 0.0
.bss 141888 141888 0 0.0
.data 2000 2000 0 0.0
.text 826752 826752 0 0.0
window-app BRD4161A (read only) 811716 811716 0 0.0
(read/write) 125884 125884 0 0.0
.bss 124028 124028 0 0.0
.data 1856 1856 0 0.0
.text 811708 811708 0 0.0
esp32 all-clusters-app c3devkit (read only) 918896 918896 0 0.0
(read/write) 1384338 1384338 0 0.0
.dram0.bss 70704 70704 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180464 180464 0 0.0
.flash.text 918896 918896 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 968091 968091 0 0.0
(read/write) 451368 451368 0 0.0
.dram0.bss 75448 75448 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209760 209760 0 0.0
.flash.text 962707 962707 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662880 662880 0 0.0
.bss 77460 77460 0 0.0
.data 1868 1868 0 0.0
.text 577752 577752 0 0.0
lock k32w061+release (read/write) 663792 663792 0 0.0
.bss 77724 77724 0 0.0
.data 1892 1892 0 0.0
.text 578376 578376 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8716252 8716252 0 0.0
(read/write) 391585 391585 0 0.0
.bss 56033 56033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261440 261440 0 0.0
.dynamic 560 560 0 0.0
.got 69232 69232 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534420 534420 0 0.0
.text 7341284 7341284 0 0.0
thermostat-no-ble arm64 (read only) 2049708 2049708 0 0.0
(read/write) 146785 146785 0 0.0
.bss 65665 65665 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73192 73192 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131372 131372 0 0.0
.text 1703776 1703776 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353048 2353048 0 0.0
.bss 189412 189412 0 0.0
.data 5296 5296 0 0.0
.text 1315648 1315648 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338968 2338968 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1301568 1301568 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305784 2305784 0 0.0
.bss 180832 180832 0 0.0
.data 5568 5568 0 0.0
.text 1268384 1268384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053960 2053960 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016560 1016560 0 0.0
p6 all-clusters-app default (read/write) 2411464 2411464 0 0.0
.bss 117756 117756 0 0.0
.data 2584 2584 0 0.0
.text 1369728 1369728 0 0.0
light-app default (read/write) 2334944 2334944 0 0.0
.bss 105516 105516 0 0.0
.data 2408 2408 0 0.0
.text 1293208 1293208 0 0.0
lock-app default (read/write) 2300496 2300496 0 0.0
.bss 105260 105260 0 0.0
.data 2360 2360 0 0.0
.text 1258760 1258760 0 0.0
qpg lighting-app qpg6105+debug (read only) 569848 569848 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89672 89672 0 0.0
.data 1060 1060 0 0.0
.text 564528 564528 0 0.0
lock-app qpg6105+debug (read only) 515956 515956 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89144 89144 0 0.0
.data 992 992 0 0.0
.text 510636 510636 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845562 845562 0 0.0
bss 87472 87472 0 0.0
noinit 37160 37160 0 0.0
text 590686 590686 0 0.0

@msandstedt msandstedt deleted the bugfix/14267 branch March 31, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

m5stack stuck in infinite reset loop
2 participants