-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite reset loop in m5stack init #14268
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some new OTA code is causing the m5stack all-clusters-app to reset during init, which results in an infinite reset loop. This fixes it. Fixes project-chip#14267
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13 and
hawk248
January 25, 2022 21:55
pullapprove
bot
requested review from
tecimovic,
lzgrablic02,
turon,
mrjerryjohns,
vijs,
mspang,
vivien-apple,
pan-apple,
wbschiller,
robszewczyk,
woody-apple,
sagar-apple,
xylophone21,
saurabhst,
yufengwangca and
selissia
January 25, 2022 21:55
saurabhst
approved these changes
Jan 25, 2022
Apparently fixed with #13849. |
PR #14268: Size comparison from de95567 to 046730d Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some new OTA code is causing the m5stack all-clusters-app to reset
during init, which results in an infinite reset loop.
Change overview
Root cause is that InitServer is dispatched to the work queue. But InitOTARequestor is executed immediately after this is dispatched, and yet depends upon InitServer. The solution is to call InitOTARequestor from InitServer.
Fixes #14267
Testing
Manually tested. m5stack all-clusters-app no longer exhibits the infinite reset loop with the fix.