Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Use ConfigurationManager as the source of truth for Basic cluster attributes #13849

Merged
merged 2 commits into from
Jan 25, 2022
Merged

[OTA] Use ConfigurationManager as the source of truth for Basic cluster attributes #13849

merged 2 commits into from
Jan 25, 2022

Conversation

carol-apple
Copy link
Contributor

Problem

OTA is setting the Basic cluster attribute upon NotifyUpdateApplied being called. This value should only be updated by the platform when it is running the new image. OTA (common SDK code) should be a consumer of this value to determine the current software version that is running. It should never modify it.

Change overview

  • Remove any calls to update Basic cluster SoftwareVersion attribute
  • Use the ConfigurationManager as the source of truth to read Basic cluster attributes (Basic cluster uses ConfigurationManager as the source of truth as well)

Testing

Manual testing of Linux provider/requestor case

@restyled-io restyled-io bot mentioned this pull request Jan 24, 2022
Closed
@carol-apple carol-apple force-pushed the ota_requestor_config_mgr_basic_attributes branch from 7d1ad12 to 28225fe Compare January 24, 2022 19:47
@github-actions
Copy link

github-actions bot commented Jan 24, 2022 •
edited
Loading

PR #13849: Size comparison from 4449e65 to 28225fe

Decreases (16 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, qpg, telink)
platform target config section 4449e65 28225fe change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573654 573646 -8 -0.0
.app_xip_area 478940 478932 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 822768 822752 -16 -0.0
.text 822760 822744 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 919270 919266 -4 -0.0
.flash.text 919270 919266 -4 -0.0
k32w light k32w061+release (read/write) 659884 659724 -160 -0.0
.text 575880 575720 -160 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348784 2348720 -64 -0.0
.text 1311360 1311296 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942087 942071 -16 -0.0
text 637108 637100 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 927599 927583 -16 -0.0
text 632504 632496 -8 -0.0
nrf52840dongle_nrf52840 (read/write) 992763 992747 -16 -0.0
text 669308 669300 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851942 851926 -16 -0.0
text 554028 554020 -8 -0.0
lock-app nrf52840dk_nrf52840 text 612660 612652 -8 -0.0
nrf5340dk_nrf5340_cpuapp text 529616 529608 -8 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 914303 914287 -16 -0.0
text 615200 615192 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909519 909503 -16 -0.0
text 611224 611216 -8 -0.0
qpg lighting-app qpg6105+debug (read only) 567016 566872 -144 -0.0
.text 561696 561552 -144 -0.0
lock-app qpg6105+debug (read only) 515580 515564 -16 -0.0
.text 510260 510244 -16 -0.0
telink lighting-app tlsr9518adk80d text 588172 588168 -4 -0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4449e65 28225fe change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573654 573646 -8 -0.0
.app_xip_area 478940 478932 -8 -0.0
.bss 77452 77452 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835372 835372 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835364 835364 0 0.0
BRD4161A+rpc (read only) 822768 822752 -16 -0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822760 822744 -16 -0.0
window-app BRD4161A (read only) 806260 806260 0 0.0
(read/write) 125560 125560 0 0.0
.bss 123704 123704 0 0.0
.data 1856 1856 0 0.0
.text 806252 806252 0 0.0
esp32 all-clusters-app c3devkit (read only) 919270 919266 -4 -0.0
(read/write) 1376754 1376754 0 0.0
.dram0.bss 67384 67384 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 175992 175992 0 0.0
.flash.text 919270 919266 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967595 967595 0 0.0
(read/write) 443160 443160 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205144 205144 0 0.0
.flash.text 962211 962211 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659884 659724 -160 -0.0
.bss 76336 76336 0 0.0
.data 1868 1868 0 0.0
.text 575880 575720 -160 -0.0
lock k32w061+release (read/write) 660736 660736 0 0.0
.bss 76600 76600 0 0.0
.data 1892 1892 0 0.0
.text 576444 576444 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8537828 8537828 0 0.0
(read/write) 390977 390977 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261000 261000 0 0.0
.dynamic 560 560 0 0.0
.got 69048 69048 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 436892 436892 0 0.0
.text 7262020 7262020 0 0.0
thermostat-no-ble arm64 (read only) 2050332 2050332 0 0.0
(read/write) 144881 144881 0 0.0
.bss 64017 64017 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72952 72952 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129900 129900 0 0.0
.text 1706160 1706160 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348784 2348720 -64 -0.0
.bss 186092 186092 0 0.0
.data 5304 5304 0 0.0
.text 1311360 1311296 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333904 2333904 0 0.0
.bss 180696 180696 0 0.0
.data 5584 5584 0 0.0
.text 1296504 1296504 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304408 2304408 0 0.0
.bss 179704 179704 0 0.0
.data 5568 5568 0 0.0
.text 1267008 1267008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942087 942071 -16 -0.0
bss 118776 118776 0 0.0
rodata 108620 108620 0 0.0
text 637108 637100 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 927599 927583 -16 -0.0
bss 115820 115820 0 0.0
rodata 101068 101068 0 0.0
text 632504 632496 -8 -0.0
nrf52840dongle_nrf52840 (read/write) 992763 992747 -16 -0.0
bss 121620 121620 0 0.0
rodata 113372 113372 0 0.0
text 669308 669300 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851942 851926 -16 -0.0
bss 115564 115564 0 0.0
rodata 101792 101792 0 0.0
text 554028 554020 -8 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 911599 911599 0 0.0
bss 117948 117948 0 0.0
rodata 103612 103612 0 0.0
text 612660 612652 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821666 821666 0 0.0
bss 114764 114764 0 0.0
rodata 96836 96836 0 0.0
text 529616 529608 -8 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914303 914287 -16 -0.0
bss 117696 117696 0 0.0
rodata 103948 103948 0 0.0
text 615200 615192 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909519 909503 -16 -0.0
bss 117720 117720 0 0.0
rodata 103100 103100 0 0.0
text 611224 611216 -8 -0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533644 533644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451320 451320 0 0.0
p6 all-clusters-app default (read/write) 2407416 2407416 0 0.0
.bss 114436 114436 0 0.0
.data 2592 2592 0 0.0
.text 1365680 1365680 0 0.0
light-app default (read/write) 2330144 2330144 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288408 1288408 0 0.0
lock-app default (read/write) 2299496 2299496 0 0.0
.bss 104144 104144 0 0.0
.data 2360 2360 0 0.0
.text 1257760 1257760 0 0.0
qpg lighting-app qpg6105+debug (read only) 567016 566872 -144 -0.0
(read/write) 146940 146940 0 0.0
.bss 89416 89416 0 0.0
.data 1064 1064 0 0.0
.text 561696 561552 -144 -0.0
lock-app qpg6105+debug (read only) 515580 515564 -16 -0.0
(read/write) 146940 146940 0 0.0
.bss 88008 88008 0 0.0
.data 992 992 0 0.0
.text 510260 510244 -16 -0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840950 840950 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588172 588168 -4 -0.0

@carol-apple carol-apple force-pushed the ota_requestor_config_mgr_basic_attributes branch from 28225fe to b3d432f Compare January 24, 2022 23:45
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13849: Size comparison from 2926d14 to b3d432f

Decreases (6 builds for cyw30739, efr32, esp32, k32w, mbed, telink)
platform target config section 2926d14 b3d432f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573674 573666 -8 -0.0
.app_xip_area 478960 478952 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 822792 822776 -16 -0.0
.text 822784 822768 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 919194 919190 -4 -0.0
.flash.text 919194 919190 -4 -0.0
k32w light k32w061+release (read/write) 660840 660680 -160 -0.0
.text 575948 575788 -160 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348720 2348656 -64 -0.0
.text 1311296 1311232 -64 -0.0
telink lighting-app tlsr9518adk80d text 588172 588168 -4 -0.0
Full report (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 2926d14 b3d432f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573674 573666 -8 -0.0
.app_xip_area 478960 478952 -8 -0.0
.bss 77452 77452 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835388 835388 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835380 835380 0 0.0
BRD4161A+rpc (read only) 822792 822776 -16 -0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822784 822768 -16 -0.0
window-app BRD4161A (read only) 806300 806300 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806292 806292 0 0.0
esp32 all-clusters-app c3devkit (read only) 919194 919190 -4 -0.0
(read/write) 1376754 1376754 0 0.0
.dram0.bss 67384 67384 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 175992 175992 0 0.0
.flash.text 919194 919190 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967535 967535 0 0.0
(read/write) 443168 443168 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205152 205152 0 0.0
.flash.text 962151 962151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660840 660680 -160 -0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575948 575788 -160 -0.0
lock k32w061+release (read/write) 661772 661772 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576592 576592 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8537844 8537844 0 0.0
(read/write) 390977 390977 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261000 261000 0 0.0
.dynamic 560 560 0 0.0
.got 69048 69048 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 436908 436908 0 0.0
.text 7262020 7262020 0 0.0
thermostat-no-ble arm64 (read only) 2050300 2050300 0 0.0
(read/write) 145953 145953 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706000 1706000 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348720 2348656 -64 -0.0
.bss 186092 186092 0 0.0
.data 5304 5304 0 0.0
.text 1311296 1311232 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333928 2333928 0 0.0
.bss 180696 180696 0 0.0
.data 5584 5584 0 0.0
.text 1296528 1296528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304560 2304560 0 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267160 1267160 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
p6 all-clusters-app default (read/write) 2407352 2407352 0 0.0
.bss 114436 114436 0 0.0
.data 2592 2592 0 0.0
.text 1365616 1365616 0 0.0
light-app default (read/write) 2330168 2330168 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288432 1288432 0 0.0
lock-app default (read/write) 2299640 2299640 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257904 1257904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840970 840970 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588172 588168 -4 -0.0

@carol-apple carol-apple force-pushed the ota_requestor_config_mgr_basic_attributes branch from b3d432f to 5956b0e Compare January 25, 2022 04:24
@restyled-io restyled-io bot mentioned this pull request Jan 25, 2022
Closed
@carol-apple carol-apple force-pushed the ota_requestor_config_mgr_basic_attributes branch 3 times, most recently from 7869e4a to 133bf81 Compare January 25, 2022 04:30
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13849: Size comparison from 8541f47 to 133bf81

Decreases (7 builds for cyw30739, efr32, esp32, k32w, qpg, telink)
platform target config section 8541f47 133bf81 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573706 -8 -0.0
.app_xip_area 479016 479008 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 822864 822848 -16 -0.0
.text 822856 822840 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 919202 919198 -4 -0.0
.flash.text 919202 919198 -4 -0.0
k32w light k32w061+release (read/write) 660864 660720 -144 -0.0
.text 575972 575828 -144 -0.0
qpg lighting-app qpg6105+debug (read only) 567092 566932 -160 -0.0
.text 561772 561612 -160 -0.0
lock-app qpg6105+debug (read only) 515752 515736 -16 -0.0
.text 510432 510416 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841054 -8 -0.0
text 588184 588180 -4 -0.0
Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 8541f47 133bf81 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573706 -8 -0.0
.app_xip_area 479016 479008 -8 -0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835484 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835476 0 0.0
BRD4161A+rpc (read only) 822864 822848 -16 -0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 822840 -16 -0.0
window-app BRD4161A (read only) 806324 806324 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806316 0 0.0
esp32 all-clusters-app c3devkit (read only) 919202 919198 -4 -0.0
(read/write) 1376810 1376810 0 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176064 176064 0 0.0
.flash.text 919202 919198 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967535 967535 0 0.0
(read/write) 443240 443240 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205224 205224 0 0.0
.flash.text 962151 962151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660864 660720 -144 -0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575972 575828 -144 -0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576616 576616 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8544308 8544308 0 0.0
(read/write) 390961 390961 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260976 260976 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 437484 437484 0 0.0
.text 7267860 7267860 0 0.0
thermostat-no-ble arm64 (read only) 2050428 2050428 0 0.0
(read/write) 145969 145969 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73160 73160 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706080 1706080 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348784 2348784 0 0.0
.bss 186084 186084 0 0.0
.data 5296 5296 0 0.0
.text 1311360 1311360 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333984 2333984 0 0.0
.bss 180688 180688 0 0.0
.data 5576 5576 0 0.0
.text 1296584 1296584 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304568 2304568 0 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267168 1267168 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
p6 all-clusters-app default (read/write) 2407448 2407448 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1365712 1365712 0 0.0
light-app default (read/write) 2330256 2330256 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288520 1288520 0 0.0
lock-app default (read/write) 2299664 2299664 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257928 1257928 0 0.0
qpg lighting-app qpg6105+debug (read only) 567092 566932 -160 -0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561772 561612 -160 -0.0
lock-app qpg6105+debug (read only) 515752 515736 -16 -0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510432 510416 -16 -0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841054 -8 -0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588184 588180 -4 -0.0

@carol-apple carol-apple force-pushed the ota_requestor_config_mgr_basic_attributes branch from 133bf81 to 9189144 Compare January 25, 2022 05:52
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13849: Size comparison from 270081a to 9189144

Decreases (15 builds for cyw30739, efr32, esp32, k32w, nrfconnect, qpg, telink)
platform target config section 270081a 9189144 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573706 -8 -0.0
.app_xip_area 479016 479008 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 822864 822848 -16 -0.0
.text 822856 822840 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 919202 919198 -4 -0.0
.flash.text 919202 919198 -4 -0.0
k32w light k32w061+release (read/write) 660864 660720 -144 -0.0
.text 575972 575828 -144 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942175 942159 -16 -0.0
text 637104 637096 -8 -0.0
nrf52840dk_nrf52840+rpc text 632500 632492 -8 -0.0
nrf52840dongle_nrf52840 (read/write) 992855 992839 -16 -0.0
text 669304 669296 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852034 852018 -16 -0.0
text 554024 554016 -8 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912683 912667 -16 -0.0
text 612680 612672 -8 -0.0
nrf5340dk_nrf5340_cpuapp text 529636 529628 -8 -0.0
pump-app nrf52840dk_nrf52840 text 615148 615140 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910523 910507 -16 -0.0
text 611176 611168 -8 -0.0
qpg lighting-app qpg6105+debug (read only) 567092 566932 -160 -0.0
.text 561772 561612 -160 -0.0
lock-app qpg6105+debug (read only) 515752 515736 -16 -0.0
.text 510432 510416 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841054 -8 -0.0
text 588184 588180 -4 -0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 270081a 9189144 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573706 -8 -0.0
.app_xip_area 479016 479008 -8 -0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835484 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835476 0 0.0
BRD4161A+rpc (read only) 822864 822848 -16 -0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 822840 -16 -0.0
window-app BRD4161A (read only) 806324 806324 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806316 0 0.0
esp32 all-clusters-app c3devkit (read only) 919202 919198 -4 -0.0
(read/write) 1376810 1376810 0 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176064 176064 0 0.0
.flash.text 919202 919198 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967535 967535 0 0.0
(read/write) 443240 443240 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205224 205224 0 0.0
.flash.text 962151 962151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660864 660720 -144 -0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575972 575828 -144 -0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576616 576616 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348784 2348784 0 0.0
.bss 186084 186084 0 0.0
.data 5296 5296 0 0.0
.text 1311360 1311360 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333984 2333984 0 0.0
.bss 180688 180688 0 0.0
.data 5576 5576 0 0.0
.text 1296584 1296584 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304568 2304568 0 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267168 1267168 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942175 942159 -16 -0.0
bss 118776 118776 0 0.0
rodata 108708 108708 0 0.0
text 637104 637096 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 927675 927675 0 0.0
bss 115820 115820 0 0.0
rodata 101160 101160 0 0.0
text 632500 632492 -8 -0.0
nrf52840dongle_nrf52840 (read/write) 992855 992839 -16 -0.0
bss 121616 121616 0 0.0
rodata 113464 113464 0 0.0
text 669304 669296 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852034 852018 -16 -0.0
bss 115564 115564 0 0.0
rodata 101884 101884 0 0.0
text 554024 554016 -8 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912683 912667 -16 -0.0
bss 118828 118828 0 0.0
rodata 103768 103768 0 0.0
text 612680 612672 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822702 822702 0 0.0
bss 115648 115648 0 0.0
rodata 96992 96992 0 0.0
text 529636 529628 -8 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915339 915339 0 0.0
bss 118576 118576 0 0.0
rodata 104152 104152 0 0.0
text 615148 615140 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910523 910507 -16 -0.0
bss 118600 118600 0 0.0
rodata 103256 103256 0 0.0
text 611176 611168 -8 -0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533644 533644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451320 451320 0 0.0
p6 all-clusters-app default (read/write) 2407448 2407448 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1365712 1365712 0 0.0
light-app default (read/write) 2330256 2330256 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288520 1288520 0 0.0
lock-app default (read/write) 2299664 2299664 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257928 1257928 0 0.0
qpg lighting-app qpg6105+debug (read only) 567092 566932 -160 -0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561772 561612 -160 -0.0
lock-app qpg6105+debug (read only) 515752 515736 -16 -0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510432 510416 -16 -0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841054 -8 -0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588184 588180 -4 -0.0

@carol-apple
[OTA] Use ConfigurationManager as the source of truth for Basic clust…
86c583b 
…er attributes
@carol-apple
Address code review comments
262d93c 
- Use DeviceLayer namespace directly
- Return actual error from failing ConfigurationManager calls
- Refactor reading of country code from OTA
@carol-apple carol-apple force-pushed the ota_requestor_config_mgr_basic_attributes branch from 9189144 to 262d93c Compare January 25, 2022 17:54
@carol-apple carol-apple mentioned this pull request Jan 25, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13849: Size comparison from c428576 to 262d93c

Decreases (15 builds for cyw30739, efr32, esp32, k32w, nrfconnect, qpg, telink)
platform target config section c428576 262d93c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 572022 572014 -8 -0.0
.app_xip_area 477084 477076 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 819820 819804 -16 -0.0
.text 819812 819796 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 916812 916808 -4 -0.0
.flash.text 916812 916808 -4 -0.0
k32w light k32w061+release (read/write) 660264 660104 -160 -0.0
.text 575140 574980 -160 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 635196 635188 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 926287 926271 -16 -0.0
text 630588 630580 -8 -0.0
nrf52840dongle_nrf52840 text 667392 667384 -8 -0.0
nrf5340dk_nrf5340_cpuapp text 552116 552108 -8 -0.0
lock-app nrf52840dk_nrf52840 text 610772 610764 -8 -0.0
nrf5340dk_nrf5340_cpuapp text 527728 527720 -8 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 913951 913935 -16 -0.0
text 613236 613228 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 text 609268 609260 -8 -0.0
qpg lighting-app qpg6105+debug (read only) 565336 565176 -160 -0.0
.text 560016 559856 -160 -0.0
lock-app qpg6105+debug (read only) 514092 514076 -16 -0.0
.text 508772 508756 -16 -0.0
telink lighting-app tlsr9518adk80d text 585882 585878 -4 -0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c428576 262d93c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 572022 572014 -8 -0.0
.app_xip_area 477084 477076 -8 -0.0
.bss 77684 77684 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 832416 832416 0 0.0
(read/write) 127216 127216 0 0.0
.bss 125312 125312 0 0.0
.data 1900 1900 0 0.0
.text 832408 832408 0 0.0
BRD4161A+rpc (read only) 819820 819804 -16 -0.0
(read/write) 143872 143872 0 0.0
.bss 141872 141872 0 0.0
.data 2000 2000 0 0.0
.text 819812 819796 -16 -0.0
window-app BRD4161A (read only) 808608 808608 0 0.0
(read/write) 125872 125872 0 0.0
.bss 124016 124016 0 0.0
.data 1856 1856 0 0.0
.text 808600 808600 0 0.0
esp32 all-clusters-app c3devkit (read only) 916812 916808 -4 -0.0
(read/write) 1317778 1317778 0 0.0
.dram0.bss 70696 70696 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 179440 179440 0 0.0
.flash.text 916812 916808 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965803 965803 0 0.0
(read/write) 450360 450360 0 0.0
.dram0.bss 75440 75440 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208760 208760 0 0.0
.flash.text 960419 960419 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660264 660104 -160 -0.0
.bss 77456 77456 0 0.0
.data 1868 1868 0 0.0
.text 575140 574980 -160 -0.0
lock k32w061+release (read/write) 661156 661156 0 0.0
.bss 77720 77720 0 0.0
.data 1892 1892 0 0.0
.text 575744 575744 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8697804 8697804 0 0.0
(read/write) 390817 390817 0 0.0
.bss 56017 56017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260888 260888 0 0.0
.dynamic 560 560 0 0.0
.got 69040 69040 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532532 532532 0 0.0
.text 7326532 7326532 0 0.0
thermostat-no-ble arm64 (read only) 2042268 2042268 0 0.0
(read/write) 146625 146625 0 0.0
.bss 65649 65649 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73072 73072 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130556 130556 0 0.0
.text 1697408 1697408 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349712 2349712 0 0.0
.bss 189404 189404 0 0.0
.data 5296 5296 0 0.0
.text 1312312 1312312 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331968 2331968 0 0.0
.bss 180920 180920 0 0.0
.data 5576 5576 0 0.0
.text 1294568 1294568 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302552 2302552 0 0.0
.bss 180824 180824 0 0.0
.data 5568 5568 0 0.0
.text 1265152 1265152 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940803 940803 0 0.0
bss 119012 119012 0 0.0
rodata 109000 109000 0 0.0
text 635196 635188 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 926287 926271 -16 -0.0
bss 116056 116056 0 0.0
rodata 101452 101452 0 0.0
text 630588 630580 -8 -0.0
nrf52840dongle_nrf52840 (read/write) 991447 991447 0 0.0
bss 121852 121852 0 0.0
rodata 113752 113752 0 0.0
text 667392 667384 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850630 850630 0 0.0
bss 115796 115796 0 0.0
rodata 102176 102176 0 0.0
text 552116 552108 -8 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911275 0 0.0
bss 119064 119064 0 0.0
rodata 104056 104056 0 0.0
text 610772 610764 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821346 821346 0 0.0
bss 115880 115880 0 0.0
rodata 97284 97284 0 0.0
text 527728 527720 -8 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913951 913935 -16 -0.0
bss 118808 118808 0 0.0
rodata 104444 104444 0 0.0
text 613236 613228 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909119 909119 0 0.0
bss 118836 118836 0 0.0
rodata 103548 103548 0 0.0
text 609268 609260 -8 -0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451316 451316 0 0.0
p6 all-clusters-app default (read/write) 2407784 2407784 0 0.0
.bss 117748 117748 0 0.0
.data 2584 2584 0 0.0
.text 1366048 1366048 0 0.0
light-app default (read/write) 2327520 2327520 0 0.0
.bss 105512 105512 0 0.0
.data 2408 2408 0 0.0
.text 1285784 1285784 0 0.0
lock-app default (read/write) 2296960 2296960 0 0.0
.bss 105256 105256 0 0.0
.data 2360 2360 0 0.0
.text 1255224 1255224 0 0.0
qpg lighting-app qpg6105+debug (read only) 565336 565176 -160 -0.0
(read/write) 146936 146936 0 0.0
.bss 89656 89656 0 0.0
.data 1060 1060 0 0.0
.text 560016 559856 -160 -0.0
lock-app qpg6105+debug (read only) 514092 514076 -16 -0.0
(read/write) 146940 146940 0 0.0
.bss 89128 89128 0 0.0
.data 992 992 0 0.0
.text 508772 508756 -16 -0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839294 839294 0 0.0
bss 87460 87460 0 0.0
noinit 37160 37160 0 0.0
text 585882 585878 -4 -0.0

@carol-apple carol-apple merged commit 75b9637 into project-chip:master Jan 25, 2022
This was referenced Jan 25, 2022
Closed
Closed
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@carol-apple @selissia
[OTA] Use ConfigurationManager as the source of truth for Basic clust…
b5a2afa 
…er attributes (project-chip#13849)

* [OTA] Use ConfigurationManager as the source of truth for Basic cluster attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@holbrookt holbrookt holbrookt left review comments

@selissia selissia selissia approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carol-apple @tcarmelveilleux @holbrookt @selissia @bzbarsky-apple