Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build breakage from OTA Requestor event support #13804

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix build breakage from OTA Requestor event support #13804

merged 1 commit into from
Jan 21, 2022

Conversation

msandstedt
Copy link
Contributor

Problem

This commit failed to update Ota.cpp, resulting in a breakage for
builds that include the OTA shell:

commit d0d6dda
Date: Thu Jan 20 05:37:01 2022 -0800

[OTA] Implement event support for OTA Requestor cluster (#13727)

Change overview

This commit fixes the issue by adding the now necessary version argument
to the NotifyImageHandler shell command.

Fixes #13803

Testing

Local m5stack all-clusters-app build now succeeds.

@boring-cyborg boring-cyborg bot added the lib label Jan 21, 2022
@msandstedt
Fix build breakage from OTA Requestor event support
544816f 
This commit failed to update Ota.cpp, resulting in a breakage for
builds that include the OTA shell:

commit d0d6dda
Date:   Thu Jan 20 05:37:01 2022 -0800

    [OTA] Implement event support for OTA Requestor cluster (project-chip#13727)

This commit fixes the issue by adding the now necessary version argument
to the NotifyImageHandler shell command.

Fixes project-chip#13803
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13804: Size comparison from 2f1301b to 544816f

Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2f1301b 544816f change % change
efr32 lighting-app BRD4161A (read only) 833660 833660 0 0.0
(read/write) 127216 127216 0 0.0
.bss 125320 125320 0 0.0
.data 1896 1896 0 0.0
.text 833652 833652 0 0.0
BRD4161A+rpc (read only) 821056 821056 0 0.0
(read/write) 143880 143880 0 0.0
.bss 141880 141880 0 0.0
.data 1996 1996 0 0.0
.text 821048 821048 0 0.0
window-app BRD4161A (read only) 804212 804212 0 0.0
(read/write) 125792 125792 0 0.0
.bss 123944 123944 0 0.0
.data 1848 1848 0 0.0
.text 804204 804204 0 0.0
k32w light k32w061+release (read/write) 658940 658940 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574692 574692 0 0.0
lock k32w061+release (read/write) 659720 659720 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575212 575212 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8428364 8428364 0 0.0
(read/write) 388769 388769 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 259416 259416 0 0.0
.dynamic 560 560 0 0.0
.got 68424 68424 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 434308 434308 0 0.0
.text 7160308 7160308 0 0.0
thermostat-no-ble arm64 (read only) 2043340 2043340 0 0.0
(read/write) 145441 145441 0 0.0
.bss 64769 64769 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699152 1699152 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350160 2350160 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312736 1312736 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332728 2332728 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1295328 1295328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303080 2303080 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265680 1265680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941303 941303 0 0.0
bss 119020 119020 0 0.0
rodata 108508 108508 0 0.0
text 636188 636188 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926783 926783 0 0.0
bss 116064 116064 0 0.0
rodata 100956 100956 0 0.0
text 631580 631580 0 0.0
nrf52840dongle_nrf52840 (read/write) 991979 991979 0 0.0
bss 121864 121864 0 0.0
rodata 113260 113260 0 0.0
text 668384 668384 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851130 851130 0 0.0
bss 115808 115808 0 0.0
rodata 101684 101684 0 0.0
text 553108 553108 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910647 910647 0 0.0
bss 118176 118176 0 0.0
rodata 103476 103476 0 0.0
text 611624 611624 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820714 820714 0 0.0
bss 114992 114992 0 0.0
rodata 96700 96700 0 0.0
text 528584 528584 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913519 913519 0 0.0
bss 117940 117940 0 0.0
rodata 103836 103836 0 0.0
text 614276 614276 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908583 908583 0 0.0
bss 117964 117964 0 0.0
rodata 102948 102948 0 0.0
text 610200 610200 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533884 533884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711294 711294 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451564 451564 0 0.0
p6 all-clusters-app default (read/write) 2407768 2407768 0 0.0
.bss 117772 117772 0 0.0
.data 2584 2584 0 0.0
.text 1366032 1366032 0 0.0
light-app default (read/write) 2328728 2328728 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286992 1286992 0 0.0
lock-app default (read/write) 2297736 2297736 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1256000 1256000 0 0.0
qpg lighting-app qpg6105+debug (read only) 565856 565856 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89664 89664 0 0.0
.data 1060 1060 0 0.0
.text 560536 560536 0 0.0
lock-app qpg6105+debug (read only) 514344 514344 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88232 88232 0 0.0
.data 984 984 0 0.0
.text 509024 509024 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839906 839906 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586988 586988 0 0.0

@msandstedt msandstedt added the hotfix urgent fix needed, can bypass review label Jan 21, 2022
@bzbarsky-apple bzbarsky-apple merged commit 1e80d68 into project-chip:master Jan 21, 2022
@msandstedt msandstedt deleted the bugfix/13803 branch January 21, 2022 04:37
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@msandstedt @selissia
Fix build breakage from OTA Requestor event support (project-chip#13804)
21f0a13 
This commit failed to update Ota.cpp, resulting in a breakage for
builds that include the OTA shell:

commit d0d6dda
Date:   Thu Jan 20 05:37:01 2022 -0800

    [OTA] Implement event support for OTA Requestor cluster (project-chip#13727)

This commit fixes the issue by adding the now necessary version argument
to the NotifyImageHandler shell command.

Fixes project-chip#13803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carol-apple carol-apple carol-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

event support for OTA Requestor breaks m5stack build
3 participants
@msandstedt @carol-apple @bzbarsky-apple