-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Implement event support for OTA Requestor cluster #13727
Merged
andy31415
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_events
Jan 20, 2022
Merged
[OTA] Implement event support for OTA Requestor cluster #13727
andy31415
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_events
Jan 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns and
msandstedt
January 19, 2022 20:25
carol-apple
commented
Jan 19, 2022
carol-apple
commented
Jan 19, 2022
carol-apple
commented
Jan 19, 2022
carol-apple
commented
Jan 19, 2022
bzbarsky-apple
approved these changes
Jan 19, 2022
PR #13727: Size comparison from ffd25d8 to f258fa9 Increases above 0.2%:
Increases (3 builds for k32w, linux, qpg)
Full report (16 builds for k32w, linux, mbed, p6, qpg, telink)
|
carol-apple
force-pushed
the
ota_requestor_events
branch
from
January 19, 2022 22:03
f258fa9
to
73bb4ba
Compare
PR #13727: Size comparison from bb9ac68 to 73bb4ba Increases above 0.2%:
Increases (2 builds for k32w, qpg)
Full report (9 builds for k32w, p6, qpg, telink)
|
carol-apple
force-pushed
the
ota_requestor_events
branch
from
January 19, 2022 22:50
73bb4ba
to
45f25c1
Compare
PR #13727: Size comparison from 7f766c6 to 45f25c1 Increases above 0.2%:
Increases (3 builds for k32w, linux, qpg)
Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
selissia
approved these changes
Jan 20, 2022
carol-apple
force-pushed
the
ota_requestor_events
branch
from
January 20, 2022 04:15
45f25c1
to
10ff6ff
Compare
yufengwangca
approved these changes
Jan 20, 2022
PR #13727: Size comparison from 3853608 to 10ff6ff Increases above 0.2%:
Increases (3 builds for k32w, linux, qpg)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 20, 2022
carol-apple
force-pushed
the
ota_requestor_events
branch
from
January 20, 2022 05:53
10ff6ff
to
27aba99
Compare
PR #13727: Size comparison from 3853608 to 27aba99 Increases above 0.2%:
Increases (3 builds for k32w, linux, qpg)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
added a commit
to msandstedt/connectedhomeip
that referenced
this pull request
Jan 21, 2022
This commit failed to update Ota.cpp, resulting in a breakage for builds that include the OTA shell: commit d0d6dda Date: Thu Jan 20 05:37:01 2022 -0800 [OTA] Implement event support for OTA Requestor cluster (project-chip#13727) This commit fixes the issue by adding the now necessary version argument to the NotifyImageHandler shell command. Fixes project-chip#13803
msandstedt
added a commit
to msandstedt/connectedhomeip
that referenced
this pull request
Jan 21, 2022
This commit failed to update Ota.cpp, resulting in a breakage for builds that include the OTA shell: commit d0d6dda Date: Thu Jan 20 05:37:01 2022 -0800 [OTA] Implement event support for OTA Requestor cluster (project-chip#13727) This commit fixes the issue by adding the now necessary version argument to the NotifyImageHandler shell command. Fixes project-chip#13803
bzbarsky-apple
pushed a commit
that referenced
this pull request
Jan 21, 2022
This commit failed to update Ota.cpp, resulting in a breakage for builds that include the OTA shell: commit d0d6dda Date: Thu Jan 20 05:37:01 2022 -0800 [OTA] Implement event support for OTA Requestor cluster (#13727) This commit fixes the issue by adding the now necessary version argument to the NotifyImageHandler shell command. Fixes #13803
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
This commit failed to update Ota.cpp, resulting in a breakage for builds that include the OTA shell: commit d0d6dda Date: Thu Jan 20 05:37:01 2022 -0800 [OTA] Implement event support for OTA Requestor cluster (project-chip#13727) This commit fixes the issue by adding the now necessary version argument to the NotifyImageHandler shell command. Fixes project-chip#13803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Events are not logged for OTA Requestor cluster
Fixes: #13006
Change overview
-- StateTransition
-- VersionApplied
-- DownloadError
Testing
Manual testing for Linux provider/requestor and verify that messages like the following are seen: