Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manufacturer code from attribute-storage APIs. #13546

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Remove manufacturer code from attribute-storage APIs. #13546

merged 1 commit into from
Jan 14, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Matter does not use a separate manufacturer code.

Problem

Useless argument in function signatures.

Change overview

Remove the argument.

Testing

Code compiles, no behavior changes.

@bzbarsky-apple
Remove manufacturer code from attribute-storage APIs.
b2f1c63 
Matter does not use a separate manufacturer code.
@boring-cyborg boring-cyborg bot added the app label Jan 13, 2022
@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

PR #13546: Size comparison from 2d6d1a3 to b2f1c63

Decreases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2d6d1a3 b2f1c63 change % change
efr32 lighting-app BRD4161A (read only) 831392 831312 -80 -0.0
.text 831384 831304 -80 -0.0
BRD4161A+rpc (read only) 818772 818708 -64 -0.0
.text 818764 818700 -64 -0.0
window-app BRD4161A (read only) 805272 805224 -48 -0.0
.text 805264 805216 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 908520 908472 -48 -0.0
.flash.text 908520 908472 -48 -0.0
m5stack (read only) 957299 957243 -56 -0.0
.flash.text 951915 951859 -56 -0.0
k32w light k32w061+release (read/write) 657752 657704 -48 -0.0
.text 572964 572916 -48 -0.0
lock k32w061+release (read/write) 661532 661468 -64 -0.0
.text 576428 576364 -64 -0.0
linux chip-tool-ipv6only arm64 (read only) 8018628 8018532 -96 -0.0
.text 6812964 6812868 -96 -0.0
thermostat-no-ble arm64 (read only) 2040924 2040748 -176 -0.0
.text 1696464 1696288 -176 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2346416 2346352 -64 -0.0
.text 1308992 1308928 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304464 2304400 -64 -0.0
.text 1267064 1267000 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940303 940223 -80 -0.0
text 634620 634548 -72 -0.0
nrf52840dk_nrf52840+rpc (read/write) 925739 925675 -64 -0.0
text 629972 629904 -68 -0.0
nrf52840dongle_nrf52840 (read/write) 990983 990903 -80 -0.0
text 666816 666748 -68 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850130 850050 -80 -0.0
text 551536 551468 -68 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912543 912463 -80 -0.0
text 612612 612540 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822614 822534 -80 -0.0
text 529568 529500 -68 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 913855 913791 -64 -0.0
text 613872 613800 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910655 910607 -48 -0.0
text 611368 611316 -52 -0.0
p6 all-clusters-app default (read/write) 2400616 2400520 -96 -0.0
.text 1358880 1358784 -96 -0.0
light-app default (read/write) 2326152 2326088 -64 -0.0
.text 1284416 1284352 -64 -0.0
lock-app default (read/write) 2298384 2298320 -64 -0.0
.text 1256648 1256584 -64 -0.0
qpg lighting-app qpg6105+debug (read only) 534972 534908 -64 -0.0
.text 529652 529588 -64 -0.0
lock-app qpg6105+debug (read only) 506896 506816 -80 -0.0
.text 501576 501496 -80 -0.0
telink lighting-app tlsr9518adk80d (read/write) 836950 836918 -32 -0.0
text 584320 584282 -38 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2d6d1a3 b2f1c63 change % change
efr32 lighting-app BRD4161A (read only) 831392 831312 -80 -0.0
(read/write) 127612 127612 0 0.0
.bss 125732 125732 0 0.0
.data 1880 1880 0 0.0
.text 831384 831304 -80 -0.0
BRD4161A+rpc (read only) 818772 818708 -64 -0.0
(read/write) 144272 144272 0 0.0
.bss 142292 142292 0 0.0
.data 1980 1980 0 0.0
.text 818764 818700 -64 -0.0
window-app BRD4161A (read only) 805272 805224 -48 -0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805264 805216 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 908520 908472 -48 -0.0
(read/write) 1316498 1316498 0 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178216 178216 0 0.0
.flash.text 908520 908472 -48 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 957299 957243 -56 -0.0
(read/write) 448664 448664 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207496 207496 0 0.0
.flash.text 951915 951859 -56 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657752 657704 -48 -0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 572964 572916 -48 -0.0
lock k32w061+release (read/write) 661532 661468 -64 -0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576428 576364 -64 -0.0
linux chip-tool-ipv6only arm64 (read only) 8018628 8018532 -96 -0.0
(read/write) 370241 370241 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245760 245760 0 0.0
.dynamic 560 560 0 0.0
.got 64472 64472 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 417772 417772 0 0.0
.text 6812964 6812868 -96 -0.0
thermostat-no-ble arm64 (read only) 2040924 2040748 -176 -0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129868 129868 0 0.0
.text 1696464 1696288 -176 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346416 2346352 -64 -0.0
.bss 189204 189204 0 0.0
.data 5320 5320 0 0.0
.text 1308992 1308928 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331240 2331240 0 0.0
.bss 180728 180728 0 0.0
.data 5552 5552 0 0.0
.text 1293840 1293840 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304464 2304400 -64 -0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267064 1267000 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054456 2054456 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017056 1017056 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940303 940223 -80 -0.0
bss 119596 119596 0 0.0
rodata 108508 108508 0 0.0
text 634620 634548 -72 -0.0
nrf52840dk_nrf52840+rpc (read/write) 925739 925675 -64 -0.0
bss 116640 116640 0 0.0
rodata 100960 100960 0 0.0
text 629972 629904 -68 -0.0
nrf52840dongle_nrf52840 (read/write) 990983 990903 -80 -0.0
bss 122440 122440 0 0.0
rodata 113264 113264 0 0.0
text 666816 666748 -68 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850130 850050 -80 -0.0
bss 116384 116384 0 0.0
rodata 101684 101684 0 0.0
text 551536 551468 -68 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912543 912463 -80 -0.0
bss 118784 118784 0 0.0
rodata 103780 103780 0 0.0
text 612612 612540 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822614 822534 -80 -0.0
bss 115600 115600 0 0.0
rodata 97008 97008 0 0.0
text 529568 529500 -68 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913855 913791 -64 -0.0
bss 118544 118544 0 0.0
rodata 103996 103996 0 0.0
text 613872 613800 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910655 910607 -48 -0.0
bss 118572 118572 0 0.0
rodata 103252 103252 0 0.0
text 611368 611316 -52 -0.0
shell nrf52840dk_nrf52840 (read/write) 798643 798643 0 0.0
bss 109776 109776 0 0.0
rodata 78376 78376 0 0.0
text 533988 533988 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711462 711462 0 0.0
bss 107664 107664 0 0.0
rodata 72680 72680 0 0.0
text 451668 451668 0 0.0
p6 all-clusters-app default (read/write) 2400616 2400520 -96 -0.0
.bss 117484 117484 0 0.0
.data 2592 2592 0 0.0
.text 1358880 1358784 -96 -0.0
light-app default (read/write) 2326152 2326088 -64 -0.0
.bss 106040 106040 0 0.0
.data 2384 2384 0 0.0
.text 1284416 1284352 -64 -0.0
lock-app default (read/write) 2298384 2298320 -64 -0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256648 1256584 -64 -0.0
qpg lighting-app qpg6105+debug (read only) 534972 534908 -64 -0.0
(read/write) 146940 146940 0 0.0
.bss 89336 89336 0 0.0
.data 1008 1008 0 0.0
.text 529652 529588 -64 -0.0
lock-app qpg6105+debug (read only) 506896 506816 -80 -0.0
(read/write) 146936 146936 0 0.0
.bss 88472 88472 0 0.0
.data 956 956 0 0.0
.text 501576 501496 -80 -0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836950 836918 -32 -0.0
bss 87288 87288 0 0.0
noinit 37160 37160 0 0.0
text 584320 584282 -38 -0.0

@bzbarsky-apple bzbarsky-apple merged commit 9c016d4 into project-chip:master Jan 14, 2022
@bzbarsky-apple bzbarsky-apple deleted the remove-mfg-code-attr-storage branch January 14, 2022 00:16
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Remove manufacturer code from attribute-storage APIs. (project-chip#1…
825c4d4 
…3546)

Matter does not use a separate manufacturer code.
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@bzbarsky-apple @step0035
Remove manufacturer code from attribute-storage APIs. (project-chip#1…
f9fb09c 
…3546)

Matter does not use a separate manufacturer code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @andy31415 @saurabhst @woody-apple @jmartinez-silabs