-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve management of OTA requestor apps in darwin tests. (#28674)
* Improve management of OTA requestor apps in darwin tests. Instead of relying on the apps to be started externally, just start them directly from the test itself. This removes the proliferation of test app instances at runtime, except during this test, and makes it easier to run other tests without paying the cost of all the compilation/setup for this one. The change in MTROTAProviderDelegateBridge.mm is fixing a bug that was uncovered by the changed tests: if we shut down our last controller, that incorrectly cleared out mDelegateNotificationQueue on the BdxOTASender, and that state is not restored until factory restart. Since the queue is tied to the factory, not controllers, nulling it out does not make sense here. * Address review comment.
- Loading branch information
1 parent
2451c26
commit 1256648
Showing
4 changed files
with
281 additions
and
156 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.