-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement localization configuration server support #13415
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/configuration
Jan 11, 2022
Merged
Implement localization configuration server support #13415
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/configuration
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02 and
mlepage-google
January 10, 2022 16:35
pullapprove
bot
requested review from
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
January 10, 2022 16:35
PR #13415: Size comparison from 08753ba to 933e5d4 Increases above 0.2%:
Increases (10 builds for k32w, linux, p6, qpg, telink)
Decreases (2 builds for p6, qpg)
Full report (11 builds for k32w, linux, p6, qpg, telink)
|
andy31415
approved these changes
Jan 10, 2022
PR #13415: Size comparison from 8281d59 to 7c28eef Increases above 0.2%:
Increases (18 builds for k32w, linux, nrfconnect, p6, qpg, telink)
Decreases (4 builds for nrfconnect, p6, qpg)
Full report (21 builds for k32w, linux, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
approved these changes
Jan 10, 2022
src/app/clusters/localization-configuration-server/localization-configuration-server.cpp
Outdated
Show resolved
Hide resolved
PR #13415: Size comparison from 5053f20 to 514ebd1 Increases above 0.2%:
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (4 builds for mbed, nrfconnect, qpg)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
saurabhst
approved these changes
Jan 10, 2022
PR #13415: Size comparison from 19f61eb to 1a92306 Increases above 0.2%:
Increases (13 builds for efr32, k32w, linux, p6, qpg, telink)
Decreases (1 build for qpg)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #13415: Size comparison from 19f61eb to b29de32 Increases above 0.2%:
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for qpg)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
* Implement localization configuration server support * Run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Implement localization configuration server support
Testing
How was this tested? (at least one bullet point required)