Skip to content

Commit

Permalink
Remove <signal.h> include from Linux/PlatformManagerImpl.cpp (#20324)
Browse files Browse the repository at this point in the history
Pull request #19064 moved all signal code out of the Linux platform
manager into examples/all-clusters-app/linux/main-common.cpp, which
is a much more appropriate location.

However, Linux/PlatformManagerImpl.cpp and other code is still
needlessly including signal.h.  Remove this include to reduce temptation
for adding code back to the platform managers that could modify the
signal mask.
  • Loading branch information
msandstedt authored and pull[bot] committed Jun 27, 2023
1 parent 33155fb commit 1359680
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion src/inet/tests/TestInetCommonPosix.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
#include <vector>

#include <inttypes.h>
#include <signal.h>
#include <stdint.h>
#include <string.h>
#include <sys/types.h>
Expand Down
1 change: 0 additions & 1 deletion src/lib/shell/streamer_mbed.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

#include <lib/shell/streamer.h>

#include <signal.h>
#include <stdio.h>
#include <stdlib.h>

Expand Down
1 change: 0 additions & 1 deletion src/lib/shell/streamer_stdio.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

#include <lib/shell/streamer.h>

#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <termios.h>
Expand Down
1 change: 0 additions & 1 deletion src/platform/Linux/PlatformManagerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
#include <linux/rtnetlink.h>
#include <net/if.h>
#include <netinet/in.h>
#include <signal.h>
#include <unistd.h>

#if __GLIBC__ == 2 && __GLIBC_MINOR__ < 30
Expand Down
1 change: 0 additions & 1 deletion src/platform/webos/PlatformManagerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
#include <linux/rtnetlink.h>
#include <net/if.h>
#include <netinet/in.h>
#include <signal.h>
#include <unistd.h>

#if __GLIBC__ == 2 && __GLIBC_MINOR__ < 30
Expand Down

0 comments on commit 1359680

Please sign in to comment.