-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SoftwareFault and GeneralFault events are missed randomly #19064
Fix SoftwareFault and GeneralFault events are missed randomly #19064
Conversation
PR #19064: Size comparison from d2a5192 to 42e5861 Increases above 0.2%:
Increases (8 builds for cc13x2_26x2, efr32, esp32, mbed)
Decreases (28 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/software-diagnostics-server/software-diagnostics-server.h
Outdated
Show resolved
Hide resolved
PR #19064: Size comparison from d2a5192 to 7540acf Increases above 0.2%:
Increases (7 builds for cc13x2_26x2, efr32, mbed)
Decreases (26 builds for cc13x2_26x2, cyw30739, efr32, k32w, mbed, nrfconnect, p6, telink)
Full report (26 builds for cc13x2_26x2, cyw30739, efr32, k32w, mbed, nrfconnect, p6, telink)
|
PR #19064: Size comparison from dd636ad to 9758bae Increases above 0.2%:
Increases (9 builds for cc13x2_26x2, efr32, esp32, linux, mbed)
Decreases (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19064: Size comparison from dd636ad to 85c86de Increases above 0.2%:
Increases (10 builds for cc13x2_26x2, efr32, esp32, linux, mbed)
Decreases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19064: Size comparison from 55ab764 to b48bced Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, efr32, esp32, linux, mbed)
Decreases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #19064: Size comparison from 9a8b4af to 3ac139d Increases (5 builds for efr32, linux, mbed)
Decreases (32 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19064: Size comparison from 8cc291d to 456e013 Increases above 0.2%:
Increases (12 builds for cc13x2_26x2, efr32, esp32, linux, mbed)
Decreases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19064: Size comparison from caacbde to e254c02 Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, efr32, esp32, linux, mbed)
Decreases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…t-chip#19064) * Fix SoftwareFault and GeneralFault events are missed randomly * Remove GeneralDiagnosticsDelegate and implement event API in cluster server * Refactor new APIs from Server into cluster server * Address review comments * Update examples/all-clusters-app/linux/main-common.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Rename Server to GeneralDiagnosticsServer to avoid namespace conflict Co-authored-by: Boris Zbarsky <[email protected]>
Pull request project-chip#19064 moved all signal code out of the Linux platform manager into examples/all-clusters-app/linux/main-common.cpp, which is a much more appropriate location. However, Linux/PlatformManagerImpl.cpp is still including signal.h. Remove this include to reduce tempatation for adding code back to the platform manager that could modify the signal mask.
Pull request project-chip#19064 moved all signal code out of the Linux platform manager into examples/all-clusters-app/linux/main-common.cpp, which is a much more appropriate location. However, Linux/PlatformManagerImpl.cpp is still including signal.h. Remove this include to reduce temptation for adding code back to the platform manager that could modify the signal mask.
Pull request project-chip#19064 moved all signal code out of the Linux platform manager into examples/all-clusters-app/linux/main-common.cpp, which is a much more appropriate location. However, Linux/PlatformManagerImpl.cpp and other code is still needlessly including signal.h. Remove this include to reduce temptation for adding code back to the platform managers that could modify the signal mask.
Pull request #19064 moved all signal code out of the Linux platform manager into examples/all-clusters-app/linux/main-common.cpp, which is a much more appropriate location. However, Linux/PlatformManagerImpl.cpp and other code is still needlessly including signal.h. Remove this include to reduce temptation for adding code back to the platform managers that could modify the signal mask.
Problem
What is being fixed? Examples:
Fixes #19242
Change overview
Move SoftwareFault and GeneralFault signal handler from platform layer to app layer
Please note, this PR only contains the changes for general and software diagnostic clusters.
Testing
How was this tested? (at least one bullet point required)
yufengwang@yufengwang:~/connectedhomeip/out/debug/standalone$ ./chip-all-clusters-app