Fix Master build failure #13302
Merged
Fix Master build failure #13302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
rcasallas-silabs
approved these changes
Jan 3, 2022
electrocucaracha
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
/lgtm
This case is interesting the CI didn't report a failure in its PR but the error was raised in master branch
selissia
approved these changes
Jan 3, 2022
That's because it was a merge conflict, no? @electrocucaracha |
It could be or at least it's a possibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#13071 seems to have broken a couple of CI job
Change overview
Fix the build failure
Testing
EFR32 platform now compiles