Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new method to validate NOCSR Attestation Signature #13071

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

vijs
Copy link
Collaborator

@vijs vijs commented Dec 16, 2021

Problem

Change overview

  • Added a new method to validate NOCSR Attestation Signature.
  • Added respective Unit Test.
  • Updated DeviceController with new call to validate NOCSR Attestation Signature before generating a NOC Chain.

Testing

  • Matter Unit Tests
  • chip-tool vs lighting-app - Tested Commissioning Flow

@github-actions
Copy link

github-actions bot commented Dec 16, 2021

PR #13071: Size comparison from 161cd14 to dcdf2fb

Increases (1 build for linux)
platform target config section 161cd14 dcdf2fb change % change
linux chip-tool-ipv6only arm64 (read only) 6929380 6930308 928 0.0
(read/write) 323377 323409 32 0.0
.data.rel.ro 208016 208040 24 0.0
.text 5864180 5865028 848 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 161cd14 dcdf2fb change % change
efr32 lighting-app BRD4161A (read only) 835684 835684 0 0.0
(read/write) 127324 127324 0 0.0
.bss 125448 125448 0 0.0
.data 1876 1876 0 0.0
.text 835676 835676 0 0.0
BRD4161A+rpc (read only) 823304 823304 0 0.0
(read/write) 143992 143992 0 0.0
.bss 142016 142016 0 0.0
.data 1976 1976 0 0.0
.text 823296 823296 0 0.0
window-app BRD4161A (read only) 809060 809060 0 0.0
(read/write) 126264 126264 0 0.0
.bss 124432 124432 0 0.0
.data 1832 1832 0 0.0
.text 809052 809052 0 0.0
esp32 all-clusters-app c3devkit (read only) 876694 876694 0 0.0
(read/write) 1312954 1312954 0 0.0
.dram0.bss 69776 69776 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 175920 175920 0 0.0
.flash.text 876694 876694 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962575 962575 0 0.0
(read/write) 453688 453688 0 0.0
.dram0.bss 76096 76096 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 211748 211748 0 0.0
.flash.text 957191 957191 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 686396 686396 0 0.0
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600664 600664 0 0.0
lock-app k32w061+debug (read/write) 633960 633960 0 0.0
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550124 550124 0 0.0
shell k32w061+debug (read/write) 639688 639688 0 0.0
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553364 553364 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6929380 6930308 928 0.0
(read/write) 323377 323409 32 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208016 208040 24 0.0
.dynamic 560 560 0 0.0
.got 55992 55992 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 378324 378324 0 0.0
.text 5864180 5865028 848 0.0
thermostat-no-ble arm64 (read only) 1993972 1993972 0 0.0
(read/write) 143937 143937 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654592 1654592 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334696 2334696 0 0.0
.bss 189044 189044 0 0.0
.data 5264 5264 0 0.0
.text 1297272 1297272 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329280 2329280 0 0.0
.bss 180872 180872 0 0.0
.data 5544 5544 0 0.0
.text 1291880 1291880 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302376 2302376 0 0.0
.bss 179920 179920 0 0.0
.data 5536 5536 0 0.0
.text 1264976 1264976 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936531 936531 0 0.0
bss 118376 118376 0 0.0
rodata 107952 107952 0 0.0
text 632628 632628 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 918483 918483 0 0.0
bss 114708 114708 0 0.0
rodata 99864 99864 0 0.0
text 625764 625764 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860246 860246 0 0.0
bss 116660 116660 0 0.0
rodata 102876 102876 0 0.0
text 560064 560064 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908627 908627 0 0.0
bss 117564 117564 0 0.0
rodata 103256 103256 0 0.0
text 610444 610444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832574 832574 0 0.0
bss 115876 115876 0 0.0
rodata 98220 98220 0 0.0
text 537920 537920 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913507 913507 0 0.0
bss 117472 117472 0 0.0
rodata 104600 104600 0 0.0
text 613996 613996 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906739 906739 0 0.0
bss 117352 117352 0 0.0
rodata 102728 102728 0 0.0
text 609192 609192 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796959 796959 0 0.0
bss 109472 109472 0 0.0
rodata 78032 78032 0 0.0
text 532996 532996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709594 709594 0 0.0
bss 107360 107360 0 0.0
rodata 72336 72336 0 0.0
text 450484 450484 0 0.0
p6 all-clusters-app default (read/write) 2390552 2390552 0 0.0
.bss 117236 117236 0 0.0
.data 2544 2544 0 0.0
.text 1348816 1348816 0 0.0
light-app default (read/write) 2329936 2329936 0 0.0
.bss 106128 106128 0 0.0
.data 2384 2384 0 0.0
.text 1288200 1288200 0 0.0
lock-app default (read/write) 2302144 2302144 0 0.0
.bss 105008 105008 0 0.0
.data 2336 2336 0 0.0
.text 1260408 1260408 0 0.0
qpg lighting-app qpg6105+debug (read only) 532752 532752 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86800 86800 0 0.0
.data 1004 1004 0 0.0
.text 527432 527432 0 0.0
lock-app qpg6105+debug (read only) 504424 504424 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499104 499104 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831078 831078 0 0.0
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579390 579390 0 0.0

@msandstedt msandstedt self-requested a review December 16, 2021 17:17
Copy link
Contributor

@msandstedt msandstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example does not verify that the nonce sent in the CSR request matches the nonce that came back.

@github-actions
Copy link

github-actions bot commented Dec 21, 2021

PR #13071: Size comparison from afec776 to adfdfc7

Increases (1 build for linux)
platform target config section afec776 adfdfc7 change % change
linux chip-tool-ipv6only arm64 (read only) 7007292 7009372 2080 0.0
(read/write) 326353 326385 32 0.0
.data.rel.ro 210200 210224 24 0.0
.rodata 384244 384260 16 0.0
.text 5929556 5931540 1984 0.0
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section afec776 adfdfc7 change % change
efr32 lighting-app BRD4161A (read only) 830568 830568 0 0.0
(read/write) 127384 127384 0 0.0
.bss 125504 125504 0 0.0
.data 1876 1876 0 0.0
.text 830560 830560 0 0.0
BRD4161A+rpc (read only) 818196 818196 0 0.0
(read/write) 144048 144048 0 0.0
.bss 142072 142072 0 0.0
.data 1976 1976 0 0.0
.text 818188 818188 0 0.0
window-app BRD4161A (read only) 804016 804016 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124488 124488 0 0.0
.data 1832 1832 0 0.0
.text 804008 804008 0 0.0
k32w light k32w061+release (read/write) 648764 648764 0 0.0
.bss 76512 76512 0 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633472 633472 0 0.0
.bss 76224 76224 0 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7007292 7009372 2080 0.0
(read/write) 326353 326385 32 0.0
.bss 54641 54641 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 210200 210224 24 0.0
.dynamic 560 560 0 0.0
.got 56720 56720 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384244 384260 16 0.0
.text 5929556 5931540 1984 0.0
thermostat-no-ble arm64 (read only) 2018564 2018564 0 0.0
(read/write) 144561 144561 0 0.0
.bss 64417 64417 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72432 72432 0 0.0
.dynamic 560 560 0 0.0
.got 3896 3896 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128932 128932 0 0.0
.text 1676768 1676768 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2342856 2342856 0 0.0
.bss 188660 188660 0 0.0
.data 5280 5280 0 0.0
.text 1305432 1305432 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330656 2330656 0 0.0
.bss 180936 180936 0 0.0
.data 5552 5552 0 0.0
.text 1293256 1293256 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303752 2303752 0 0.0
.bss 179984 179984 0 0.0
.data 5544 5544 0 0.0
.text 1266352 1266352 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053840 2053840 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016440 1016440 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 935967 0 0.0
bss 118428 118428 0 0.0
rodata 108124 108124 0 0.0
text 631864 631864 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922367 922367 0 0.0
bss 115472 115472 0 0.0
rodata 101540 101540 0 0.0
text 627176 627176 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859730 859730 0 0.0
bss 116712 116712 0 0.0
rodata 103048 103048 0 0.0
text 559308 559308 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908111 908111 0 0.0
bss 117616 117616 0 0.0
rodata 103428 103428 0 0.0
text 609692 609692 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832042 832042 0 0.0
bss 115928 115928 0 0.0
rodata 98392 98392 0 0.0
text 537172 537172 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909375 909375 0 0.0
bss 117376 117376 0 0.0
rodata 103644 103644 0 0.0
text 610928 610928 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 906191 0 0.0
bss 117404 117404 0 0.0
rodata 102900 102900 0 0.0
text 608440 608440 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2395264 2395264 0 0.0
.bss 116860 116860 0 0.0
.data 2552 2552 0 0.0
.text 1353528 1353528 0 0.0
light-app default (read/write) 2325208 2325208 0 0.0
.bss 106184 106184 0 0.0
.data 2384 2384 0 0.0
.text 1283472 1283472 0 0.0
lock-app default (read/write) 2297424 2297424 0 0.0
.bss 105064 105064 0 0.0
.data 2336 2336 0 0.0
.text 1255688 1255688 0 0.0
qpg lighting-app qpg6105+debug (read only) 532232 532232 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86840 86840 0 0.0
.data 1004 1004 0 0.0
.text 526912 526912 0 0.0
lock-app qpg6105+debug (read only) 503912 503912 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85976 85976 0 0.0
.data 952 952 0 0.0
.text 498592 498592 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 832258 0 0.0
bss 87088 87088 0 0.0
noinit 37160 37160 0 0.0
text 580366 580366 0 0.0

@vijs vijs force-pushed the feature/nocsr_verification branch from adfdfc7 to f231447 Compare December 22, 2021 00:37
@boring-cyborg boring-cyborg bot added the darwin label Dec 22, 2021
@github-actions
Copy link

github-actions bot commented Dec 22, 2021

PR #13071: Size comparison from afec776 to f231447

Increases (2 builds for esp32, linux)
platform target config section afec776 f231447 change % change
esp32 all-clusters-app m5stack (read only) 946503 946507 4 0.0
.flash.text 941119 941123 4 0.0
linux chip-tool-ipv6only arm64 (read only) 7007292 7009372 2080 0.0
(read/write) 326353 326385 32 0.0
.data.rel.ro 210200 210224 24 0.0
.rodata 384244 384260 16 0.0
.text 5929556 5931540 1984 0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section afec776 f231447 change % change
efr32 lighting-app BRD4161A (read only) 830568 830568 0 0.0
(read/write) 127384 127384 0 0.0
.bss 125504 125504 0 0.0
.data 1876 1876 0 0.0
.text 830560 830560 0 0.0
BRD4161A+rpc (read only) 818196 818196 0 0.0
(read/write) 144048 144048 0 0.0
.bss 142072 142072 0 0.0
.data 1976 1976 0 0.0
.text 818188 818188 0 0.0
window-app BRD4161A (read only) 804016 804016 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124488 124488 0 0.0
.data 1832 1832 0 0.0
.text 804008 804008 0 0.0
esp32 all-clusters-app c3devkit (read only) 885820 885820 0 0.0
(read/write) 1313018 1313018 0 0.0
.dram0.bss 69384 69384 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 176352 176352 0 0.0
.flash.text 885820 885820 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 946503 946507 4 0.0
(read/write) 442112 442112 0 0.0
.dram0.bss 73888 73888 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 203160 203160 0 0.0
.flash.text 941119 941123 4 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648764 648764 0 0.0
.bss 76512 76512 0 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633472 633472 0 0.0
.bss 76224 76224 0 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7007292 7009372 2080 0.0
(read/write) 326353 326385 32 0.0
.bss 54641 54641 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 210200 210224 24 0.0
.dynamic 560 560 0 0.0
.got 56720 56720 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384244 384260 16 0.0
.text 5929556 5931540 1984 0.0
thermostat-no-ble arm64 (read only) 2018564 2018564 0 0.0
(read/write) 144561 144561 0 0.0
.bss 64417 64417 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72432 72432 0 0.0
.dynamic 560 560 0 0.0
.got 3896 3896 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128932 128932 0 0.0
.text 1676768 1676768 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2342856 2342856 0 0.0
.bss 188660 188660 0 0.0
.data 5280 5280 0 0.0
.text 1305432 1305432 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330656 2330656 0 0.0
.bss 180936 180936 0 0.0
.data 5552 5552 0 0.0
.text 1293256 1293256 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303752 2303752 0 0.0
.bss 179984 179984 0 0.0
.data 5544 5544 0 0.0
.text 1266352 1266352 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053840 2053840 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016440 1016440 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 935967 0 0.0
bss 118428 118428 0 0.0
rodata 108124 108124 0 0.0
text 631864 631864 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922367 922367 0 0.0
bss 115472 115472 0 0.0
rodata 101540 101540 0 0.0
text 627176 627176 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859730 859730 0 0.0
bss 116712 116712 0 0.0
rodata 103048 103048 0 0.0
text 559308 559308 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908111 908111 0 0.0
bss 117616 117616 0 0.0
rodata 103428 103428 0 0.0
text 609692 609692 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832042 832042 0 0.0
bss 115928 115928 0 0.0
rodata 98392 98392 0 0.0
text 537172 537172 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909375 909375 0 0.0
bss 117376 117376 0 0.0
rodata 103644 103644 0 0.0
text 610928 610928 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 906191 0 0.0
bss 117404 117404 0 0.0
rodata 102900 102900 0 0.0
text 608440 608440 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2395264 2395264 0 0.0
.bss 116860 116860 0 0.0
.data 2552 2552 0 0.0
.text 1353528 1353528 0 0.0
light-app default (read/write) 2325208 2325208 0 0.0
.bss 106184 106184 0 0.0
.data 2384 2384 0 0.0
.text 1283472 1283472 0 0.0
lock-app default (read/write) 2297424 2297424 0 0.0
.bss 105064 105064 0 0.0
.data 2336 2336 0 0.0
.text 1255688 1255688 0 0.0
qpg lighting-app qpg6105+debug (read only) 532232 532232 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86840 86840 0 0.0
.data 1004 1004 0 0.0
.text 526912 526912 0 0.0
lock-app qpg6105+debug (read only) 503912 503912 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85976 85976 0 0.0
.data 952 952 0 0.0
.text 498592 498592 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 832258 0 0.0
bss 87088 87088 0 0.0
noinit 37160 37160 0 0.0
text 580366 580366 0 0.0

@msandstedt msandstedt self-requested a review December 23, 2021 15:17
@stale
Copy link

stale bot commented Dec 30, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added stale Stale issue or PR and removed stale Stale issue or PR labels Dec 30, 2021
@vijs vijs merged commit a0442e2 into project-chip:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants