Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 13122 #13123

Merged
merged 7 commits into from
Dec 23, 2021
Merged

fix issue 13122 #13123

merged 7 commits into from
Dec 23, 2021

Conversation

chrisdecenzo
Copy link
Contributor

@chrisdecenzo chrisdecenzo commented Dec 17, 2021 •
edited
Loading

Problem

Change overview

  • Always print rotating ID when included in dns-sd response
  • Fix regression caused by recent refactoring
  • Enable rotating ID by default in tv-casting-app
  • Enable rotating ID by default in tv-app to ensure it is caught by CI

Testing

  • Testing using chip-tool discover commissionables and tv-casting-app

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request Dec 17, 2021
Merged
@github-actions
Copy link

PR #13123: Size comparison from d24eff1 to eb2508c

Full report (5 builds for mbed)
platform target config section d24eff1 eb2508c change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337920 2337920 0 0.0
.bss 188580 188580 0 0.0
.data 5264 5264 0 0.0
.text 1300496 1300496 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330760 2330760 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293360 1293360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303792 2303792 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266392 1266392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0

@boring-cyborg boring-cyborg bot added the app label Dec 17, 2021
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13123: Size comparison from d24eff1 to 3ecff71

Full report (19 builds for efr32, esp32, k32w, mbed, p6, qpg, telink)
platform target config section d24eff1 3ecff71 change % change
efr32 lighting-app BRD4161A (read only) 830584 830584 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830576 830576 0 0.0
BRD4161A+rpc (read only) 818212 818212 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818204 818204 0 0.0
window-app BRD4161A (read only) 803960 803960 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803952 803952 0 0.0
esp32 all-clusters-app c3devkit (read only) 881266 881266 0 0.0
(read/write) 1312402 1312402 0 0.0
.dram0.bss 69296 69296 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175832 175832 0 0.0
.flash.text 881266 881266 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 941919 941919 0 0.0
(read/write) 441516 441516 0 0.0
.dram0.bss 73792 73792 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202660 202660 0 0.0
.flash.text 936535 936535 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648852 648852 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564660 564660 0 0.0
lock k32w061+release (read/write) 633568 633568 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549700 549700 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337920 2337920 0 0.0
.bss 188580 188580 0 0.0
.data 5264 5264 0 0.0
.text 1300496 1300496 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330760 2330760 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293360 1293360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303792 2303792 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266392 1266392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
p6 all-clusters-app default (read/write) 2390040 2390040 0 0.0
.bss 116780 116780 0 0.0
.data 2544 2544 0 0.0
.text 1348304 1348304 0 0.0
light-app default (read/write) 2325120 2325120 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283384 1283384 0 0.0
lock-app default (read/write) 2297328 2297328 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255592 1255592 0 0.0
qpg lighting-app qpg6105+debug (read only) 532352 532352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527032 527032 0 0.0
lock-app qpg6105+debug (read only) 504016 504016 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498696 498696 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@chrisdecenzo chrisdecenzo requested a review from hnnajh December 17, 2021 21:42
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13123: Size comparison from d24eff1 to 72e68b3

Full report (8 builds for esp32, mbed, telink)
platform target config section d24eff1 72e68b3 change % change
esp32 all-clusters-app c3devkit (read only) 881266 881266 0 0.0
(read/write) 1312402 1312402 0 0.0
.dram0.bss 69296 69296 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175832 175832 0 0.0
.flash.text 881266 881266 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 941919 941919 0 0.0
(read/write) 441516 441516 0 0.0
.dram0.bss 73792 73792 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202660 202660 0 0.0
.flash.text 936535 936535 0 0.0
.iram0.text 122671 122671 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337920 2337920 0 0.0
.bss 188580 188580 0 0.0
.data 5264 5264 0 0.0
.text 1300496 1300496 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330760 2330760 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293360 1293360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303792 2303792 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266392 1266392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 18, 2021 •
edited
Loading

PR #13123: Size comparison from d6aac1f to 3b89f4f

Full report (8 builds for esp32, mbed, telink)
platform target config section d6aac1f7 3b89f4f change % change
esp32 all-clusters-app c3devkit (read only) 881266 881266 0 0.0
(read/write) 1312402 1312402 0 0.0
.dram0.bss 69296 69296 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175832 175832 0 0.0
.flash.text 881266 881266 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 941919 941919 0 0.0
(read/write) 441516 441516 0 0.0
.dram0.bss 73792 73792 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202660 202660 0 0.0
.flash.text 936535 936535 0 0.0
.iram0.text 122671 122671 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337920 2337920 0 0.0
.bss 188580 188580 0 0.0
.data 5264 5264 0 0.0
.text 1300496 1300496 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330760 2330760 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293360 1293360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303792 2303792 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266392 1266392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@github-actions
Copy link

PR #13123: Size comparison from fcbcac2 to e09c71c

Full report (1 build for telink)
platform target config section fcbcac2 e09c71c change % change
telink lighting-app tlsr9518adk80d (read/write) 831682 831682 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580162 580162 0 0.0

@mrjerryjohns mrjerryjohns merged commit 090dfa3 into master Dec 23, 2021
@mrjerryjohns mrjerryjohns deleted the bug-13122 branch December 23, 2021 00:41
@dhrishi dhrishi mentioned this pull request Dec 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnnajh hnnajh hnnajh approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@sharadb-amazon sharadb-amazon sharadb-amazon approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@cecille cecille Awaiting requested review from cecille

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with Rotating ID testing
8 participants
@chrisdecenzo @CLAassistant @bzbarsky-apple @mrjerryjohns @sharadb-amazon @vivien-apple @hnnajh @decenzo