Remove now-unused old-style subscribe/report functionality. #13041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt and
pan-apple
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #13041: Size comparison from 8f15eea to e61f251 Increases (6 builds for mbed, p6)
Decreases (17 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
Specific things being removed: 1) The "reporting" commands in chip-tool. Subscribing to an attribute and receiving reports (which is what these commands used to do) can be done via "chip-tool clusterName report attributeName" with the appropriate arguments. This method supports all types, unlike the "reporting" commands. 2) The generated CHIPClusters code for setting up subscriptions and getting reports. This has no consumers (even the chip-tool code being removed in item 1 does not use it). 3) The reporting bits in DeviceProxy and callbacks manager, which are unused after items 1 and 2 are removed, along with the tests for that functionality. 4) The ReadClient::Callback implementation in DeviceControllerInteractionModelDelegate, which becomes unused, and the CHIPConfig bits for it. 5) The im-client-callbacks bits that then become unused. 6) The Python bits that overrode the read stuff from DeviceControllerInteractionModelDelegate. Clearly unused, since it's no longer a ReadClient::Callback and it all compiles, so nothing was using that delegate to interact with ReadClients. 7) zzz_generated/controller-clusters/zap-generated/tests/CHIPClustersTest.cpp which is only there because of a bad merge. Not strictly related to this PR, but I noticed it when looking through what else becomes removable with the above removals.
bzbarsky-apple
force-pushed
the
remove-subscription-vestiges
branch
from
e61f251 to
428088c
Compare
carol-apple
approved these changes
Dec 15, 2021
|
PR #13041: Size comparison from a525e63 to 428088c Increases (6 builds for mbed, p6)
Decreases (24 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific things being removed:
The "reporting" commands in chip-tool. Subscribing to an attribute
and receiving reports (which is what these commands used to do) can be
done via "chip-tool clusterName report attributeName" with the
appropriate arguments. This method supports all types, unlike the
"reporting" commands.
The generated CHIPClusters code for setting up subscriptions and
getting reports. This has no consumers (even the chip-tool code being
removed in item 1 does not use it).
The reporting bits in DeviceProxy and callbacks manager, which are
unused after items 1 and 2 are removed, along with the tests for that
functionality.
The ReadClient::Callback implementation in
DeviceControllerInteractionModelDelegate, which becomes unused, and
the CHIPConfig bits for it.
The im-client-callbacks bits that then become unused.
The Python bits that overrode the read stuff from
DeviceControllerInteractionModelDelegate. Clearly unused, since it's
no longer a ReadClient::Callback and it all compiles, so nothing was
using that delegate to interact with ReadClients.
zzz_generated/controller-clusters/zap-generated/tests/CHIPClustersTest.cpp
which is only there because of a bad merge. Not strictly related to
this PR, but I noticed it when looking through what else becomes
removable with the above removals.
Problem
Dead code confusing things.
Change overview
See above.
Testing
Should be no behavior changes. Tree compiles.