-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove now-unused old-style subscribe/report functionality. (#13041)
Specific things being removed: 1) The "reporting" commands in chip-tool. Subscribing to an attribute and receiving reports (which is what these commands used to do) can be done via "chip-tool clusterName report attributeName" with the appropriate arguments. This method supports all types, unlike the "reporting" commands. 2) The generated CHIPClusters code for setting up subscriptions and getting reports. This has no consumers (even the chip-tool code being removed in item 1 does not use it). 3) The reporting bits in DeviceProxy and callbacks manager, which are unused after items 1 and 2 are removed, along with the tests for that functionality. 4) The ReadClient::Callback implementation in DeviceControllerInteractionModelDelegate, which becomes unused, and the CHIPConfig bits for it. 5) The im-client-callbacks bits that then become unused. 6) The Python bits that overrode the read stuff from DeviceControllerInteractionModelDelegate. Clearly unused, since it's no longer a ReadClient::Callback and it all compiles, so nothing was using that delegate to interact with ReadClients. 7) zzz_generated/controller-clusters/zap-generated/tests/CHIPClustersTest.cpp which is only there because of a bad merge. Not strictly related to this PR, but I noticed it when looking through what else becomes removable with the above removals.
- Loading branch information
1 parent
89aff25
commit c939e82
Showing
41 changed files
with
1,311 additions
and
20,414 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 0 additions & 65 deletions
65
examples/chip-tool/commands/reporting/ReportingCommand.cpp
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.