Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onboardingcodes now requires rendezvous type #12963

Merged
merged 1 commit into from
Dec 14, 2021
Merged

onboardingcodes now requires rendezvous type #12963

merged 1 commit into from
Dec 14, 2021

Conversation

CodeChronos928
Copy link
Contributor

@CodeChronos928 CodeChronos928 commented Dec 13, 2021 •
edited
Loading

Problem

What is being fixed?

  • The shell's "onboardingcodes" could only generate codes with the BLE rendezvous flag set. It was hard-coded.
  • This change allows me to generate a correct QR code for IP commissioning.

Change overview

This commit adds a required first parameter to the "onboardingcodes" command: none|softap|ble|onnetwork. The help screen was also updated.

Testing

  • Verified with the shell app on Linux (x86), and independently verified the correctness of the QR Code payloads being generated for BLE and OnNetwork.

@boring-cyborg boring-cyborg bot added the lib label Dec 13, 2021
@restyled-io restyled-io bot mentioned this pull request Dec 13, 2021
Closed
@github-actions
Copy link

PR #12963: Size comparison from 5d10320 to 08f0256

Increases (2 builds for k32w, telink)
platform target config section 5d10320 08f0256 change % change
k32w shell k32w061+debug (read/write) 625416 625600 184 0.0
.text 543392 543576 184 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812210 244 0.0
text 566724 566892 168 0.0
Full report (4 builds for k32w, telink)
platform target config section 5d10320 08f0256 change % change
k32w lock-app k32w061+debug (read/write) 620048 620048 0 0.0
.bss 72080 72080 0 0.0
.data 1856 1856 0 0.0
.text 540312 540312 0 0.0
shell k32w061+debug (read/write) 625416 625600 184 0.0
.bss 74388 74388 0 0.0
.data 1836 1836 0 0.0
.text 543392 543576 184 0.0
lighting-app k32w061+se05x+release (read/write) 670112 670112 0 0.0
.bss 73928 73928 0 0.0
.data 1896 1896 0 0.0
.text 588488 588488 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812210 244 0.0
bss 82920 82920 0 0.0
noinit 37160 37160 0 0.0
text 566724 566892 168 0.0

@github-actions
Copy link

PR #12963: Size comparison from 5d10320 to 5fcb955

Increases (1 build for telink)
platform target config section 5d10320 5fcb955 change % change
telink lighting-app tlsr9518adk80d (read/write) 811966 812210 244 0.0
text 566724 566892 168 0.0
Full report (1 build for telink)
platform target config section 5d10320 5fcb955 change % change
telink lighting-app tlsr9518adk80d (read/write) 811966 812210 244 0.0
bss 82920 82920 0 0.0
noinit 37160 37160 0 0.0
text 566724 566892 168 0.0

@CodeChronos928
onboardingcodes now requires rendezvous type
e11dfad 
The shell's "onboardingcodes" could only generate codes with the BLE
rendezvous flag set.  It was hardcoded.

This commit adds a required first parameter to the "onboardingcodes"
command: none|softap|ble|onnetwork.  The help screen was also updated.

The motivation for this change was so I could generate a correct QR code
for IP commissioning.
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #12963: Size comparison from 5d10320 to e11dfad

Increases (6 builds for esp32, k32w, mbed, nrfconnect, telink)
platform target config section 5d10320 e11dfad change % change
esp32 all-clusters-app m5stack (read only) 960783 960895 112 0.0
(read/write) 450468 450540 72 0.0
.flash.rodata 210592 210664 72 0.0
.flash.text 955399 955511 112 0.0
k32w shell k32w061+debug (read/write) 625416 625600 184 0.0
.text 543392 543576 184 0.0
mbed shell CY8CPROTO_062_4343W+release (read/write) 2053944 2054144 200 0.0
.text 1016544 1016744 200 0.0
nrfconnect shell nrf52840dk_nrf52840 (read/write) 782427 782611 184 0.0
rodata 74296 74368 72 0.1
text 523996 524104 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697674 168 0.0
rodata 68940 69012 72 0.1
text 444636 444744 108 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812210 244 0.0
text 566724 566892 168 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d10320 e11dfad change % change
efr32 lighting-app BRD4161A (read only) 815676 815676 0 0.0
(read/write) 123208 123208 0 0.0
.bss 121344 121344 0 0.0
.data 1864 1864 0 0.0
.text 815668 815668 0 0.0
BRD4161A+rpc (read only) 803292 803292 0 0.0
(read/write) 139884 139884 0 0.0
.bss 137920 137920 0 0.0
.data 1964 1964 0 0.0
.text 803284 803284 0 0.0
window-app BRD4161A (read only) 792752 792752 0 0.0
(read/write) 122160 122160 0 0.0
.bss 120328 120328 0 0.0
.data 1828 1828 0 0.0
.text 792744 792744 0 0.0
esp32 all-clusters-app c3devkit (read only) 856682 856682 0 0.0
(read/write) 1304650 1304650 0 0.0
.dram0.bss 64752 64752 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172696 172696 0 0.0
.flash.text 856682 856682 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960783 960895 112 0.0
(read/write) 450468 450540 72 0.0
.dram0.bss 74040 74040 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210592 210664 72 0.0
.flash.text 955399 955511 112 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670112 670112 0 0.0
.bss 73928 73928 0 0.0
.data 1896 1896 0 0.0
.text 588488 588488 0 0.0
lock-app k32w061+debug (read/write) 620048 620048 0 0.0
.bss 72080 72080 0 0.0
.data 1856 1856 0 0.0
.text 540312 540312 0 0.0
shell k32w061+debug (read/write) 625416 625600 184 0.0
.bss 74388 74388 0 0.0
.data 1836 1836 0 0.0
.text 543392 543576 184 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6876732 0 0.0
(read/write) 319281 319281 0 0.0
.bss 51873 51873 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208760 208760 0 0.0
.dynamic 560 560 0 0.0
.got 53720 53720 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366092 366092 0 0.0
.text 5828772 5828772 0 0.0
thermostat-no-ble arm64 (read only) 1952452 1952452 0 0.0
(read/write) 137681 137681 0 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70744 70744 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125764 125764 0 0.0
.text 1618336 1618336 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313720 2313720 0 0.0
.bss 184020 184020 0 0.0
.data 5240 5240 0 0.0
.heap 847184 847184 0 0.0
.text 1276296 1276296 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309576 2309576 0 0.0
.bss 175880 175880 0 0.0
.data 5536 5536 0 0.0
.heap 855032 855032 0 0.0
.text 1272176 1272176 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282688 2282688 0 0.0
.bss 174920 174920 0 0.0
.data 5520 5520 0 0.0
.heap 856008 856008 0 0.0
.text 1245288 1245288 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2054144 200 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016744 200 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907419 907419 0 0.0
bss 116352 116352 0 0.0
rodata 102220 102220 0 0.0
text 613272 613272 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 870479 870479 0 0.0
bss 112700 112700 0 0.0
rodata 93520 93520 0 0.0
text 588012 588012 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833422 833422 0 0.0
bss 117728 117728 0 0.0
rodata 97480 97480 0 0.0
text 543696 543696 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880083 880083 0 0.0
bss 113616 113616 0 0.0
rodata 98340 98340 0 0.0
text 592708 592708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806322 806322 0 0.0
bss 115024 115024 0 0.0
rodata 93628 93628 0 0.0
text 523224 523224 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885019 885019 0 0.0
bss 113528 113528 0 0.0
rodata 99692 99692 0 0.0
text 596312 596312 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878227 878227 0 0.0
bss 113404 113404 0 0.0
rodata 97828 97828 0 0.0
text 591508 591508 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782611 184 0.0
bss 109624 109624 0 0.0
rodata 74296 74368 72 0.1
text 523996 524104 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697674 168 0.0
bss 110604 110604 0 0.0
rodata 68940 69012 72 0.1
text 444636 444744 108 0.0
p6 all-clusters-app default (read/write) 2360712 2360712 0 0.0
.bss 112220 112220 0 0.0
.data 2528 2528 0 0.0
.heap 918592 918592 0 0.0
.text 1318976 1318976 0 0.0
light-app default (read/write) 2301288 2301288 0 0.0
.bss 101136 101136 0 0.0
.data 2368 2368 0 0.0
.heap 929840 929840 0 0.0
.text 1259552 1259552 0 0.0
lock-app default (read/write) 2277376 2277376 0 0.0
.bss 100016 100016 0 0.0
.data 2328 2328 0 0.0
.heap 931000 931000 0 0.0
.text 1235640 1235640 0 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521840 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82768 82768 0 0.0
.data 996 996 0 0.0
.text 516520 516520 0 0.0
lock-app qpg6100+debug (read only) 496204 496204 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81904 81904 0 0.0
.data 952 952 0 0.0
.text 490884 490884 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812210 244 0.0
bss 82920 82920 0 0.0
noinit 37160 37160 0 0.0
text 566724 566892 168 0.0

@andy31415 andy31415 merged commit 65347c9 into project-chip:master Dec 14, 2021
This was referenced Dec 29, 2021
Closed
Merged
@lmpprk lmpprk mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeChronos928 @andy31415 @msandstedt