Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell onboardingcodes command should print all onboardingcodes when no argument supplied #13646

Closed
lmpprk opened this issue Jan 18, 2022 · 2 comments
Labels
stale Stale issue or PR V1.X

Comments

@lmpprk
Copy link
Contributor

lmpprk commented Jan 18, 2022

Problem

PR #12963 updated the command onboardingcodes to require a rendezvous type, but with the handling logic still indicates that when no arguments supplied, the command should print all onboardingcodes

But it's not doing that now. the onboardingcodes command alone has no effect with no argument is supplied, and one would need to type onboardingcodes none to print the codes which is not very intuitive.

Proposed Solution

onboardingcodes command should print onboarding codes, or the help screen to tell user that they need to specify a rendezvous type.

@stale
Copy link

stale bot commented Jul 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 21, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

2 participants