Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh_sizes.py #12902

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Fix gh_sizes.py #12902

merged 1 commit into from
Dec 10, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

#12886 broke size report collection.

Change overview

Account for the GH_EVENT_TIMESTAMP environment variable not being python-parseable as an integer.

Testing

Manual check

Copy link
Collaborator

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm This fixes errors like this one

@andy31415 andy31415 merged commit 8808d7a into project-chip:master Dec 10, 2021
@kpschoedel kpschoedel deleted the sizes-hotfix branch December 16, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review review - pending scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants