[Size reports] Script improvements (1/3) #12886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Recent memory size investigations suggest some improvements: - Scripts use PR==0 to distinguish pull requests from master commits (push events), but it would be useful to record the associated PR along with commits. - Sometimes push events run on pull requests, and those are not currently distinguishable from master push events. - Sorting by build timestamp is inaccurate, since CI runs may finish in a different order than the commits. #### Change overview This is the first of three steps. - Use `event` rather than PR number to distinguish PR builds from master commit builds. - Record GitHub `event` and `ref` in the database representation, and add `ref` to the JSON (`event` was already present). - For master commits, use the commit timestamp rather than the build time. The second step will add the event to artifact names, so that it can be used to filter artifact downloads instead of PR==0. The third step will add the PR number from master commits, extracted from the commit message. #### Testing Manually run offline, but final confirmation requires live CI runs.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
pan-apple and
robszewczyk
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #12886: Size comparison from de0af9a to c017d3b Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 10, 2021
This was referenced Dec 10, 2021
Merged
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Dec 14, 2021
#### Problem Recent memory size investigations suggest some improvements: - Scripts use PR==0 to distinguish pull requests from master commits (push events), but it would be useful to record the associated PR along with commits. - Sometimes push events run on pull requests, and those are not currently distinguishable from master push events. - Sorting by build timestamp is inaccurate, since CI runs may finish in a different order than the commits. #### Change overview This is the third of three steps. The first step (project-chip#12886) added `event` and `ref` handling, and the second (project-chip#12947) added the `event` to artifact names. This step adds the PR number for pushes to master, extracted from the commit message. #### Testing Manually checked offline, but final confirmation requires live CI.
andy31415
pushed a commit
that referenced
this pull request
Dec 14, 2021
#### Problem Recent memory size investigations suggest some improvements: - Scripts use PR==0 to distinguish pull requests from master commits (push events), but it would be useful to record the associated PR along with commits. - Sometimes push events run on pull requests, and those are not currently distinguishable from master push events. - Sorting by build timestamp is inaccurate, since CI runs may finish in a different order than the commits. #### Change overview This is the third of three steps. The first step (#12886) added `event` and `ref` handling, and the second (#12947) added the `event` to artifact names. This step adds the PR number for pushes to master, extracted from the commit message. #### Testing Manually checked offline, but final confirmation requires live CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recent memory size investigations suggest some improvements:
(push events), but it would be useful to record the associated PR
along with commits.
currently distinguishable from master push events.
in a different order than the commits.
Change overview
This is the first of three steps.
eventrather than PR number to distinguish PR builds frommaster commit builds.
eventandrefin the database representation, andadd
refto the JSON (eventwas already present).time.
The second step will add the event to artifact names, so that it can
be used to filter artifact downloads instead of PR==0.
The third step will add the PR number from master commits, extracted
from the commit message.
Testing
Manually run offline, but final confirmation requires live CI runs.