-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement event support for Software Diagnostics cluster #12492
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/event/software
Dec 3, 2021
Merged
Implement event support for Software Diagnostics cluster #12492
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/event/software
Dec 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk and
sagar-apple
December 2, 2021 19:01
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller and
woody-apple
December 2, 2021 19:01
woody-apple
approved these changes
Dec 2, 2021
yunhanw-google
approved these changes
Dec 2, 2021
PR #12492: Size comparison from 2eb4c51 to fbbb4b3 Increases (30 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (36 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #12492: Size comparison from 803f3b8 to c612d2e Increases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Log SoftwareFault eventconnectedhomeip/src/app/clusters/software_diagnostics_server/software_diagnostics_server.cpp Lines 143 to 150 in a4745b7
This comment was generated by todo based on a
|
saurabhst
approved these changes
Dec 2, 2021
PR #12492: Size comparison from e66e2a1 to a4745b7 Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
billwatersiii
pushed a commit
to billwatersiii/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Implement event support for Software Diagnostics cluster
Testing
How was this tested? (at least one bullet point required)