Remove happy tests (#11373)

* Remove happy test references from build system and test driver

* Remove happy submodule

* Remove test that can only run when using happy

* Remove more happy usages from buiuld.gn and workflow scripts

* remove happy from gni

* Restyle fixes

* Remove one more run happy tests variable

* Enable dnssd for darwin only for now

* whitespace update to kick the build

* Restyle fixes

* undo unintended changes to third party repos

* Fix typo

* Remove more happy specific scripts

.github/workflows/unit_integration_test.yaml

@@ -40,7 +40,6 @@ jobs:
             image: connectedhomeip/chip-build:0.5.28
             volumes:
                 - "/tmp/log_output:/tmp/test_logs"
-                - "/tmp/happy_test_logs:/tmp/happy_test_logs"
             options:
                 --privileged --sysctl "net.ipv6.conf.all.disable_ipv6=0 net.ipv4.conf.all.forwarding=1 net.ipv6.conf.all.forwarding=1"
 
@@ -52,10 +51,7 @@ jobs:
             - name: Bootstrap
               timeout-minutes: 10
               run: |
-                  mkdir -p /tmp/happy_test_logs ;
                   mkdir -p /tmp/log_output ;
-                  scripts/tests/happy_tests.sh install_packages ;
-                  scripts/tests/happy_tests.sh bootstrap ;
                   scripts/build/gn_bootstrap.sh ;
             - name: Uploading bootstrap logs
               uses: actions/upload-artifact@v2
@@ -82,20 +78,13 @@ jobs:
                      *) ;;
                   esac
 
-                  scripts/build/gn_gen.sh --args="$GN_ARGS chip_enable_happy_tests=true"
+                  scripts/build/gn_gen.sh --args="$GN_ARGS"
             - name: Run Build
               timeout-minutes: 8
               run: scripts/run_in_build_env.sh "ninja -C out/$BUILD_TYPE"
             - name: Run Tests
               timeout-minutes: 15
-              run: RUN_HAPPY_TESTS=1 scripts/tests/gn_tests.sh
-            - name: Uploading Happy Test Log
-              uses: actions/upload-artifact@v2
-              if: ${{ always() }} && ${{ !env.ACT }}
-              with:
-                  name:
-                      happy_log-${{ steps.outsuffix.outputs.value }}-${{ matrix.type }}
-                  path: /tmp/happy_test_logs/
+              run: scripts/tests/gn_tests.sh
             # TODO Log Upload https://github.com/project-chip/connectedhomeip/issues/2227
             # TODO https://github.com/project-chip/connectedhomeip/issues/1512
             # - name: Run Code Coverage

.gitmodules

@@ -46,10 +46,6 @@
 	path = third_party/cirque/repo
 	url = https://github.com/openweave/cirque.git
 	branch  = master
-[submodule "happy"]
-	path = third_party/happy/repo
-	url = https://github.com/openweave/happy.git
-	branch  = master
 [submodule "nanopb"]
 	path = third_party/nanopb/repo
 	url = https://github.com/nanopb/nanopb.git

BUILD.gn

@@ -57,7 +57,6 @@ if (current_toolchain != "${dir_pw_toolchain}/default:default") {
       "$dir_pw_watch/py",
       "integrations/mobly:chip_mobly",
       "scripts:requirements",
-      "third_party/happy",
     ]
   }
 
@@ -163,15 +162,6 @@ if (current_toolchain != "${dir_pw_toolchain}/default:default") {
       ]
     }
   }
-
-  # We don't always want to run happy tests, make them a seperate group.
-  if (chip_enable_happy_tests) {
-    group("happy_tests") {
-      if (chip_link_tests) {
-        deps = [ "//src:happy_tests" ]
-      }
-    }
-  }
 } else {
   # This is the unified build. Configure various real toolchains.
   import("${chip_root}/build/chip/chip_build.gni")

build/chip/tests.gni

@@ -20,9 +20,6 @@ import("${chip_root}/src/platform/device.gni")
 declare_args() {
   # Enable building tests.
   chip_build_tests = current_os != "freertos"
-
-  # Enable happy tests.
-  chip_enable_happy_tests = false
 }
 
 declare_args() {

scripts/tests/gn_tests.sh

@@ -36,7 +36,3 @@ env
 set -x
 
 ninja -v -C "$CHIP_ROOT/out/$BUILD_TYPE" -k 0 check
-
-if [ "x$RUN_HAPPY_TESTS" == "x1" ]; then
-    ninja -v -C "$CHIP_ROOT/out/$BUILD_TYPE" -k 0 happy_tests
-fi

src/BUILD.gn

@@ -125,14 +125,6 @@ if (chip_build_tests) {
     }
   }
 
-  if (chip_enable_happy_tests) {
-    group("happy_tests") {
-      deps = [
-        "${chip_root}/src/test_driver/happy/tests/standalone/inet:inet_tests",
-      ]
-    }
-  }
-
   chip_test_group("fake_platform_tests") {
     deps = [ "${chip_root}/src/lib/dnssd/platform/tests" ]
   }

src/inet/tests/BUILD.gn

@@ -86,23 +86,3 @@ chip_test_suite("tests") {
     sources += [ "TestLwIPDNS.cpp" ]
   }
 }
-
-if (chip_enable_happy_tests) {
-  # The following binaries should be executed by happy.
-  chip_test_suite("happy_tests") {
-    output_name = "libHappyTestInetCommon"
-
-    sources = [ "TestInetLayerMulticast.cpp" ]
-
-    public_configs = [ ":tests_config" ]
-
-    public_deps = [
-      ":tests_lib",
-      "${chip_root}/src/inet",
-      "${chip_root}/src/lib/core",
-      "${nlunit_test_root}:nlunit-test",
-    ]
-
-    tests = [ "TestInetLayerMulticast" ]
-  }
-}