-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MRP parameters provided by CASE/PASE #12490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
turon
December 2, 2021 18:45
pullapprove
bot
requested review from
jmartinez-silabs,
LuDuda,
lzgrablic02,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
December 2, 2021 18:45
PR #12490: Size comparison from 541ebfc to a09516b Increases (30 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (8 builds for mbed, nrfconnect, p6)
Full report (36 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Dec 2, 2021
woody-apple
approved these changes
Dec 2, 2021
/rebase |
woody-apple
force-pushed
the
issue11507
branch
from
December 2, 2021 21:27
a09516b
to
5bcb5af
Compare
PR #12490: Size comparison from b6adaf7 to 5bcb5af Increases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (8 builds for mbed, nrfconnect, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: simple change |
woody-apple
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
The MRP parameters can be provided via
The SessionManager was already using the MRP values contained in CASE/PASE session object. The missing part was setting it to any value that might have been received via DNS-SD resolution.
This PR adds the missing initialization. Also, it adds API that CASE/PASE state machine can call to save the MRP parameters received in the session establishment protocol messages. The work for CASE/PASE message handling is being tracked in individual issues (#9654, #10019)
Testing
Tested using chip-tool and all-cluster-app. Tested commissioning flow (for PASE) and tested a few cluster commands for commissioning (for CASE).