Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Add optional MRP parameter support to PASE #9654

Closed
todo bot opened this issue Sep 13, 2021 · 3 comments · Fixed by #12638
Closed

- Add optional MRP parameter support to PASE #9654

todo bot opened this issue Sep 13, 2021 · 3 comments · Fixed by #12638
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Sep 13, 2021

// TODO - Add optional MRP parameter support to PASE
ReturnErrorOnFailure(tlvWriter.EndContainer(outerContainerType));
ReturnErrorOnFailure(tlvWriter.Finalize(&req));
// Update commissioning hash with the pbkdf2 param request that's being sent.
ReturnErrorOnFailure(mCommissioningHash.AddData(ByteSpan{ req->Start(), req->DataLength() }));
mNextExpectedMsg = MsgType::PBKDFParamResponse;
ReturnErrorOnFailure(
mExchangeCtxt->SendMessage(MsgType::PBKDFParamRequest, std::move(req), SendFlags(SendMessageFlags::kExpectResponse)));


This issue was generated by todo based on a TODO comment in 27dd893 when #9582 was merged. cc @pan-apple.
@todo todo bot added the todo label Sep 13, 2021
@todo todo bot assigned pan-apple Sep 13, 2021
@SkipAshton
Copy link

I believe this needs to be in PASE and CASE sessions not just PASE.
It should also be mandatory to include CRA/CRI for devices that do not use the default values.

@pan-apple
Copy link
Contributor

@billwatersiii FYI

@pan-apple
Copy link
Contributor

CASE related issue: #10019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants