-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable float/double typed attributes. #12439
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:enable-float-double
Dec 2, 2021
Merged
Enable float/double typed attributes. #12439
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:enable-float-double
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
December 1, 2021 19:39
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
December 1, 2021 19:39
yunhanw-google
approved these changes
Dec 1, 2021
bzbarsky-apple
force-pushed
the
enable-float-double
branch
from
December 1, 2021 21:33
b1bb525
to
79e3a9e
Compare
PR #12439: Size comparison from 2072f8e to 79e3a9e Increases above 0.2%:
Increases (28 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (35 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
enable-float-double
branch
from
December 1, 2021 23:02
79e3a9e
to
18f2b8e
Compare
PR #12439: Size comparison from 6f3b5a0 to 18f2b8e Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 2, 2021
msandstedt
reviewed
Dec 2, 2021
woody-apple
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These attributes do not work right now.
Change overview
Server support: add handling these types to the ember-compatibility-functions attr read/write code, and update our trait classes to handle these correctly (i.e. not using
numeric_limits<float>::min()
as the null value and using NaN instead).Client support: various changes to add the Float/Double callbacks to java, darwin, etc codegen.
Test changes: Improve logic around addition of "f" suffix to test values and add support for Infinity and -Infinity in the yaml bits for floats.
Testing
YAML tests added.