Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a better way to test for NaN in attribute-storage-null-handling.h #12453

Open
bzbarsky-apple opened this issue Dec 2, 2021 · 3 comments
Labels

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We have this code:

        // Trying to include math.h (to use isnan()) fails on EFR32, both when
        // included as "cmath" and when included as "math.h".  For lack of
        // isnan(), just fall back on the NaN != NaN thing.
        return value != value;

but as #12439 (comment) points out this could trap (certainly if value happens to be a signaling NaN).

Proposed Solution

Ideally, the EFR32 headers would get fixed so including "math.h" works. The compiler error we run into is on this line:

.environment/cipd/pigweed/arm-none-eabi/include/c++/10.2.1/cmath:237:  using ::fabs;

where the compiler complains it has no idea what ::fabs is.

@mspang do you know who might know about this?

@stale
Copy link

stale bot commented Sep 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 17, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Sep 20, 2022
@stale
Copy link

stale bot commented Mar 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 22, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 23, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants