-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checking for correctness of error codes to YAML tests. #12306
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:check-status-codes-yaml
Nov 29, 2021
Merged
Add checking for correctness of error codes to YAML tests. #12306
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:check-status-codes-yaml
Nov 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, uses errorWrongValue in tests where the wrong error code is returned by the SDK.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
November 27, 2021 03:28
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
wbschiller and
woody-apple
November 27, 2021 03:28
PR #12306: Size comparison from 8a2fd0d to a7f459a Increases (9 builds for efr32, esp32, linux, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
vivien-apple
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing that.
Damian-Nordic
approved these changes
Nov 29, 2021
andy31415
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, uses errorWrongValue in tests where the wrong error code is
returned by the SDK.
Problem
YAML tests don't check whether the error status is the one the spec requires, just that it's some error status.
Change overview
Add checking for the correct status value.
Testing
Tests pass, after annotating a few places where the SDK is buggy with errorWrongValue.