Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose error names to yaml code generation #12318

Closed
bzbarsky-apple opened this issue Nov 29, 2021 · 0 comments · Fixed by #12340
Closed

Expose error names to yaml code generation #12318

bzbarsky-apple opened this issue Nov 29, 2021 · 0 comments · Fixed by #12340
Assignees
@bzbarsky-apple

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

#12306 is adding a bunch of things like:

           error: 0x85 # INVALID_COMMAND

We should just be able to write:

           error: INVALID_COMMAND

instead.

Proposed Solution

Add a mapping to the test generation bits that converts symbolic names to the right error constant values in the generated code.
@bzbarsky-apple bzbarsky-apple self-assigned this Nov 29, 2021
@bzbarsky-apple bzbarsky-apple mentioned this issue Nov 29, 2021
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 29, 2021
@bzbarsky-apple
Allow using symbolic error names in YAML.
f457416 
Fixes project-chip#12318
@bzbarsky-apple bzbarsky-apple mentioned this issue Nov 29, 2021
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 29, 2021
@bzbarsky-apple
Allow using symbolic error names in YAML.
dee2976 
Fixes project-chip#12318
woody-apple pushed a commit that referenced this issue Nov 30, 2021
@bzbarsky-apple
Allow using symbolic error names in YAML. (#12340)
677d87e 
Fixes #12318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow using symbolic error names in YAML. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple