-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fabricIndex as a member of ControllerInitParams #12257
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Controller_FabricIndexMemberOfControllerInitParams
Nov 25, 2021
Merged
Add fabricIndex as a member of ControllerInitParams #12257
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Controller_FabricIndexMemberOfControllerInitParams
Nov 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
November 25, 2021 09:27
pullapprove
bot
requested review from
tecimovic,
wbschiller,
woody-apple and
yunhanw-google
November 25, 2021 09:27
PR #12257: Size comparison from c79b67b to 545b107 Increases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 25, 2021
yunhanw-google
approved these changes
Nov 25, 2021
tcarmelveilleux
approved these changes
Nov 25, 2021
andy31415
approved these changes
Nov 25, 2021
fast track: trivial change, has several checkmarks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When building an application with multiples
CHIPDeviceController
instances, the fabric index is always assume to bekMinValidFabricIndex
which is not correct in this case.Change overview
Testing
I have locally tested it into a modified instance of
chip-tool
that contains multiple controllers. Patches forchip-tool
are coming soon...