Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Get the commissioner to be an optional argument for chip … #12259

Merged
merged 1 commit into from
Nov 30, 2021
Merged

[chip-tool] Get the commissioner to be an optional argument for chip … #12259

merged 1 commit into from
Nov 30, 2021

Conversation

vivien-apple
Copy link
Contributor

…related commands instead of a dedicated command that stores the current commissioner on disk

Problem

In order to switch between commissioners with chip-tool, one needs to run the configure-fabric command. Now that chip-tool supports optional arguments it is much more convenient to use an optional argument.

Change overview

  • Remove the configure-fabric command
  • Move the current configure fabric from beeing store on disk to an optional argument

Testing

Update scripts/tests/test_suites.sh to use the "beta" commissioner

@vivien-apple vivien-apple self-assigned this Nov 25, 2021
@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12259: Size comparison from c79b67b to e043fc3

Full report (13 builds for efr32, k32w, p6, qpg, telink)
platform target config section c79b67b e043fc3 change % change
efr32 lighting-app BRD4161A (read only) 759184 759184 0 0.0
(read/write) 119812 119812 0 0.0
.bss 117988 117988 0 0.0
.data 1820 1820 0 0.0
.text 759176 759176 0 0.0
BRD4161A+rpc (read only) 746964 746964 0 0.0
(read/write) 136436 136436 0 0.0
.bss 134492 134492 0 0.0
.data 1944 1944 0 0.0
.text 746956 746956 0 0.0
lock-app BRD4161A (read only) 735120 735120 0 0.0
(read/write) 117524 117524 0 0.0
.bss 115748 115748 0 0.0
.data 1776 1776 0 0.0
.text 735112 735112 0 0.0
window-app BRD4161A (read only) 738560 738560 0 0.0
(read/write) 117884 117884 0 0.0
.bss 116100 116100 0 0.0
.data 1784 1784 0 0.0
.text 738552 738552 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 720916 720916 0 0.0
.bss 78276 78276 0 0.0
.data 1956 1956 0 0.0
.text 634884 634884 0 0.0
lock-app k32w061+debug (read/write) 611236 611236 0 0.0
.bss 68716 68716 0 0.0
.data 1920 1920 0 0.0
.text 534800 534800 0 0.0
shell k32w061+debug (read/write) 676568 676568 0 0.0
.bss 79868 79868 0 0.0
.data 1892 1892 0 0.0
.text 589008 589008 0 0.0
p6 all-clusters-app default (read/write) 2310328 2310328 0 0.0
.bss 114784 114784 0 0.0
.data 2544 2544 0 0.0
.heap 916016 916016 0 0.0
.text 1268592 1268592 0 0.0
lock-app default (read/write) 2222144 2222144 0 0.0
.bss 101080 101080 0 0.0
.data 2416 2416 0 0.0
.heap 929848 929848 0 0.0
.text 1180408 1180408 0 0.0
qpg lighting-app qpg6100+debug (read only) 500992 500992 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50384 50384 0 0.0
.data 1024 1024 0 0.0
.text 495672 495672 0 0.0
lock-app qpg6100+debug (read only) 474960 474960 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49256 49256 0 0.0
.data 980 980 0 0.0
.text 469640 469640 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 774870 774870 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 538758 538758 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_MultipleCommissionersAsArgumentInsteadOfCommand branch from e043fc3 to b8ad0e3 Compare November 25, 2021 10:24
@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12259: Size comparison from 914b58e to b8ad0e3

Full report (13 builds for efr32, k32w, p6, qpg, telink)
platform target config section 914b58e b8ad0e3 change % change
efr32 lighting-app BRD4161A (read only) 759184 759184 0 0.0
(read/write) 119812 119812 0 0.0
.bss 117988 117988 0 0.0
.data 1820 1820 0 0.0
.text 759176 759176 0 0.0
BRD4161A+rpc (read only) 746964 746964 0 0.0
(read/write) 136436 136436 0 0.0
.bss 134492 134492 0 0.0
.data 1944 1944 0 0.0
.text 746956 746956 0 0.0
lock-app BRD4161A (read only) 735120 735120 0 0.0
(read/write) 117524 117524 0 0.0
.bss 115748 115748 0 0.0
.data 1776 1776 0 0.0
.text 735112 735112 0 0.0
window-app BRD4161A (read only) 738560 738560 0 0.0
(read/write) 117884 117884 0 0.0
.bss 116100 116100 0 0.0
.data 1784 1784 0 0.0
.text 738552 738552 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 720916 720916 0 0.0
.bss 78276 78276 0 0.0
.data 1956 1956 0 0.0
.text 634884 634884 0 0.0
lock-app k32w061+debug (read/write) 611236 611236 0 0.0
.bss 68716 68716 0 0.0
.data 1920 1920 0 0.0
.text 534800 534800 0 0.0
shell k32w061+debug (read/write) 676568 676568 0 0.0
.bss 79868 79868 0 0.0
.data 1892 1892 0 0.0
.text 589008 589008 0 0.0
p6 all-clusters-app default (read/write) 2310328 2310328 0 0.0
.bss 114784 114784 0 0.0
.data 2544 2544 0 0.0
.heap 916016 916016 0 0.0
.text 1268592 1268592 0 0.0
lock-app default (read/write) 2222144 2222144 0 0.0
.bss 101080 101080 0 0.0
.data 2416 2416 0 0.0
.heap 929848 929848 0 0.0
.text 1180408 1180408 0 0.0
qpg lighting-app qpg6100+debug (read only) 500992 500992 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50384 50384 0 0.0
.data 1024 1024 0 0.0
.text 495672 495672 0 0.0
lock-app qpg6100+debug (read only) 474960 474960 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49256 49256 0 0.0
.data 980 980 0 0.0
.text 469640 469640 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 774870 774870 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 538758 538758 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_MultipleCommissionersAsArgumentInsteadOfCommand branch from b8ad0e3 to 7d749dc Compare November 25, 2021 11:10
@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12259: Size comparison from 914b58e to 7d749dc

Increases (1 build for linux)
platform target config section 914b58e 7d749dc change % change
linux chip-tool debug (read only) 6005893 6013797 7904 0.1
.got 4456 4464 8 0.2
.text 5333397 5341477 8080 0.2
Decreases (1 build for linux)
platform target config section 914b58e 7d749dc change % change
linux chip-tool debug (read/write) 199664 199624 -40 -0.0
.data.rel.ro 151632 151600 -32 -0.0
.init_array 488 480 -8 -1.6
.rodata 283944 283720 -224 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 914b58e 7d749dc change % change
efr32 lighting-app BRD4161A (read only) 759184 759184 0 0.0
(read/write) 119812 119812 0 0.0
.bss 117988 117988 0 0.0
.data 1820 1820 0 0.0
.text 759176 759176 0 0.0
BRD4161A+rpc (read only) 746964 746964 0 0.0
(read/write) 136436 136436 0 0.0
.bss 134492 134492 0 0.0
.data 1944 1944 0 0.0
.text 746956 746956 0 0.0
lock-app BRD4161A (read only) 735120 735120 0 0.0
(read/write) 117524 117524 0 0.0
.bss 115748 115748 0 0.0
.data 1776 1776 0 0.0
.text 735112 735112 0 0.0
window-app BRD4161A (read only) 738560 738560 0 0.0
(read/write) 117884 117884 0 0.0
.bss 116100 116100 0 0.0
.data 1784 1784 0 0.0
.text 738552 738552 0 0.0
esp32 all-clusters-app c3devkit (read only) 835642 835642 0 0.0
(read/write) 1224282 1224282 0 0.0
.dram0.bss 59240 59240 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165680 165680 0 0.0
.flash.text 835642 835642 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 906995 906995 0 0.0
(read/write) 423532 423532 0 0.0
.dram0.bss 64632 64632 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193548 193548 0 0.0
.flash.text 901611 901611 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 720916 720916 0 0.0
.bss 78276 78276 0 0.0
.data 1956 1956 0 0.0
.text 634884 634884 0 0.0
lock-app k32w061+debug (read/write) 611236 611236 0 0.0
.bss 68716 68716 0 0.0
.data 1920 1920 0 0.0
.text 534800 534800 0 0.0
shell k32w061+debug (read/write) 676568 676568 0 0.0
.bss 79868 79868 0 0.0
.data 1892 1892 0 0.0
.text 589008 589008 0 0.0
linux all-clusters-app debug (read only) 1769433 1769433 0 0.0
(read/write) 131480 131480 0 0.0
.bss 60080 60080 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138325 138325 0 0.0
.text 1492738 1492738 0 0.0
bridge-app debug+rpc (read only) 1345293 1345293 0 0.0
(read/write) 77824 77824 0 0.0
.bss 41712 41712 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 112988 112988 0 0.0
.text 1132213 1132213 0 0.0
chip-tool debug (read only) 6005893 6013797 7904 0.1
(read/write) 199664 199624 -40 -0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151632 151600 -32 -0.0
.dynamic 592 592 0 0.0
.got 4456 4464 8 0.2
.init 27 27 0 0.0
.init_array 488 480 -8 -1.6
.rodata 283944 283720 -224 -0.1
.text 5333397 5341477 8080 0.2
lighting-app debug+rpc (read only) 1618217 1618217 0 0.0
(read/write) 111072 111072 0 0.0
.bss 47408 47408 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131249 131249 0 0.0
.text 1349250 1349250 0 0.0
ota-provider-app debug (read only) 1309361 1309361 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114736 114736 0 0.0
.text 1094274 1094274 0 0.0
ota-requestor-app debug (read only) 1405849 1405849 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126176 126176 0 0.0
.text 1176530 1176530 0 0.0
shell debug (read only) 820129 820129 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78927 78927 0 0.0
.text 634514 634514 0 0.0
tv-app debug (read only) 1915025 1915025 0 0.0
(read/write) 320088 320088 0 0.0
.bss 250168 250168 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159240 159240 0 0.0
.text 1607586 1607586 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293520 2293520 0 0.0
.bss 181788 181788 0 0.0
.data 5240 5240 0 0.0
.heap 849416 849416 0 0.0
.text 1256120 1256120 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277552 2277552 0 0.0
.bss 172404 172404 0 0.0
.data 5600 5600 0 0.0
.heap 858440 858440 0 0.0
.text 1240152 1240152 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251936 2251936 0 0.0
.bss 171220 171220 0 0.0
.data 5584 5584 0 0.0
.heap 859640 859640 0 0.0
.text 1214536 1214536 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050800 2050800 0 0.0
.bss 156424 156424 0 0.0
.data 4984 4984 0 0.0
.heap 875040 875040 0 0.0
.text 1013400 1013400 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873291 873291 0 0.0
bss 112644 112644 0 0.0
rodata 96676 96676 0 0.0
text 588304 588304 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 835819 835819 0 0.0
bss 108996 108996 0 0.0
rodata 87924 87924 0 0.0
text 562576 562576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 798318 798318 0 0.0
bss 114020 114020 0 0.0
rodata 91936 91936 0 0.0
text 517764 517764 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 845447 845447 0 0.0
bss 109680 109680 0 0.0
rodata 92680 92680 0 0.0
text 567616 567616 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 770718 770718 0 0.0
bss 111088 111088 0 0.0
rodata 87968 87968 0 0.0
text 497172 497172 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 851547 851547 0 0.0
bss 109816 109816 0 0.0
rodata 94388 94388 0 0.0
text 571800 571800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845139 845139 0 0.0
bss 109712 109712 0 0.0
rodata 92636 92636 0 0.0
text 567236 567236 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778327 778327 0 0.0
bss 109180 109180 0 0.0
rodata 72996 72996 0 0.0
text 521552 521552 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693382 693382 0 0.0
bss 110164 110164 0 0.0
rodata 67640 67640 0 0.0
text 442160 442160 0 0.0
p6 all-clusters-app default (read/write) 2310328 2310328 0 0.0
.bss 114784 114784 0 0.0
.data 2544 2544 0 0.0
.heap 916016 916016 0 0.0
.text 1268592 1268592 0 0.0
lock-app default (read/write) 2222144 2222144 0 0.0
.bss 101080 101080 0 0.0
.data 2416 2416 0 0.0
.heap 929848 929848 0 0.0
.text 1180408 1180408 0 0.0
qpg lighting-app qpg6100+debug (read only) 500992 500992 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50384 50384 0 0.0
.data 1024 1024 0 0.0
.text 495672 495672 0 0.0
lock-app qpg6100+debug (read only) 474960 474960 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49256 49256 0 0.0
.data 980 980 0 0.0
.text 469640 469640 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 774870 774870 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 538758 538758 0 0.0

andy31415
andy31415 reviewed Nov 25, 2021
View reviewed changes
examples/chip-tool/commands/common/CHIPCommand.cpp Outdated Show resolved Hide resolved
scripts/tests/test_suites.sh Outdated Show resolved Hide resolved
@vivien-apple vivien-apple force-pushed the ChipTool_MultipleCommissionersAsArgumentInsteadOfCommand branch from 7d749dc to a2fb7d3 Compare November 29, 2021 13:15
@github-actions
Copy link

github-actions bot commented Nov 29, 2021 •
edited
Loading

PR #12259: Size comparison from f58faac to a2fb7d3

Increases (1 build for linux)
platform target config section f58faac a2fb7d3 change % change
linux chip-tool debug (read only) 6088629 6096613 7984 0.1
.got 4456 4464 8 0.2
.text 5406517 5414677 8160 0.2
Decreases (1 build for linux)
platform target config section f58faac a2fb7d3 change % change
linux chip-tool debug (read/write) 198808 198768 -40 -0.0
.data.rel.ro 152000 151968 -32 -0.0
.init_array 496 488 -8 -1.6
.rodata 292840 292616 -224 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f58faac a2fb7d3 change % change
efr32 lighting-app BRD4161A (read only) 762200 762200 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762192 762192 0 0.0
BRD4161A+rpc (read only) 790632 790632 0 0.0
(read/write) 138132 138132 0 0.0
.bss 136212 136212 0 0.0
.data 1920 1920 0 0.0
.text 790624 790624 0 0.0
lock-app BRD4161A (read only) 736144 736144 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736136 736136 0 0.0
window-app BRD4161A (read only) 739208 739208 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739200 739200 0 0.0
esp32 all-clusters-app c3devkit (read only) 836536 836536 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836536 836536 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907919 907919 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902535 902535 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723320 723320 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637272 637272 0 0.0
lock-app k32w061+debug (read/write) 612392 612392 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535932 535932 0 0.0
shell k32w061+debug (read/write) 677712 677712 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 590128 590128 0 0.0
linux all-clusters-app debug (read only) 1775081 1775081 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138965 138965 0 0.0
.text 1497746 1497746 0 0.0
bridge-app debug+rpc (read only) 1349405 1349405 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1135717 1135717 0 0.0
chip-tool debug (read only) 6088629 6096613 7984 0.1
(read/write) 198808 198768 -40 -0.0
.bss 40096 40096 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 152000 151968 -32 -0.0
.dynamic 592 592 0 0.0
.got 4456 4464 8 0.2
.init 27 27 0 0.0
.init_array 496 488 -8 -1.6
.rodata 292840 292616 -224 -0.1
.text 5406517 5414677 8160 0.2
lighting-app debug+rpc (read only) 1629065 1629065 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131889 131889 0 0.0
.text 1359458 1359458 0 0.0
ota-provider-app debug (read only) 1310401 1310401 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1095154 1095154 0 0.0
ota-requestor-app debug (read only) 1406873 1406873 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1177330 1177330 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1921377 1921377 0 0.0
(read/write) 319072 319072 0 0.0
.bss 250264 250264 0 0.0
.data 1632 1632 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160872 160872 0 0.0
.text 1612162 1612162 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294976 2294976 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257576 1257576 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2280256 2280256 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242856 1242856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253336 2253336 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215936 1215936 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875611 875611 0 0.0
bss 112660 112660 0 0.0
rodata 97188 97188 0 0.0
text 590116 590116 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838187 838187 0 0.0
bss 109012 109012 0 0.0
rodata 88436 88436 0 0.0
text 564432 564432 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800650 800650 0 0.0
bss 114036 114036 0 0.0
rodata 92444 92444 0 0.0
text 519580 519580 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846539 846539 0 0.0
bss 109700 109700 0 0.0
rodata 92972 92972 0 0.0
text 568388 568388 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771810 771810 0 0.0
bss 111108 111108 0 0.0
rodata 88260 88260 0 0.0
text 497940 497940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852511 852511 0 0.0
bss 109836 109836 0 0.0
rodata 94680 94680 0 0.0
text 572432 572432 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845619 845619 0 0.0
bss 109712 109712 0 0.0
rodata 92844 92844 0 0.0
text 567512 567512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778447 778447 0 0.0
bss 109180 109180 0 0.0
rodata 73084 73084 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67724 67724 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311304 2311304 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269568 1269568 0 0.0
lock-app default (read/write) 2223120 2223120 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181384 1181384 0 0.0
qpg lighting-app qpg6100+debug (read only) 503096 503096 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497776 497776 0 0.0
lock-app qpg6100+debug (read only) 475804 475804 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470484 470484 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777398 777398 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540724 540724 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking given this is adding testing tools.

@woody-apple
Copy link
Contributor

/rebase

@vivien-apple @woody-apple
[chip-tool] Get the commissioner to be an optional argument for chip …
ec45f0d 
…related commands instead of a dedicated command that stores the current commissioner on disk
@woody-apple woody-apple force-pushed the ChipTool_MultipleCommissionersAsArgumentInsteadOfCommand branch from a2fb7d3 to ec45f0d Compare November 30, 2021 02:51
@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

PR #12259: Size comparison from f50307a to ec45f0d

Increases (1 build for linux)
platform target config section f50307a ec45f0d change % change
linux chip-tool debug (read only) 6124325 6132309 7984 0.1
.got 4464 4472 8 0.2
.text 5439525 5447685 8160 0.2
Decreases (1 build for linux)
platform target config section f50307a ec45f0d change % change
linux chip-tool debug (read/write) 199128 199088 -40 -0.0
.data.rel.ro 152432 152384 -48 -0.0
.init_array 496 488 -8 -1.6
.rodata 294504 294280 -224 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f50307a ec45f0d change % change
efr32 lighting-app BRD4161A (read only) 762200 762200 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762192 762192 0 0.0
BRD4161A+rpc (read only) 790712 790712 0 0.0
(read/write) 138132 138132 0 0.0
.bss 136212 136212 0 0.0
.data 1920 1920 0 0.0
.text 790704 790704 0 0.0
lock-app BRD4161A (read only) 736144 736144 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736136 736136 0 0.0
window-app BRD4161A (read only) 739208 739208 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739200 739200 0 0.0
esp32 all-clusters-app c3devkit (read only) 836020 836020 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 166080 166080 0 0.0
.flash.text 836020 836020 0 0.0
.iram0.text 61390 61390 0 0.0
m5stack (read only) 907959 907959 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 33960 33960 0 0.0
.flash.rodata 193916 193916 0 0.0
.flash.text 902575 902575 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723316 723316 0 0.0
.bss 78292 78292 0 0.0
.data 1844 1844 0 0.0
.text 637380 637380 0 0.0
lock-app k32w061+debug (read/write) 612388 612388 0 0.0
.bss 68740 68740 0 0.0
.data 1808 1808 0 0.0
.text 536040 536040 0 0.0
shell k32w061+debug (read/write) 677712 677712 0 0.0
.bss 79892 79892 0 0.0
.data 1780 1780 0 0.0
.text 590240 590240 0 0.0
linux all-clusters-app debug (read only) 1775225 1775225 0 0.0
(read/write) 131416 131416 0 0.0
.bss 60144 60144 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 139093 139093 0 0.0
.text 1497762 1497762 0 0.0
bridge-app debug+rpc (read only) 1349405 1349405 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1135717 1135717 0 0.0
chip-tool debug (read only) 6124325 6132309 7984 0.1
(read/write) 199128 199088 -40 -0.0
.bss 40096 40096 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 152432 152384 -48 -0.0
.dynamic 592 592 0 0.0
.got 4464 4472 8 0.2
.init 27 27 0 0.0
.init_array 496 488 -8 -1.6
.rodata 294504 294280 -224 -0.1
.text 5439525 5447685 8160 0.2
lighting-app debug+rpc (read only) 1629353 1629353 0 0.0
(read/write) 110976 110976 0 0.0
.bss 47440 47440 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 132017 132017 0 0.0
.text 1359618 1359618 0 0.0
ota-provider-app debug (read only) 1310401 1310401 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1095154 1095154 0 0.0
ota-requestor-app debug (read only) 1406889 1406889 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1177346 1177346 0 0.0
shell debug (read only) 820449 820449 0 0.0
(read/write) 66808 66808 0 0.0
.bss 23496 23496 0 0.0
.data 224 224 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79154 79154 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1921361 1921361 0 0.0
(read/write) 318944 318944 0 0.0
.bss 250264 250264 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161032 161032 0 0.0
.text 1611986 1611986 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295088 2295088 0 0.0
.bss 181884 181884 0 0.0
.data 5128 5128 0 0.0
.heap 849432 849432 0 0.0
.text 1257688 1257688 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2280368 2280368 0 0.0
.bss 172492 172492 0 0.0
.data 5488 5488 0 0.0
.heap 858464 858464 0 0.0
.text 1242968 1242968 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253448 2253448 0 0.0
.bss 171308 171308 0 0.0
.data 5472 5472 0 0.0
.heap 859664 859664 0 0.0
.text 1216048 1216048 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051040 2051040 0 0.0
.bss 156496 156496 0 0.0
.data 4872 4872 0 0.0
.heap 875080 875080 0 0.0
.text 1013640 1013640 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875615 875615 0 0.0
bss 112660 112660 0 0.0
rodata 97296 97296 0 0.0
text 590116 590116 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838063 838063 0 0.0
bss 109012 109012 0 0.0
rodata 88560 88560 0 0.0
text 564284 564284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800650 800650 0 0.0
bss 114036 114036 0 0.0
rodata 92556 92556 0 0.0
text 519580 519580 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846539 846539 0 0.0
bss 109700 109700 0 0.0
rodata 93084 93084 0 0.0
text 568388 568388 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771810 771810 0 0.0
bss 111108 111108 0 0.0
rodata 88372 88372 0 0.0
text 497940 497940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852511 852511 0 0.0
bss 109836 109836 0 0.0
rodata 94792 94792 0 0.0
text 572432 572432 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845615 845615 0 0.0
bss 109712 109712 0 0.0
rodata 92952 92952 0 0.0
text 567512 567512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778451 778451 0 0.0
bss 109180 109180 0 0.0
rodata 73192 73192 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67836 67836 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311416 2311416 0 0.0
.bss 114688 114688 0 0.0
.data 2432 2432 0 0.0
.heap 916224 916224 0 0.0
.text 1269680 1269680 0 0.0
lock-app default (read/write) 2223232 2223232 0 0.0
.bss 100976 100976 0 0.0
.data 2304 2304 0 0.0
.heap 930064 930064 0 0.0
.text 1181496 1181496 0 0.0
qpg lighting-app qpg6100+debug (read only) 493652 493652 0 0.0
(read/write) 114144 114144 0 0.0
.bss 77464 77464 0 0.0
.data 920 920 0 0.0
.text 488332 488332 0 0.0
lock-app qpg6100+debug (read only) 466328 466328 0 0.0
(read/write) 114144 114144 0 0.0
.bss 76376 76376 0 0.0
.data 872 872 0 0.0
.text 461008 461008 0 0.0
persistent-storage-app qpg6100+debug (read only) 105612 105612 0 0.0
(read/write) 114138 114138 0 0.0
.bss 35218 35218 0 0.0
.data 276 276 0 0.0
.text 100292 100292 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777398 777398 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540724 540724 0 0.0

@vivien-apple vivien-apple merged commit 94da0bd into project-chip:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@wbschiller wbschiller Awaiting requested review from wbschiller

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees

@vivien-apple vivien-apple

Labels
examples fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @woody-apple @andy31415