Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/k32w0 shell app #12153

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Nov 23, 2021

Problem

  • shell app was not working on K32W0

Change overview

Testing

  • testing using chip-tool

* fix linkage error by disabling the ping functionality
* fix deadlock in Thread implementation
* fix printing by adding CR

This commit relates to project-chip#11346

Signed-off-by: Doru Gucea <[email protected]>
@jmartinez-silabs
Copy link
Member

I am confuse. This PR is to apply to the Test event 7 branch ? If you need it in the branch officially should we not just cherry-pick the shell fixes already in master ?

If you also need other changes for NXP, I think those should first be merged in master and then cherry-picked if need be to the te7 branch

@doru91 doru91 mentioned this pull request Nov 24, 2021
@andy31415
Copy link
Contributor

Adding checkmark because merge from master. The "\r" seems odd to me since that may not be a correct choice for all platforms (I would argue that probably it was added for windows monitoring rather than linux) however that is in master and probably does not cause that much harm.

@doru91
Copy link
Contributor Author

doru91 commented Nov 25, 2021

I am confuse. This PR is to apply to the Test event 7 branch ? If you need it in the branch officially should we not just cherry-pick the shell fixes already in master ?

If you also need other changes for NXP, I think those should first be merged in master and then cherry-picked if need be to the te7 branch

I made the changes during TE7 and that's why I targeted TE7 branch initially. Later on I also needed it on master branch and opened a PR there. But I agree, In the future I will submit the fix to the master branch and then we can cherry-pick from there.

@andy31415 andy31415 merged commit 80174ed into project-chip:test_event_7.lts Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants