Fix issues with Shell app example #11346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n doing resolve with shell restyle
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple and
sagar-apple
pullapprove
bot
requested review from
wbschiller,
woody-apple and
yunhanw-google
|
PR #11346: Size comparison from cb7c854 to ca496f8 Increases above 0.2%:
Increases (4 builds for efr32)
Decreases (9 builds for nrfconnect)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
reviewed
Nov 3, 2021
jmeg-sfy
approved these changes
Nov 3, 2021
rcasallas-silabs
approved these changes
Nov 3, 2021
jepenven-silabs
approved these changes
Nov 3, 2021
andy31415
approved these changes
Nov 3, 2021
woody-apple
approved these changes
Nov 3, 2021
…nable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Nov 11, 2021
* fix Shell build * Enable thread dns client, Fix a deadlock in thread implementation when doing resolve with shell restyle * add Carriage return to shell dns printfs * dns browse had the same deadlock. Not that it works, browse commissionable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
jmartinez-silabs
added a commit
to jmartinez-silabs/connectedhomeip
that referenced
this pull request
Nov 11, 2021
* fix Shell build * Enable thread dns client, Fix a deadlock in thread implementation when doing resolve with shell restyle * add Carriage return to shell dns printfs * dns browse had the same deadlock. Not that it works, browse commissionable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
jmartinez-silabs
added a commit
to jmartinez-silabs/connectedhomeip
that referenced
this pull request
Nov 12, 2021
* fix Shell build * Enable thread dns client, Fix a deadlock in thread implementation when doing resolve with shell restyle * add Carriage return to shell dns printfs * dns browse had the same deadlock. Not that it works, browse commissionable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Nov 16, 2021
* fix Shell build * Enable thread dns client, Fix a deadlock in thread implementation when doing resolve with shell restyle * add Carriage return to shell dns printfs * dns browse had the same deadlock. Not that it works, browse commissionable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Nov 16, 2021
* fix Shell build * Enable thread dns client, Fix a deadlock in thread implementation when doing resolve with shell restyle * add Carriage return to shell dns printfs * dns browse had the same deadlock. Not that it works, browse commissionable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
jmeg-sfy
pushed a commit
to jmeg-sfy/connectedhomeip
that referenced
this pull request
Nov 18, 2021
* fix Shell build * Enable thread dns client, Fix a deadlock in thread implementation when doing resolve with shell restyle * add Carriage return to shell dns printfs * dns browse had the same deadlock. Not that it works, browse commissionable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
doru91
added a commit
to doru91/connectedhomeip
that referenced
this pull request
Nov 23, 2021
* fix linkage error by disabling the ping functionality * fix deadlock in Thread implementation * fix printing by adding CR This commit relates to project-chip#11346 Signed-off-by: Doru Gucea <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Nov 25, 2021
* [K32W0] Read General Diagnostics cluster attribute at runtime Signed-off-by: Doru Gucea <[email protected]> * [K32W0] Fix shell app * fix linkage error by disabling the ping functionality * fix deadlock in Thread implementation * fix printing by adding CR This commit relates to #11346 Signed-off-by: Doru Gucea <[email protected]> * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* fix Shell build * Enable thread dns client, Fix a deadlock in thread implementation when doing resolve with shell restyle * add Carriage return to shell dns printfs * dns browse had the same deadlock. Not that it works, browse commissionable result was causing an overflow of the thread task in EFR32, Bump the task stack to 4k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shell example fails to build for EFR32 platform
shell dns resolve command fails to complete.
Change overview
CHIPError type changed quite a while ago and its use wasn't changed on efr shell example. Update that
Enable Thread dns client for EFR32 platform
Fix a Deadlock in the thread dns resolve as the callback was waiting on a semaphore owned by the thread task calling the callback
Fix other potential deadlocks if error would occur calling some thread apis
edit:
Removed the lock for OnDnsBrowseResult which was causing the same deadlock. Validated that it works with
dns browse commissionablewhich also made me catch a task overflow in the EFR32. fixed that also.Testing
build shell example for EFR32
Publish a matter service with avahi
on matter shell, dns resolve the service successfully