-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup darwin usage of strtok and strncpy in DNS implementation #11934
Merged
andy31415
merged 10 commits into
project-chip:master
from
andy31415:cleanup_darwin_strtok
Nov 18, 2021
Merged
Cleanup darwin usage of strtok and strncpy in DNS implementation #11934
andy31415
merged 10 commits into
project-chip:master
from
andy31415:cleanup_darwin_strtok
Nov 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
November 17, 2021 18:14
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vivien-apple,
wbschiller and
woody-apple
November 17, 2021 18:14
bzbarsky-apple
requested changes
Nov 17, 2021
bzbarsky-apple
approved these changes
Nov 17, 2021
PR #11934: Size comparison from e568d70 to 79fbcbf Full report (17 builds for k32w, linux, p6, qpg, telink)
|
PR #11934: Size comparison from e568d70 to 50a9c88 Full report (6 builds for k32w, p6, telink)
|
PR #11934: Size comparison from e568d70 to 0c73035 Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #11934: Size comparison from 1359f6e to 5cfbe88 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
previously requested changes
Nov 18, 2021
andy31415
dismissed
bzbarsky-apple’s stale review
November 18, 2021 11:58
Code review comment applied.
PR #11934: Size comparison from 02d8a1a to 911fb50 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 18, 2021
fast track: CI passes (finally) and was checked by platform owner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
free
is wrongChange overview
Testing
Expect CI to validate the changes (I made the changes on a linux machine)