Validate value lenght - 0 size value should not copy anything

project-chip · Nov 17, 2021 · 50a9c88 · 50a9c88
1 parent 79fbcbf
commit 50a9c88
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/platform/Darwin/DnssdImpl.cpp b/src/platform/Darwin/DnssdImpl.cpp
@@ -434,8 +434,9 @@ static CHIP_ERROR GetAddrInfo(void * context, DnssdResolveCallback callback, uin
             // Truncation, but nothing better we can do
             valueLen = sizeof(value) - 1;
         }
-
-        memcpy(value, valuePtr, valueLen - 1);
+        if (valueLen > 1) {
+          memcpy(value, valuePtr, valueLen - 1);
+        }
         value[valueLen] = 0;
 
         sdCtx->textEntries.push_back(TextEntry{ strdup(key), reinterpret_cast<const uint8_t *>(strdup(value)), valueLen });