Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch YAML tests to using templated ReadAttribute. #11607

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Switch YAML tests to using templated ReadAttribute. #11607

merged 1 commit into from
Nov 10, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

This will let us handle reading nullables (and structs once we can
have struct-typed attributes) propely.

Problem

YAML tests can't read interesting types (except for lists, which we have some special-case hacks for).

Change overview

Switch to using templated ReadAttribute to allow us to do that.

Also fixes the ReadAttribute templates to instantiate most of the work on a per-type basis, not per-attribute basis.

Testing

No behavior changes so far, but will be building on top of this to expand testing.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11607: Size comparison from ca811e0 to 8669c3c

Increases above 0.2%:

platform target config section ca811e0 8669c3c change % change
linux chip-tool debug (read only) 4995029 5144197 149168 3.0
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.text 4481717 4626597 144880 3.2
Increases (1 build for linux)
platform target config section ca811e0 8669c3c change % change
linux chip-tool debug (read only) 4995029 5144197 149168 3.0
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.rodata 242064 242320 256 0.1
.text 4481717 4626597 144880 3.2
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section ca811e0 8669c3c change % change
efr32 lighting-app BRD4161A (read only) 742904 742904 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742896 742896 0 0.0
BRD4161A+rpc (read only) 730440 730440 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 730432 730432 0 0.0
lock-app BRD4161A (read only) 722192 722192 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 722184 722184 0 0.0
window-app BRD4161A (read only) 723088 723088 0 0.0
(read/write) 114412 114412 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 723080 723080 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699648 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613940 613940 0 0.0
lock-app k32w061+debug (read/write) 592360 592360 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 516156 516156 0 0.0
shell k32w061+debug (read/write) 658016 658016 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 571044 571044 0 0.0
linux all-clusters-app debug (read only) 1698785 1698785 0 0.0
(read/write) 126144 126144 0 0.0
.bss 57776 57776 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139701 139701 0 0.0
.text 1426146 1426146 0 0.0
bridge-app debug+rpc (read only) 1298253 1298253 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090821 1090821 0 0.0
chip-tool debug (read only) 4995029 5144197 149168 3.0
(read/write) 134760 136488 1728 1.3
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101232 102960 1728 1.7
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 242064 242320 256 0.1
.text 4481717 4626597 144880 3.2
lighting-app debug+rpc (read only) 1557945 1557945 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1295410 1295410 0 0.0
ota-provider-app debug (read only) 1259721 1259721 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1050258 1050258 0 0.0
ota-requestor-app debug (read only) 1344281 1344281 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1121250 1121250 0 0.0
shell debug (read only) 789065 789065 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 609362 609362 0 0.0
tv-app debug (read only) 1842281 1842281 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59448 59448 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541906 1541906 0 0.0
p6 all-clusters-app default (read/write) 2297568 2297568 0 0.0
.bss 112408 112408 0 0.0
.data 2520 2520 0 0.0
.heap 918416 918416 0 0.0
.text 1255832 1255832 0 0.0
lock-app default (read/write) 2212184 2212184 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1170448 1170448 0 0.0
qpg lighting-app qpg6100+debug (read only) 490776 490776 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 485456 485456 0 0.0
lock-app qpg6100+debug (read only) 466988 466988 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461668 461668 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663750 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458596 458596 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the yaml-reads-complex-types branch from 8669c3c to 755acc0 Compare November 9, 2021 23:27
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11607: Size comparison from 13297d8 to 755acc0

Increases above 0.2%:

platform target config section 13297d8 755acc0 change % change
linux chip-tool debug (read only) 4993381 5142549 149168 3.0
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.text 4480933 4625813 144880 3.2
Increases (1 build for linux)
platform target config section 13297d8 755acc0 change % change
linux chip-tool debug (read only) 4993381 5142549 149168 3.0
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.rodata 241200 241456 256 0.1
.text 4480933 4625813 144880 3.2
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 13297d8 755acc0 change % change
efr32 lighting-app BRD4161A (read only) 742140 742140 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742132 742132 0 0.0
BRD4161A+rpc (read only) 729664 729664 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 729656 729656 0 0.0
lock-app BRD4161A (read only) 721420 721420 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 721412 721412 0 0.0
window-app BRD4161A (read only) 722316 722316 0 0.0
(read/write) 114408 114408 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 722308 722308 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698920 698920 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613212 613212 0 0.0
lock-app k32w061+debug (read/write) 591632 591632 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 515428 515428 0 0.0
shell k32w061+debug (read/write) 657288 657288 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 570316 570316 0 0.0
linux all-clusters-app debug (read only) 1696881 1696881 0 0.0
(read/write) 126144 126144 0 0.0
.bss 57776 57776 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138837 138837 0 0.0
.text 1425106 1425106 0 0.0
bridge-app debug+rpc (read only) 1296349 1296349 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110676 110676 0 0.0
.text 1089781 1089781 0 0.0
chip-tool debug (read only) 4993381 5142549 149168 3.0
(read/write) 134760 136488 1728 1.3
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101232 102960 1728 1.7
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 241200 241456 256 0.1
.text 4480933 4625813 144880 3.2
lighting-app debug+rpc (read only) 1556041 1556041 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1294370 1294370 0 0.0
ota-provider-app debug (read only) 1257817 1257817 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112352 112352 0 0.0
.text 1049218 1049218 0 0.0
ota-requestor-app debug (read only) 1342377 1342377 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123368 123368 0 0.0
.text 1120210 1120210 0 0.0
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1840633 1840633 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59448 59448 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155592 155592 0 0.0
.text 1541122 1541122 0 0.0
p6 all-clusters-app default (read/write) 2296800 2296800 0 0.0
.bss 112408 112408 0 0.0
.data 2520 2520 0 0.0
.heap 918416 918416 0 0.0
.text 1255064 1255064 0 0.0
lock-app default (read/write) 2211416 2211416 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1169680 1169680 0 0.0
qpg lighting-app qpg6100+debug (read only) 490220 490220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 484900 484900 0 0.0
lock-app qpg6100+debug (read only) 466432 466432 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461112 461112 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662998 662998 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458304 458304 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the yaml-reads-complex-types branch from 755acc0 to 6db7940 Compare November 10, 2021 00:31
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11607: Size comparison from be75489 to 6db7940

Increases above 0.2%:

platform target config section be75489 6db7940 change % change
linux chip-tool debug (read only) 4613893 4763573 149680 3.2
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.text 4102149 4247605 145456 3.5
Increases (1 build for linux)
platform target config section be75489 6db7940 change % change
linux chip-tool debug (read only) 4613893 4763573 149680 3.2
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.rodata 240496 240688 192 0.1
.text 4102149 4247605 145456 3.5
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section be75489 6db7940 change % change
efr32 lighting-app BRD4161A (read only) 742140 742140 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742132 742132 0 0.0
BRD4161A+rpc (read only) 729664 729664 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 729656 729656 0 0.0
lock-app BRD4161A (read only) 721420 721420 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 721412 721412 0 0.0
window-app BRD4161A (read only) 722316 722316 0 0.0
(read/write) 114408 114408 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 722308 722308 0 0.0
esp32 all-clusters-app c3devkit (read only) 878758 878758 0 0.0
(read/write) 1305904 1305904 0 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 878758 878758 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910135 910135 0 0.0
(read/write) 423228 423228 0 0.0
.dram0.bss 60928 60928 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204044 204044 0 0.0
.flash.text 910135 910135 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698920 698920 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613212 613212 0 0.0
lock-app k32w061+debug (read/write) 591632 591632 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 515428 515428 0 0.0
shell k32w061+debug (read/write) 657288 657288 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 570316 570316 0 0.0
linux all-clusters-app debug (read only) 1696881 1696881 0 0.0
(read/write) 126144 126144 0 0.0
.bss 57776 57776 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138837 138837 0 0.0
.text 1425106 1425106 0 0.0
bridge-app debug+rpc (read only) 1296349 1296349 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110676 110676 0 0.0
.text 1089781 1089781 0 0.0
chip-tool debug (read only) 4613893 4763573 149680 3.2
(read/write) 134760 136488 1728 1.3
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101232 102960 1728 1.7
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240496 240688 192 0.1
.text 4102149 4247605 145456 3.5
lighting-app debug+rpc (read only) 1556041 1556041 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1294370 1294370 0 0.0
ota-provider-app debug (read only) 1257817 1257817 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112352 112352 0 0.0
.text 1049218 1049218 0 0.0
ota-requestor-app debug (read only) 1342377 1342377 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123368 123368 0 0.0
.text 1120210 1120210 0 0.0
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1840633 1840633 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59432 59432 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155592 155592 0 0.0
.text 1541122 1541122 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288808 2288808 0 0.0
.bss 179396 179396 0 0.0
.data 5216 5216 0 0.0
.heap 851832 851832 0 0.0
.text 1251408 1251408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270240 2270240 0 0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1232840 1232840 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247896 2247896 0 0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1210496 1210496 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048152 2048152 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1010752 1010752 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861431 861431 0 0.0
bss 111460 111460 0 0.0
rodata 96472 96472 0 0.0
text 577860 577860 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823775 823775 0 0.0
bss 107812 107812 0 0.0
rodata 87648 87648 0 0.0
text 552008 552008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786454 786454 0 0.0
bss 112832 112832 0 0.0
rodata 91728 91728 0 0.0
text 507332 507332 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838123 838123 0 0.0
bss 110492 110492 0 0.0
rodata 92844 92844 0 0.0
text 559344 559344 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763418 763418 0 0.0
bss 111904 111904 0 0.0
rodata 88148 88148 0 0.0
text 488908 488908 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844231 844231 0 0.0
bss 110632 110632 0 0.0
rodata 94552 94552 0 0.0
text 563504 563504 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837975 837975 0 0.0
bss 110528 110528 0 0.0
rodata 92840 92840 0 0.0
text 559080 559080 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775703 775703 0 0.0
bss 109280 109280 0 0.0
rodata 72108 72108 0 0.0
text 519736 519736 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690758 690758 0 0.0
bss 110264 110264 0 0.0
rodata 66752 66752 0 0.0
text 440344 440344 0 0.0
p6 all-clusters-app default (read/write) 2296800 2296800 0 0.0
.bss 112408 112408 0 0.0
.data 2520 2520 0 0.0
.heap 918416 918416 0 0.0
.text 1255064 1255064 0 0.0
lock-app default (read/write) 2211416 2211416 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1169680 1169680 0 0.0
qpg lighting-app qpg6100+debug (read only) 490220 490220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 484900 484900 0 0.0
lock-app qpg6100+debug (read only) 466432 466432 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461112 461112 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662998 662998 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458304 458304 0 0.0

@bzbarsky-apple
Switch YAML tests to using templated ReadAttribute.
79bd4d6 
This will let us handle reading nullables (and structs once we can
have struct-typed attributes) propely.
@bzbarsky-apple bzbarsky-apple force-pushed the yaml-reads-complex-types branch from 6db7940 to 79bd4d6 Compare November 10, 2021 04:12
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11607: Size comparison from 22e3e9d to 79bd4d6

Increases above 0.2%:

platform target config section 22e3e9d 79bd4d6 change % change
linux chip-tool debug (read only) 4613893 4763429 149536 3.2
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.text 4102149 4247461 145312 3.5
Increases (1 build for linux)
platform target config section 22e3e9d 79bd4d6 change % change
linux chip-tool debug (read only) 4613893 4763429 149536 3.2
(read/write) 134760 136488 1728 1.3
.data.rel.ro 101232 102960 1728 1.7
.rodata 240496 240688 192 0.1
.text 4102149 4247461 145312 3.5
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22e3e9d 79bd4d6 change % change
efr32 lighting-app BRD4161A (read only) 742140 742140 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742132 742132 0 0.0
BRD4161A+rpc (read only) 729664 729664 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 729656 729656 0 0.0
lock-app BRD4161A (read only) 721420 721420 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 721412 721412 0 0.0
window-app BRD4161A (read only) 722316 722316 0 0.0
(read/write) 114408 114408 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 722308 722308 0 0.0
esp32 all-clusters-app c3devkit (read only) 878758 878758 0 0.0
(read/write) 1305904 1305904 0 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 878758 878758 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910199 910199 0 0.0
(read/write) 423228 423228 0 0.0
.dram0.bss 60928 60928 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204044 204044 0 0.0
.flash.text 910199 910199 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698920 698920 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613212 613212 0 0.0
lock-app k32w061+debug (read/write) 591648 591648 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 515444 515444 0 0.0
shell k32w061+debug (read/write) 657288 657288 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 570316 570316 0 0.0
linux all-clusters-app debug (read only) 1696881 1696881 0 0.0
(read/write) 126144 126144 0 0.0
.bss 57776 57776 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138837 138837 0 0.0
.text 1425106 1425106 0 0.0
bridge-app debug+rpc (read only) 1296349 1296349 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110676 110676 0 0.0
.text 1089781 1089781 0 0.0
chip-tool debug (read only) 4613893 4763429 149536 3.2
(read/write) 134760 136488 1728 1.3
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101232 102960 1728 1.7
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240496 240688 192 0.1
.text 4102149 4247461 145312 3.5
lighting-app debug+rpc (read only) 1556041 1556041 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1294370 1294370 0 0.0
ota-provider-app debug (read only) 1257817 1257817 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112352 112352 0 0.0
.text 1049218 1049218 0 0.0
ota-requestor-app debug (read only) 1342377 1342377 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123368 123368 0 0.0
.text 1120210 1120210 0 0.0
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1840633 1840633 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59432 59432 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155592 155592 0 0.0
.text 1541122 1541122 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288808 2288808 0 0.0
.bss 179396 179396 0 0.0
.data 5216 5216 0 0.0
.heap 851832 851832 0 0.0
.text 1251408 1251408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270240 2270240 0 0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1232840 1232840 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247896 2247896 0 0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1210496 1210496 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048152 2048152 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1010752 1010752 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861431 861431 0 0.0
bss 111460 111460 0 0.0
rodata 96472 96472 0 0.0
text 577860 577860 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823775 823775 0 0.0
bss 107812 107812 0 0.0
rodata 87648 87648 0 0.0
text 552008 552008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786454 786454 0 0.0
bss 112832 112832 0 0.0
rodata 91728 91728 0 0.0
text 507332 507332 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838123 838123 0 0.0
bss 110492 110492 0 0.0
rodata 92844 92844 0 0.0
text 559344 559344 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763418 763418 0 0.0
bss 111904 111904 0 0.0
rodata 88148 88148 0 0.0
text 488908 488908 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844231 844231 0 0.0
bss 110632 110632 0 0.0
rodata 94552 94552 0 0.0
text 563504 563504 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837975 837975 0 0.0
bss 110528 110528 0 0.0
rodata 92840 92840 0 0.0
text 559080 559080 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775703 775703 0 0.0
bss 109280 109280 0 0.0
rodata 72108 72108 0 0.0
text 519736 519736 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690758 690758 0 0.0
bss 110264 110264 0 0.0
rodata 66752 66752 0 0.0
text 440344 440344 0 0.0
p6 all-clusters-app default (read/write) 2296800 2296800 0 0.0
.bss 112408 112408 0 0.0
.data 2520 2520 0 0.0
.heap 918416 918416 0 0.0
.text 1255064 1255064 0 0.0
lock-app default (read/write) 2211416 2211416 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1169680 1169680 0 0.0
qpg lighting-app qpg6100+debug (read only) 490220 490220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 484900 484900 0 0.0
lock-app qpg6100+debug (read only) 466432 466432 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461112 461112 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662998 662998 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458304 458304 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

@saurabhst @msandstedt @jepenven-silabs @jmartinez-silabs @Damian-Nordic @LuDuda Please take a look?

@bzbarsky-apple bzbarsky-apple merged commit 9964cdb into project-chip:master Nov 10, 2021
@bzbarsky-apple bzbarsky-apple deleted the yaml-reads-complex-types branch November 10, 2021 22:12
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Switch YAML tests to using templated ReadAttribute. (project-chip#11607)
00fb5c5 
This will let us handle reading nullables (and structs once we can
have struct-typed attributes) propely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @mrjerryjohns @saurabhst @woody-apple