-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove temporary RNG entropy audit logs #11600
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
tcarmelveilleux:remote-rng-audit
Nov 9, 2021
Merged
Remove temporary RNG entropy audit logs #11600
bzbarsky-apple
merged 1 commit into
project-chip:master
from
tcarmelveilleux:remote-rng-audit
Nov 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon and
vivien-apple
November 9, 2021 19:34
pullapprove
bot
requested review from
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 9, 2021 19:34
andy31415
approved these changes
Nov 9, 2021
fast track: pure removal of temporary code. |
PR #11600: Size comparison from e6dab37 to b3a7fd9 Decreases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 9, 2021
Odd:
|
/rebase |
woody-apple
approved these changes
Nov 9, 2021
- Remove the temporary RNG entropy audit now that project-chip#10454 is complete. Fixes project-chip#10454 Fixes project-chip#10526 Fixes project-chip#10527
woody-apple
force-pushed
the
remote-rng-audit
branch
from
November 9, 2021 21:52
b3a7fd9
to
6063421
Compare
emargolis
approved these changes
Nov 9, 2021
PR #11600: Size comparison from ca811e0 to 6063421 Decreases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
- Remove the temporary RNG entropy audit now that project-chip#10454 is complete. Fixes project-chip#10454 Fixes project-chip#10526 Fixes project-chip#10527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To resolve #10454, we added temporary logs to the
Entropy.cc
init function.These logs are no longer necessary.
Change overview
is complete.
Fixes #10454
Fixes #10526
Fixes #10527
Testing
Tested Linux all-clusters-app for the absence of the audit logs.