Add a way to run custom cluster logic for attribute write #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add yaml test case for NullablesAndOptionalsStruct listconnectedhomeip/src/app/clusters/test-cluster-server/test-cluster-server.cpp Lines 340 to 345 in d38aee2 This comment was generated by todo based on a
|
Refactor WriteSingleClusterData and all dependent functions to take ConcreteAttributePath instead of ClusterInfoconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 482 to 492 in d38aee2 This comment was generated by todo based on a
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
|
PR #11520: Size comparison from 3f82de1 to d38aee2 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Nov 8, 2021
mrjerryjohns
suggested changes
Nov 8, 2021
|
PR #11520: Size comparison from 86511a1 to c523fa9 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #11520: Size comparison from 94c5144 to 4ee1f61 Increases above 0.2%:
Increases (19 builds for efr32, k32w, linux, p6, qpg, telink)
Decreases (1 build for p6)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
|
PR #11520: Size comparison from 94c5144 to f2c6661 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 9, 2021
|
PR #11520: Size comparison from e6dab37 to 09a4172 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
requested changes
Nov 10, 2021
|
PR #11520: Size comparison from d45cfaa to 49857da Increases (8 builds for k32w, p6, qpg, telink)
Decreases (1 build for p6)
Full report (9 builds for k32w, p6, qpg, telink)
|
|
PR #11520: Size comparison from d45cfaa to e070547 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #11520: Size comparison from 9164605 to 7d38e01 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 11, 2021
saurabhst
approved these changes
Nov 11, 2021
|
PR #11520: Size comparison from 4ae5f21 to b8852b5 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
approved these changes
Nov 12, 2021
This was referenced Nov 12, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…ip#11520) * Add a way to run custom cluster logic for attribute write * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Currently, we only have read API in AttributeAccessInterface to handle platform attributes (the attributes handled by SDK-internal logic, neither living in the "global" attribute store nor handled by an application-level callback by marking them "external".
We need to have a write API in AttributeAccessInterface to handle the write operation for those platform attributes using SDK-internal logic.
Change overview
Add a way to have SDK-internal logic run to write attribute values in TLV form to platform.
This mechanism, when it's used, if the attribute write is not handled by the SDK-nternal logic, we fall back to write it to the attribute store (which might call into the external attribute machinery).
Testing
How was this tested? (at least one bullet point required)