Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ListBuilder/Parser and StructBuilder/Parser #11231

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Add ListBuilder/Parser and StructBuilder/Parser #11231

merged 3 commits into from
Nov 1, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Oct 29, 2021 •
edited
Loading

Problem

--Fix ListBuilder naming, which should be ArrayBuilder
--Refactor common List/Struct logic from IM IB/Messages to ListBuilder/Parser and StructBuilder/Parser, update some of messageDef and others would be updated in the following week.
--List/Array/Struct are base module for all IB/Messages for IM, and create the dedicate builder/parser would reduce lots of duplicate code.

Change overview

See above

Testing

The existing tests are using them.
Add unit tests

@boring-cyborg boring-cyborg bot added the app label Oct 29, 2021
@pullapprove pullapprove bot requested a review from yufengwangca October 29, 2021 20:21
@github-actions
Copy link

PR #11231: Size comparison from 345723d to bb87c8e

Increases (2 builds for p6, telink)
platform target config section 345723d bb87c8e change % change
p6 lock-app default (read/write) 2167872 2168016 144 0.0
.text 1126136 1126280 144 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662986 96 0.0
text 458036 458082 46 0.0
Full report (2 builds for p6, telink)
platform target config section 345723d bb87c8e change % change
p6 lock-app default (read/write) 2167872 2168016 144 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126280 144 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662986 96 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458082 46 0.0

@yunhanw-google yunhanw-google force-pushed the feature/add_struct_array_builder branch from bb87c8e to 99a9c43 Compare October 29, 2021 20:39
andy31415
andy31415 approved these changes Oct 29, 2021
View reviewed changes
src/app/MessageDef/ArrayBuilder.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/ArrayBuilder.cpp Show resolved Hide resolved
src/app/MessageDef/StructBuilder.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11231: Size comparison from 345723d to 99a9c43

Increases (26 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 345723d 99a9c43 change % change
efr32 lighting-app BRD4161A (read only) 701348 701860 512 0.1
.text 701340 701852 512 0.1
BRD4161A+rpc (read only) 727300 727812 512 0.1
.text 727292 727804 512 0.1
lock-app BRD4161A (read only) 680576 681076 500 0.1
.text 680568 681068 500 0.1
window-app BRD4161A (read only) 681488 681996 508 0.1
.text 681480 681988 508 0.1
esp32 all-clusters-app c3devkit (read only) 877674 877846 172 0.0
(read/write) 1307072 1307360 288 0.0
.flash.rodata 199088 199376 288 0.1
.flash.text 877674 877846 172 0.0
m5stack (read only) 908859 908987 128 0.0
(read/write) 426852 427132 280 0.1
.flash.rodata 207812 208092 280 0.1
.flash.text 908859 908987 128 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699636 508 0.1
.text 613708 614216 508 0.1
lock-app k32w061+debug (read/write) 591432 591928 496 0.1
.text 515548 516044 496 0.1
linux all-clusters-app debug (read only) 1666489 1667081 592 0.0
.rodata 137013 137237 224 0.2
.text 1397282 1397650 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4288501 4289093 592 0.0
.rodata 216304 216528 224 0.1
.text 3808053 3808421 368 0.0
lighting-app debug+rpc (read only) 1540865 1541473 608 0.0
.rodata 128113 128337 224 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239641 608 0.0
.rodata 110408 110632 224 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302673 640 0.0
.rodata 127072 127328 256 0.2
.text 1077170 1077554 384 0.0
tv-app debug (read only) 1773337 1773929 592 0.0
.rodata 153464 153688 224 0.1
.text 1477682 1478050 368 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861263 861639 376 0.0
rodata 96856 97024 168 0.2
text 577612 577812 200 0.0
nrf52840dk_nrf52840+rpc (read/write) 822091 822467 376 0.0
rodata 87636 87804 168 0.2
text 550784 550988 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786666 360 0.0
rodata 92100 92268 168 0.2
text 507080 507280 200 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837971 838331 360 0.0
rodata 93212 93380 168 0.2
text 559092 559292 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763266 763642 376 0.0
rodata 88516 88684 168 0.2
text 488652 488852 200 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 843019 376 0.0
rodata 94460 94628 168 0.2
text 562300 562504 204 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838323 376 0.0
rodata 93236 93404 168 0.2
text 558932 559136 204 0.0
p6 lock-app default (read/write) 2167872 2168360 488 0.0
.text 1126136 1126624 488 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490992 492 0.1
.text 485180 485672 492 0.1
lock-app qpg6100+debug (read only) 466840 467320 480 0.1
.text 461520 462000 480 0.1
telink lighting-app tlsr9518adk80d (read/write) 662890 663202 312 0.0
text 458036 458206 170 0.0
Decreases (4 builds for efr32, mbed)
platform target config section 345723d 99a9c43 change % change
efr32 window-app BRD4161A (read/write) 112020 112016 -4 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291992 2291984 -8 -0.0
.text 1254592 1254584 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2274328 -8 -0.0
.text 1236936 1236928 -8 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252056 2252048 -8 -0.0
.text 1214656 1214648 -8 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 345723d 99a9c43 change % change
efr32 lighting-app BRD4161A (read only) 701348 701860 512 0.1
(read/write) 113876 113876 0 0.0
.bss 112124 112124 0 0.0
.data 1752 1752 0 0.0
.text 701340 701852 512 0.1
BRD4161A+rpc (read only) 727300 727812 512 0.1
(read/write) 131096 131096 0 0.0
.bss 129244 129244 0 0.0
.data 1852 1852 0 0.0
.text 727292 727804 512 0.1
lock-app BRD4161A (read only) 680576 681076 500 0.1
(read/write) 111692 111692 0 0.0
.bss 109980 109980 0 0.0
.data 1712 1712 0 0.0
.text 680568 681068 500 0.1
window-app BRD4161A (read only) 681488 681996 508 0.1
(read/write) 112020 112016 -4 -0.0
.bss 110300 110300 0 0.0
.data 1716 1716 0 0.0
.text 681480 681988 508 0.1
esp32 all-clusters-app c3devkit (read only) 877674 877846 172 0.0
(read/write) 1307072 1307360 288 0.0
.dram0.bss 58296 58296 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 199088 199376 288 0.1
.flash.text 877674 877846 172 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 908859 908987 128 0.0
(read/write) 426852 427132 280 0.1
.dram0.bss 60792 60792 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207812 208092 280 0.1
.flash.text 908859 908987 128 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699636 508 0.1
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 614216 508 0.1
lock-app k32w061+debug (read/write) 591432 591928 496 0.1
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 516044 496 0.1
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1666489 1667081 592 0.0
(read/write) 118080 118080 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61536 61536 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 137013 137237 224 0.2
.text 1397282 1397650 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4288501 4289093 592 0.0
(read/write) 122752 122752 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98080 98080 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 216304 216528 224 0.1
.text 3808053 3808421 368 0.0
lighting-app debug+rpc (read only) 1540865 1541473 608 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128337 224 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239641 608 0.0
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110632 224 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302673 640 0.0
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127328 256 0.2
.text 1077170 1077554 384 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1773929 592 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153688 224 0.1
.text 1477682 1478050 368 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291992 2291984 -8 -0.0
.bss 179668 179668 0 0.0
.data 5192 5192 0 0.0
.heap 851584 851584 0 0.0
.text 1254592 1254584 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274328 -8 -0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236928 -8 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2252048 -8 -0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214648 -8 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861263 861639 376 0.0
bss 111180 111180 0 0.0
rodata 96856 97024 168 0.2
text 577612 577812 200 0.0
nrf52840dk_nrf52840+rpc (read/write) 822091 822467 376 0.0
bss 107424 107424 0 0.0
rodata 87636 87804 168 0.2
text 550784 550988 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786666 360 0.0
bss 112556 112556 0 0.0
rodata 92100 92268 168 0.2
text 507080 507280 200 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837971 838331 360 0.0
bss 110216 110216 0 0.0
rodata 93212 93380 168 0.2
text 559092 559292 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763266 763642 376 0.0
bss 111628 111628 0 0.0
rodata 88516 88684 168 0.2
text 488652 488852 200 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 843019 376 0.0
bss 110352 110352 0 0.0
rodata 94460 94628 168 0.2
text 562300 562504 204 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838323 376 0.0
bss 110252 110252 0 0.0
rodata 93236 93404 168 0.2
text 558932 559136 204 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2168360 488 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126624 488 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490992 492 0.1
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485672 492 0.1
lock-app qpg6100+debug (read only) 466840 467320 480 0.1
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461520 462000 480 0.1
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 663202 312 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458206 170 0.0

@yunhanw-google yunhanw-google mentioned this pull request Oct 29, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/add_struct_array_builder branch from 99a9c43 to 8f67ca3 Compare October 29, 2021 22:05
@restyled-io restyled-io bot mentioned this pull request Oct 29, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/add_struct_array_builder branch from 8f67ca3 to f16ff33 Compare October 29, 2021 22:24
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11231: Size comparison from 345723d to f16ff33

Increases (26 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 345723d f16ff33 change % change
efr32 lighting-app BRD4161A (read only) 701348 701780 432 0.1
.text 701340 701772 432 0.1
BRD4161A+rpc (read only) 727300 727732 432 0.1
.text 727292 727724 432 0.1
lock-app BRD4161A (read only) 680576 680996 420 0.1
.text 680568 680988 420 0.1
window-app BRD4161A (read only) 681488 681932 444 0.1
.text 681480 681924 444 0.1
esp32 all-clusters-app c3devkit (read only) 877674 877822 148 0.0
(read/write) 1307072 1307360 288 0.0
.flash.rodata 199088 199376 288 0.1
.flash.text 877674 877822 148 0.0
m5stack (read only) 908859 909071 212 0.0
(read/write) 426852 427132 280 0.1
.flash.rodata 207812 208092 280 0.1
.flash.text 908859 909071 212 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699572 444 0.1
.text 613708 614152 444 0.1
lock-app k32w061+debug (read/write) 591432 591868 436 0.1
.text 515548 515984 436 0.1
linux all-clusters-app debug (read only) 1666489 1667113 624 0.0
.rodata 137013 137269 256 0.2
.text 1397282 1397650 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4288501 4289093 592 0.0
.rodata 216304 216528 224 0.1
.text 3808053 3808421 368 0.0
lighting-app debug+rpc (read only) 1540865 1541505 640 0.0
.rodata 128113 128369 256 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239673 640 0.1
.rodata 110408 110664 256 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302641 608 0.0
.rodata 127072 127296 224 0.2
.text 1077170 1077554 384 0.0
tv-app debug (read only) 1773337 1773897 560 0.0
.rodata 153464 153656 192 0.1
.text 1477682 1478050 368 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861263 861559 296 0.0
rodata 96856 97024 168 0.2
text 577612 577740 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 822091 822387 296 0.0
rodata 87636 87804 168 0.2
text 550784 550916 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786602 296 0.0
rodata 92100 92268 168 0.2
text 507080 507208 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837971 838267 296 0.0
rodata 93212 93380 168 0.2
text 559092 559220 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763266 763562 296 0.0
rodata 88516 88684 168 0.2
text 488652 488780 128 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842939 296 0.0
rodata 94460 94628 168 0.2
text 562300 562432 132 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838259 312 0.0
rodata 93236 93404 168 0.2
text 558932 559064 132 0.0
p6 lock-app default (read/write) 2167872 2168296 424 0.0
.text 1126136 1126560 424 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490924 424 0.1
.text 485180 485604 424 0.1
lock-app qpg6100+debug (read only) 466840 467252 412 0.1
.text 461520 461932 412 0.1
telink lighting-app tlsr9518adk80d (read/write) 662890 663178 288 0.0
text 458036 458184 148 0.0
Decreases (4 builds for efr32, mbed)
platform target config section 345723d f16ff33 change % change
efr32 window-app BRD4161A (read/write) 112020 112016 -4 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291992 2291920 -72 -0.0
.text 1254592 1254520 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2274256 -80 -0.0
.text 1236936 1236856 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252056 2251976 -80 -0.0
.text 1214656 1214576 -80 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 345723d f16ff33 change % change
efr32 lighting-app BRD4161A (read only) 701348 701780 432 0.1
(read/write) 113876 113876 0 0.0
.bss 112124 112124 0 0.0
.data 1752 1752 0 0.0
.text 701340 701772 432 0.1
BRD4161A+rpc (read only) 727300 727732 432 0.1
(read/write) 131096 131096 0 0.0
.bss 129244 129244 0 0.0
.data 1852 1852 0 0.0
.text 727292 727724 432 0.1
lock-app BRD4161A (read only) 680576 680996 420 0.1
(read/write) 111692 111692 0 0.0
.bss 109980 109980 0 0.0
.data 1712 1712 0 0.0
.text 680568 680988 420 0.1
window-app BRD4161A (read only) 681488 681932 444 0.1
(read/write) 112020 112016 -4 -0.0
.bss 110300 110300 0 0.0
.data 1716 1716 0 0.0
.text 681480 681924 444 0.1
esp32 all-clusters-app c3devkit (read only) 877674 877822 148 0.0
(read/write) 1307072 1307360 288 0.0
.dram0.bss 58296 58296 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 199088 199376 288 0.1
.flash.text 877674 877822 148 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 908859 909071 212 0.0
(read/write) 426852 427132 280 0.1
.dram0.bss 60792 60792 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207812 208092 280 0.1
.flash.text 908859 909071 212 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699572 444 0.1
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 614152 444 0.1
lock-app k32w061+debug (read/write) 591432 591868 436 0.1
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515984 436 0.1
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1666489 1667113 624 0.0
(read/write) 118080 118080 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61536 61536 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 137013 137269 256 0.2
.text 1397282 1397650 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4288501 4289093 592 0.0
(read/write) 122752 122752 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98080 98080 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 216304 216528 224 0.1
.text 3808053 3808421 368 0.0
lighting-app debug+rpc (read only) 1540865 1541505 640 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128369 256 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239673 640 0.1
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110664 256 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302641 608 0.0
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127296 224 0.2
.text 1077170 1077554 384 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1773897 560 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153656 192 0.1
.text 1477682 1478050 368 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291992 2291920 -72 -0.0
.bss 179668 179668 0 0.0
.data 5192 5192 0 0.0
.heap 851584 851584 0 0.0
.text 1254592 1254520 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274256 -80 -0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236856 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2251976 -80 -0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214576 -80 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861263 861559 296 0.0
bss 111180 111180 0 0.0
rodata 96856 97024 168 0.2
text 577612 577740 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 822091 822387 296 0.0
bss 107424 107424 0 0.0
rodata 87636 87804 168 0.2
text 550784 550916 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786602 296 0.0
bss 112556 112556 0 0.0
rodata 92100 92268 168 0.2
text 507080 507208 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837971 838267 296 0.0
bss 110216 110216 0 0.0
rodata 93212 93380 168 0.2
text 559092 559220 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763266 763562 296 0.0
bss 111628 111628 0 0.0
rodata 88516 88684 168 0.2
text 488652 488780 128 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842939 296 0.0
bss 110352 110352 0 0.0
rodata 94460 94628 168 0.2
text 562300 562432 132 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838259 312 0.0
bss 110252 110252 0 0.0
rodata 93236 93404 168 0.2
text 558932 559064 132 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2168296 424 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126560 424 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490924 424 0.1
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485604 424 0.1
lock-app qpg6100+debug (read only) 466840 467252 412 0.1
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461520 461932 412 0.1
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 663178 288 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458184 148 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as far as it goes, but again I think a setup more like the cluster-object setup might be less code...

@yunhanw-google
Add ListBuilder/Parser and StructBuilder/Parser
364526f 
--Fix ListBuilder naming, which should be ArrayBuilder
--Add ListBuilder/Parser and StructBuilder/Praser, the enablement for them would be
follow-up PR
@yunhanw-google yunhanw-google force-pushed the feature/add_struct_array_builder branch from f16ff33 to 364526f Compare October 30, 2021 02:36
@github-actions
Copy link

github-actions bot commented Oct 30, 2021 •
edited
Loading

PR #11231: Size comparison from bf585f8 to 364526f

Increases (26 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section bf585f8 364526f change % change
efr32 lighting-app BRD4161A (read only) 736636 737084 448 0.1
.text 736628 737076 448 0.1
BRD4161A+rpc (read only) 724076 724508 432 0.1
.text 724068 724500 432 0.1
lock-app BRD4161A (read only) 715932 716368 436 0.1
.text 715924 716360 436 0.1
window-app BRD4161A (read only) 716836 717280 444 0.1
(read/write) 112616 112620 4 0.0
.text 716828 717272 444 0.1
esp32 all-clusters-app c3devkit (read only) 880562 880710 148 0.0
(read/write) 1307800 1308088 288 0.0
.flash.rodata 199640 199928 288 0.1
.flash.text 880562 880710 148 0.0
m5stack (read only) 911451 911583 132 0.0
(read/write) 427560 427840 280 0.1
.flash.rodata 208344 208624 280 0.1
.flash.text 911451 911583 132 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699572 444 0.1
.text 613708 614152 444 0.1
lock-app k32w061+debug (read/write) 591432 591868 436 0.1
.text 515548 515984 436 0.1
linux all-clusters-app debug (read only) 1687001 1687625 624 0.0
.rodata 138069 138325 256 0.2
.text 1415874 1416242 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4314925 4315517 592 0.0
.rodata 217360 217584 224 0.1
.text 3831621 3831989 368 0.0
lighting-app debug+rpc (read only) 1540865 1541505 640 0.0
.rodata 128113 128369 256 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239673 640 0.1
.rodata 110408 110664 256 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302641 608 0.0
.rodata 127072 127296 224 0.2
.text 1077170 1077554 384 0.0
tv-app debug (read only) 1773337 1773897 560 0.0
.rodata 153464 153656 192 0.1
.text 1477682 1478050 368 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861563 296 0.0
rodata 96860 97028 168 0.2
text 577612 577740 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822391 296 0.0
rodata 87640 87808 168 0.2
text 550784 550916 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786602 296 0.0
rodata 92100 92268 168 0.2
text 507080 507208 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838271 296 0.0
rodata 93216 93384 168 0.2
text 559092 559220 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763566 296 0.0
rodata 88520 88688 168 0.2
text 488652 488780 128 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842939 296 0.0
rodata 94460 94628 168 0.2
text 562300 562432 132 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838259 312 0.0
rodata 93236 93404 168 0.2
text 558932 559064 132 0.0
p6 lock-app default (read/write) 2167872 2168296 424 0.0
.text 1126136 1126560 424 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490924 424 0.1
.text 485180 485604 424 0.1
lock-app qpg6100+debug (read only) 466844 467256 412 0.1
.text 461524 461936 412 0.1
telink lighting-app tlsr9518adk80d (read/write) 662890 663178 288 0.0
text 458036 458184 148 0.0
Decreases (3 builds for mbed)
platform target config section bf585f8 364526f change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294952 2294880 -72 -0.0
.text 1257552 1257480 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2274256 -80 -0.0
.text 1236936 1236856 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252056 2251976 -80 -0.0
.text 1214656 1214576 -80 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bf585f8 364526f change % change
efr32 lighting-app BRD4161A (read only) 736636 737084 448 0.1
(read/write) 114476 114476 0 0.0
.bss 112724 112724 0 0.0
.data 1752 1752 0 0.0
.text 736628 737076 448 0.1
BRD4161A+rpc (read only) 724076 724508 432 0.1
(read/write) 131080 131080 0 0.0
.bss 129228 129228 0 0.0
.data 1852 1852 0 0.0
.text 724068 724500 432 0.1
lock-app BRD4161A (read only) 715932 716368 436 0.1
(read/write) 112292 112292 0 0.0
.bss 110580 110580 0 0.0
.data 1712 1712 0 0.0
.text 715924 716360 436 0.1
window-app BRD4161A (read only) 716836 717280 444 0.1
(read/write) 112616 112620 4 0.0
.bss 110900 110900 0 0.0
.data 1716 1716 0 0.0
.text 716828 717272 444 0.1
esp32 all-clusters-app c3devkit (read only) 880562 880710 148 0.0
(read/write) 1307800 1308088 288 0.0
.dram0.bss 58456 58456 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199928 288 0.1
.flash.text 880562 880710 148 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911451 911583 132 0.0
(read/write) 427560 427840 280 0.1
.dram0.bss 60952 60952 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 208624 280 0.1
.flash.text 911451 911583 132 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699572 444 0.1
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 614152 444 0.1
lock-app k32w061+debug (read/write) 591432 591868 436 0.1
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515984 436 0.1
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1687001 1687625 624 0.0
(read/write) 119024 119024 0 0.0
.bss 50640 50640 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138325 256 0.2
.text 1415874 1416242 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4314925 4315517 592 0.0
(read/write) 123648 123648 0 0.0
.bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217584 224 0.1
.text 3831621 3831989 368 0.0
lighting-app debug+rpc (read only) 1540865 1541505 640 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128369 256 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239673 640 0.1
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110664 256 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302641 608 0.0
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127296 224 0.2
.text 1077170 1077554 384 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1773897 560 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153656 192 0.1
.text 1477682 1478050 368 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2294880 -72 -0.0
.bss 179828 179828 0 0.0
.data 5216 5216 0 0.0
.heap 851400 851400 0 0.0
.text 1257552 1257480 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274256 -80 -0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236856 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2251976 -80 -0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214576 -80 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861563 296 0.0
bss 111180 111180 0 0.0
rodata 96860 97028 168 0.2
text 577612 577740 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822391 296 0.0
bss 107424 107424 0 0.0
rodata 87640 87808 168 0.2
text 550784 550916 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786602 296 0.0
bss 112556 112556 0 0.0
rodata 92100 92268 168 0.2
text 507080 507208 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838271 296 0.0
bss 110216 110216 0 0.0
rodata 93216 93384 168 0.2
text 559092 559220 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763566 296 0.0
bss 111628 111628 0 0.0
rodata 88520 88688 168 0.2
text 488652 488780 128 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842939 296 0.0
bss 110352 110352 0 0.0
rodata 94460 94628 168 0.2
text 562300 562432 132 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838259 312 0.0
bss 110252 110252 0 0.0
rodata 93236 93404 168 0.2
text 558932 559064 132 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2168296 424 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126560 424 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490924 424 0.1
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485604 424 0.1
lock-app qpg6100+debug (read only) 466844 467256 412 0.1
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461524 461936 412 0.1
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 663178 288 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458184 148 0.0

@github-actions
Copy link

github-actions bot commented Oct 30, 2021 •
edited
Loading

PR #11231: Size comparison from bf585f8 to be80d63

Increases (26 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section bf585f8 be80d63 change % change
efr32 lighting-app BRD4161A (read only) 736636 737084 448 0.1
.text 736628 737076 448 0.1
BRD4161A+rpc (read only) 724076 724508 432 0.1
.text 724068 724500 432 0.1
lock-app BRD4161A (read only) 715932 716368 436 0.1
.text 715924 716360 436 0.1
window-app BRD4161A (read only) 716836 717280 444 0.1
(read/write) 112616 112620 4 0.0
.text 716828 717272 444 0.1
esp32 all-clusters-app c3devkit (read only) 880562 880710 148 0.0
(read/write) 1307800 1308088 288 0.0
.flash.rodata 199640 199928 288 0.1
.flash.text 880562 880710 148 0.0
m5stack (read only) 911451 911583 132 0.0
(read/write) 427560 427840 280 0.1
.flash.rodata 208344 208624 280 0.1
.flash.text 911451 911583 132 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699572 444 0.1
.text 613708 614152 444 0.1
lock-app k32w061+debug (read/write) 591432 591868 436 0.1
.text 515548 515984 436 0.1
linux all-clusters-app debug (read only) 1687001 1687625 624 0.0
.rodata 138069 138325 256 0.2
.text 1415874 1416242 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4314925 4315517 592 0.0
.rodata 217360 217584 224 0.1
.text 3831621 3831989 368 0.0
lighting-app debug+rpc (read only) 1540865 1541505 640 0.0
.rodata 128113 128369 256 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239673 640 0.1
.rodata 110408 110664 256 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302641 608 0.0
.rodata 127072 127296 224 0.2
.text 1077170 1077554 384 0.0
tv-app debug (read only) 1773337 1773897 560 0.0
.rodata 153464 153656 192 0.1
.text 1477682 1478050 368 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861563 296 0.0
rodata 96860 97028 168 0.2
text 577612 577740 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822391 296 0.0
rodata 87640 87808 168 0.2
text 550784 550916 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786602 296 0.0
rodata 92100 92268 168 0.2
text 507080 507208 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838271 296 0.0
rodata 93216 93384 168 0.2
text 559092 559220 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763566 296 0.0
rodata 88520 88688 168 0.2
text 488652 488780 128 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842939 296 0.0
rodata 94460 94628 168 0.2
text 562300 562432 132 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838259 312 0.0
rodata 93236 93404 168 0.2
text 558932 559064 132 0.0
p6 lock-app default (read/write) 2167872 2168296 424 0.0
.text 1126136 1126560 424 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490924 424 0.1
.text 485180 485604 424 0.1
lock-app qpg6100+debug (read only) 466844 467256 412 0.1
.text 461524 461936 412 0.1
telink lighting-app tlsr9518adk80d (read/write) 662890 663178 288 0.0
text 458036 458184 148 0.0
Decreases (3 builds for mbed)
platform target config section bf585f8 be80d63 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294952 2294880 -72 -0.0
.text 1257552 1257480 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2274256 -80 -0.0
.text 1236936 1236856 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252056 2251976 -80 -0.0
.text 1214656 1214576 -80 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bf585f8 be80d63 change % change
efr32 lighting-app BRD4161A (read only) 736636 737084 448 0.1
(read/write) 114476 114476 0 0.0
.bss 112724 112724 0 0.0
.data 1752 1752 0 0.0
.text 736628 737076 448 0.1
BRD4161A+rpc (read only) 724076 724508 432 0.1
(read/write) 131080 131080 0 0.0
.bss 129228 129228 0 0.0
.data 1852 1852 0 0.0
.text 724068 724500 432 0.1
lock-app BRD4161A (read only) 715932 716368 436 0.1
(read/write) 112292 112292 0 0.0
.bss 110580 110580 0 0.0
.data 1712 1712 0 0.0
.text 715924 716360 436 0.1
window-app BRD4161A (read only) 716836 717280 444 0.1
(read/write) 112616 112620 4 0.0
.bss 110900 110900 0 0.0
.data 1716 1716 0 0.0
.text 716828 717272 444 0.1
esp32 all-clusters-app c3devkit (read only) 880562 880710 148 0.0
(read/write) 1307800 1308088 288 0.0
.dram0.bss 58456 58456 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199928 288 0.1
.flash.text 880562 880710 148 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911451 911583 132 0.0
(read/write) 427560 427840 280 0.1
.dram0.bss 60952 60952 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 208624 280 0.1
.flash.text 911451 911583 132 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699572 444 0.1
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 614152 444 0.1
lock-app k32w061+debug (read/write) 591432 591868 436 0.1
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515984 436 0.1
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1687001 1687625 624 0.0
(read/write) 119024 119024 0 0.0
.bss 50640 50640 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138325 256 0.2
.text 1415874 1416242 368 0.0
bridge-app debug+rpc (read only) 1281957 1282549 592 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110244 224 0.2
.text 1076693 1077061 368 0.0
chip-tool debug (read only) 4314925 4315517 592 0.0
(read/write) 123648 123648 0 0.0
.bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217584 224 0.1
.text 3831621 3831989 368 0.0
lighting-app debug+rpc (read only) 1540865 1541505 640 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128369 256 0.2
.text 1280370 1280754 384 0.0
ota-provider-app debug (read only) 1239033 1239673 640 0.1
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110664 256 0.2
.text 1032498 1032882 384 0.0
ota-requestor-app debug (read only) 1302033 1302641 608 0.0
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127296 224 0.2
.text 1077170 1077554 384 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1773897 560 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153656 192 0.1
.text 1477682 1478050 368 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2294880 -72 -0.0
.bss 179828 179828 0 0.0
.data 5216 5216 0 0.0
.heap 851400 851400 0 0.0
.text 1257552 1257480 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274256 -80 -0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236856 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2251976 -80 -0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214576 -80 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861563 296 0.0
bss 111180 111180 0 0.0
rodata 96860 97028 168 0.2
text 577612 577740 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822391 296 0.0
bss 107424 107424 0 0.0
rodata 87640 87808 168 0.2
text 550784 550916 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786602 296 0.0
bss 112556 112556 0 0.0
rodata 92100 92268 168 0.2
text 507080 507208 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838271 296 0.0
bss 110216 110216 0 0.0
rodata 93216 93384 168 0.2
text 559092 559220 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763566 296 0.0
bss 111628 111628 0 0.0
rodata 88520 88688 168 0.2
text 488652 488780 128 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842939 296 0.0
bss 110352 110352 0 0.0
rodata 94460 94628 168 0.2
text 562300 562432 132 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 838259 312 0.0
bss 110252 110252 0 0.0
rodata 93236 93404 168 0.2
text 558932 559064 132 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2168296 424 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126560 424 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490924 424 0.1
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485604 424 0.1
lock-app qpg6100+debug (read only) 466844 467256 412 0.1
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461524 461936 412 0.1
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 663178 288 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458184 148 0.0

@andy31415
Copy link
Contributor

1 day fast track: straight forward change that has unit tests, created by domain owner and with separate approval of another domain owner.

@restyled-io restyled-io bot mentioned this pull request Nov 1, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/add_struct_array_builder branch 2 times, most recently from c3de94e to 34eec02 Compare November 1, 2021 15:40
@yunhanw-google yunhanw-google force-pushed the feature/add_struct_array_builder branch from 34eec02 to 1163da6 Compare November 1, 2021 15:46
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11231: Size comparison from 1073bb2 to 1163da6

Increases (26 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 1073bb2 1163da6 change % change
efr32 lighting-app BRD4161A (read only) 735256 735688 432 0.1
.text 735248 735680 432 0.1
BRD4161A+rpc (read only) 722680 723112 432 0.1
.text 722672 723104 432 0.1
lock-app BRD4161A (read only) 714552 714972 420 0.1
.text 714544 714964 420 0.1
window-app BRD4161A (read only) 715440 715884 444 0.1
.text 715432 715876 444 0.1
esp32 all-clusters-app c3devkit (read only) 879954 880102 148 0.0
(read/write) 1307184 1307472 288 0.0
.flash.rodata 199056 199344 288 0.1
.flash.text 879954 880102 148 0.0
m5stack (read only) 910915 911055 140 0.0
(read/write) 426968 427248 280 0.1
.flash.rodata 207784 208064 280 0.1
.flash.text 910915 911055 140 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698016 698460 444 0.1
.text 612628 613072 444 0.1
lock-app k32w061+debug (read/write) 590320 590756 436 0.1
.text 514468 514904 436 0.1
linux all-clusters-app debug (read only) 1684281 1684905 624 0.0
.rodata 137493 137749 256 0.2
.text 1413730 1414098 368 0.0
bridge-app debug+rpc (read only) 1279205 1279829 624 0.0
.rodata 109412 109668 256 0.2
.text 1074549 1074917 368 0.0
chip-tool debug (read only) 4313789 4314381 592 0.0
.rodata 217328 217552 224 0.1
.text 3830805 3831173 368 0.0
lighting-app debug+rpc (read only) 1538145 1538769 624 0.0
.rodata 127537 127793 256 0.2
.text 1278226 1278594 368 0.0
ota-provider-app debug (read only) 1236185 1236825 640 0.1
.rodata 109800 110056 256 0.2
.text 1030258 1030642 384 0.0
ota-requestor-app debug (read only) 1293681 1294273 592 0.0
.rodata 121120 121344 224 0.2
.text 1074770 1075138 368 0.0
tv-app debug (read only) 1771081 1771673 592 0.0
.rodata 152824 153048 224 0.1
.text 1476354 1476722 368 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860167 860479 312 0.0
rodata 96304 96472 168 0.2
text 577100 577232 132 0.0
nrf52840dk_nrf52840+rpc (read/write) 820991 821287 296 0.0
rodata 87080 87248 168 0.2
text 550276 550404 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785210 785506 296 0.0
rodata 91548 91716 168 0.2
text 506568 506700 132 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836875 837171 296 0.0
rodata 92660 92828 168 0.2
text 558580 558712 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762170 762466 296 0.0
rodata 87964 88132 168 0.2
text 488140 488272 132 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841547 841843 296 0.0
rodata 93908 94076 168 0.2
text 561792 561920 128 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836867 837163 296 0.0
rodata 92684 92852 168 0.2
text 558424 558552 128 0.0
p6 lock-app default (read/write) 2166464 2166880 416 0.0
.text 1124728 1125144 416 0.0
qpg lighting-app qpg6100+debug (read only) 489412 489828 416 0.1
.text 484092 484508 416 0.1
lock-app qpg6100+debug (read only) 465752 466156 404 0.1
.text 460432 460836 404 0.1
telink lighting-app tlsr9518adk80d (read/write) 661646 661934 288 0.0
text 457394 457542 148 0.0
Decreases (4 builds for efr32, mbed)
platform target config section 1073bb2 1163da6 change % change
efr32 window-app BRD4161A (read/write) 112588 112584 -4 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293808 2293736 -72 -0.0
.text 1256408 1256336 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2273256 2273176 -80 -0.0
.text 1235856 1235776 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250912 2250896 -16 -0.0
.text 1213512 1213496 -16 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1073bb2 1163da6 change % change
efr32 lighting-app BRD4161A (read only) 735256 735688 432 0.1
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735248 735680 432 0.1
BRD4161A+rpc (read only) 722680 723112 432 0.1
(read/write) 131052 131052 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 722672 723104 432 0.1
lock-app BRD4161A (read only) 714552 714972 420 0.1
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714544 714964 420 0.1
window-app BRD4161A (read only) 715440 715884 444 0.1
(read/write) 112588 112584 -4 -0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715432 715876 444 0.1
esp32 all-clusters-app c3devkit (read only) 879954 880102 148 0.0
(read/write) 1307184 1307472 288 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199056 199344 288 0.1
.flash.text 879954 880102 148 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 910915 911055 140 0.0
(read/write) 426968 427248 280 0.1
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 207784 208064 280 0.1
.flash.text 910915 911055 140 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698016 698460 444 0.1
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612628 613072 444 0.1
lock-app k32w061+debug (read/write) 590320 590756 436 0.1
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514468 514904 436 0.1
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1684281 1684905 624 0.0
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137493 137749 256 0.2
.text 1413730 1414098 368 0.0
bridge-app debug+rpc (read only) 1279205 1279829 624 0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109412 109668 256 0.2
.text 1074549 1074917 368 0.0
chip-tool debug (read only) 4313789 4314381 592 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217328 217552 224 0.1
.text 3830805 3831173 368 0.0
lighting-app debug+rpc (read only) 1538145 1538769 624 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127537 127793 256 0.2
.text 1278226 1278594 368 0.0
ota-provider-app debug (read only) 1236185 1236825 640 0.1
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 109800 110056 256 0.2
.text 1030258 1030642 384 0.0
ota-requestor-app debug (read only) 1293681 1294273 592 0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121120 121344 224 0.2
.text 1074770 1075138 368 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1771081 1771673 592 0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152824 153048 224 0.1
.text 1476354 1476722 368 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293808 2293736 -72 -0.0
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1256408 1256336 -72 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273256 2273176 -80 -0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235856 1235776 -80 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250912 2250896 -16 -0.0
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1213512 1213496 -16 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860167 860479 312 0.0
bss 111148 111148 0 0.0
rodata 96304 96472 168 0.2
text 577100 577232 132 0.0
nrf52840dk_nrf52840+rpc (read/write) 820991 821287 296 0.0
bss 107392 107392 0 0.0
rodata 87080 87248 168 0.2
text 550276 550404 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785210 785506 296 0.0
bss 112524 112524 0 0.0
rodata 91548 91716 168 0.2
text 506568 506700 132 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836875 837171 296 0.0
bss 110184 110184 0 0.0
rodata 92660 92828 168 0.2
text 558580 558712 132 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762170 762466 296 0.0
bss 111596 111596 0 0.0
rodata 87964 88132 168 0.2
text 488140 488272 132 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841547 841843 296 0.0
bss 110320 110320 0 0.0
rodata 93908 94076 168 0.2
text 561792 561920 128 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836867 837163 296 0.0
bss 110220 110220 0 0.0
rodata 92684 92852 168 0.2
text 558424 558552 128 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2166464 2166880 416 0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124728 1125144 416 0.0
qpg lighting-app qpg6100+debug (read only) 489412 489828 416 0.1
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484092 484508 416 0.1
lock-app qpg6100+debug (read only) 465752 466156 404 0.1
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460432 460836 404 0.1
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661646 661934 288 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457394 457542 148 0.0

@andy31415 andy31415 merged commit 7898b53 into project-chip:master Nov 1, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yunhanw-google
Add ListBuilder/Parser and StructBuilder/Parser (project-chip#11231)
e05a368 
* Add ListBuilder/Parser and StructBuilder/Parser

--Fix ListBuilder naming, which should be ArrayBuilder
--Add ListBuilder/Parser and StructBuilder/Praser, the enablement for them would be
follow-up PR

* Fix java codegen missing in master

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @andy31415 @yufengwangca @bzbarsky-apple