Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete init in builder/parser for IM message def #11235

Closed
yunhanw-google opened this issue Oct 29, 2021 · 2 comments
Closed

Delete init in builder/parser for IM message def #11235

yunhanw-google opened this issue Oct 29, 2021 · 2 comments
Labels
stale Stale issue or PR V1.X

Comments

@yunhanw-google
Copy link
Contributor

agree, but they need different parameter type, one is uint8_t, and another is TLV::Tag, which would impact the large PR for command, I would delete Init function with uint8_t in follow-up PR,

Originally posted by @yunhanw-google in #11231 (comment)

@stale
Copy link

stale bot commented Sep 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 16, 2022
@stale
Copy link

stale bot commented Oct 1, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

2 participants