Add Bridged Actions Cluster (#10694) #10838

pjzander-signify · 2021-10-22T11:01:02Z

Problem

See issue #10694.
For bridged devices a Bridged Actions Cluster is required.
For the specification see: Connected Home over IP Specification, paragraph 9.14.

NOTE: The previous pull request is closed accidentally (#10778)

Change overview

Add a cluster description file for the Bridged Actions cluster.
Add the attributes and commands to the zap-file of chip-tool.
Add the attributes and commands to the zap-file of the all-clusters-app.
Implement stub callbacks for the commands in the all-cluster-app (Linux and ESP32).

Testing

Manual tested with the chip-tool and the bridge-app
Passed all Github workflows.

github-actions · 2021-10-22T11:31:26Z

PR #10838: Size comparison from 0c16976 to eeeb89d

Increases above 1.0% from 0c16976 to eeeb89d:

platform	target	config	section	`0c16976`	`eeeb89d`	change	% change
linux	all-clusters-app	debug	.bss	52208	53232	1024	2.0
			.text	1352290	1368386	16096	1.2
	chip-tool	debug	.data.rel.ro	93504	94752	1248	1.3
			.text	3502693	3584837	82144	2.3

22 builds (for efr32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`0c16976`	`eeeb89d`	change	% change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0	0.0
			.data	1800	1800	0	0.0
			.text	784328	784328	0	0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	763456	763456	0	0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	764380	764380	0	0.0
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0	0.0
			.data	1852	1852	0	0.0
			.text	764028	764028	0	0.0
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	516068	516068	0	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	359544	359544	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78592	78592	0	0.0
			.data	1900	1900	0	0.0
			.text	614836	614836	0	0.0
linux	all-clusters-app	debug	.bss	52208	53232	1024	2.0
			.data	978	978	0	0.0
			.data.rel.ro	60384	60512	128	0.2
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136405	137493	1088	0.8
			.text	1352290	1368386	16096	1.2
	chip-tool	debug	.bss	17712	17712	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	93504	94752	1248	1.3
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	193860	195324	1464	0.8
			.text	3502693	3584837	82144	2.3
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110248	110248	0	0.0
			.text	`1022226`	`1022226`	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	25800	25800	0	0.0
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128392	128392	0	0.0
			.text	1140786	1140786	0	0.0
	shell	debug	.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76463	76463	0	0.0
			.text	597346	597346	0	0.0
	tv-app	debug	.bss	216592	216592	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	57408	57408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152904	152904	0	0.0
			.text	1452706	1452706	0	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27112	27112	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110748	110748	0	0.0
			.text	1063173	1063173	0	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53808	53808	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127921	127921	0	0.0
			.text	1261170	1261170	0	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172100	172100	0	0.0
			.data	5464	5464	0	0.0
			.heap	858880	858880	0	0.0
			.text	1220088	1220088	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171020	171020	0	0.0
			.data	5432	5432	0	0.0
			.heap	859992	859992	0	0.0
			.text	1197984	1197984	0	0.0
p6	lock-app	default	.bss	68216	68216	0	0.0
			.data	2416	2416	0	0.0
			.heap	962712	962712	0	0.0
			.text	`1126688`	`1126688`	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	1004	1004	0	0.0
			.text	485972	485972	0	0.0
	lock-app	qpg6100+debug	.bss	52496	52496	0	0.0
			.data	960	960	0	0.0
			.text	462060	462060	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	27840	27840	0	0.0
			.data	372	372	0	0.0
			.text	149896	149896	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70996	70996	0	0.0
			noinit	33216	33216	0	0.0
			text	457630	457630	0	0.0

Increases above 1.0% from 0c16976 to eeeb89d:

platform	target	config	section	`0c16976`	`eeeb89d`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	61320	1024	1.7
		m5stack	.dram0.bss	62800	63832	1032	1.6

12 builds (for esp32, nrfconnect)

platform	target	config	section	`0c16976`	`eeeb89d`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	61320	1024	1.7
			.dram0.data	16440	16440	0	0.0
			.flash.rodata	199864	201016	1152	0.6
			.flash.text	874330	877270	2940	0.3
			.iram0.text	57564	57564	0	0.0
		m5stack	.dram0.bss	62800	63832	1032	1.6
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	208600	209752	1152	0.6
			.flash.text	905263	908015	2752	0.3
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113176	113176	0	0.0
			rodata	98076	98076	0	0.0
			text	577104	577104	0	0.0
	lock-app	nrf52840dk_nrf52840	bss	112244	112244	0	0.0
			rodata	94412	94412	0	0.0
			text	558592	558592	0	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	112312	112312	0	0.0
			rodata	95396	95396	0	0.0
			text	561744	561744	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	112252	112252	0	0.0
			rodata	94472	94472	0	0.0
			text	558384	558384	0	0.0
	shell	nrf52840dk_nrf52840	bss	109072	109072	0	0.0
			rodata	72524	72524	0	0.0
			text	520208	520208	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109420	109420	0	0.0
			rodata	88856	88856	0	0.0
			text	550296	550296	0	0.0
		nrf5340dk_nrf5340_cpuapp	bss	114552	114552	0	0.0
			rodata	93316	93316	0	0.0
			text	506572	506572	0	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113616	113616	0	0.0
			rodata	89672	89672	0	0.0
			text	488056	488056	0	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056	0	0.0
			rodata	67168	67168	0	0.0
			text	440816	440816	0	0.0

src/app/zap-templates/zcl/data-model/chip/bridged-actions-cluster.xml

woody-apple · 2021-10-22T16:57:01Z

@saurabhst @msandstedt @mspang @andy31415 @Damian-Nordic ?

@pjzander-signify can you resolve conflicts here please?

github-actions · 2021-10-22T21:16:35Z

PR #10838: Size comparison from 640e204 to 23b78c2

Increases above 1.0% from 640e204 to 23b78c2:

platform	target	config	section	`640e204`	`23b78c2`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	61328	1032	1.7
		m5stack	.dram0.bss	62808	63832	1024	1.6
linux	all-clusters-app	debug	.bss	52208	53232	1024	2.0
			.text	1352514	1368594	16080	1.2
	chip-tool	debug	.data.rel.ro	93584	94832	1248	1.3
			.text	`3506501`	3588645	82144	2.3

35 builds (for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`640e204`	`23b78c2`	change	% change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0	0.0
			.data	1800	1800	0	0.0
			.text	784296	784296	0	0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	763440	763440	0	0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	764356	764356	0	0.0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0	0.0
			.data	1852	1852	0	0.0
			.text	764012	764012	0	0.0
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	61328	1032	1.7
			.dram0.data	16440	16440	0	0.0
			.flash.rodata	199864	201024	1160	0.6
			.flash.text	874306	877246	2940	0.3
			.iram0.text	57564	57564	0	0.0
		m5stack	.dram0.bss	62808	63832	1024	1.6
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	208600	209760	1160	0.6
			.flash.text	905315	907983	2668	0.3
			.iram0.text	125115	125115	0	0.0
k32w	lock-app	k32w061+debug	.bss	69068	69068	0	0.0
			.data	1864	1864	0	0.0
			.text	516024	516024	0	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	359480	359480	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78592	78592	0	0.0
			.data	1900	1900	0	0.0
			.text	614788	614788	0	0.0
linux	all-clusters-app	debug	.bss	52208	53232	1024	2.0
			.data	978	978	0	0.0
			.data.rel.ro	60384	60512	128	0.2
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136373	137461	1088	0.8
			.text	1352514	1368594	16080	1.2
	chip-tool	debug	.bss	17712	17712	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	93584	94832	1248	1.3
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	194148	195612	1464	0.8
			.text	`3506501`	3588645	82144	2.3
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110248	110248	0	0.0
			.text	`1022482`	`1022482`	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	25800	25800	0	0.0
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128392	128392	0	0.0
			.text	`1141106`	`1141106`	0	0.0
	shell	debug	.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76463	76463	0	0.0
			.text	598242	598242	0	0.0
	tv-app	debug	.bss	216592	216592	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	57408	57408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152904	152904	0	0.0
			.text	1452898	1452898	0	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27112	27112	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110748	110748	0	0.0
			.text	`1063461`	`1063461`	0	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53808	53808	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127921	127921	0	0.0
			.text	1261410	1261410	0	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172100	172100	0	0.0
			.data	5464	5464	0	0.0
			.heap	858880	858880	0	0.0
			.text	1220088	1220088	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171020	171020	0	0.0
			.data	5432	5432	0	0.0
			.heap	859992	859992	0	0.0
			.text	1197992	1197992	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	.bss	11760	11760	0	0.0
			.data	4360	4360	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103064	103064	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113180	113180	0	0.0
			rodata	98080	98080	0	0.0
			text	577104	577104	0	0.0
	lock-app	nrf52840dk_nrf52840	bss	112244	112244	0	0.0
			rodata	94416	94416	0	0.0
			text	558592	558592	0	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	112316	112316	0	0.0
			rodata	95396	95396	0	0.0
			text	561744	561744	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	112252	112252	0	0.0
			rodata	94476	94476	0	0.0
			text	558384	558384	0	0.0
	shell	nrf52840dk_nrf52840	bss	109072	109072	0	0.0
			rodata	72524	72524	0	0.0
			text	520208	520208	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109420	109420	0	0.0
			rodata	88856	88856	0	0.0
			text	550296	550296	0	0.0
		nrf5340dk_nrf5340_cpuapp	bss	114552	114552	0	0.0
			rodata	93320	93320	0	0.0
			text	506572	506572	0	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113620	113620	0	0.0
			rodata	89676	89676	0	0.0
			text	488056	488056	0	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056	0	0.0
			rodata	67168	67168	0	0.0
			text	440816	440816	0	0.0
p6	lock-app	default	.bss	68216	68216	0	0.0
			.data	2416	2416	0	0.0
			.heap	962712	962712	0	0.0
			.text	`1126688`	`1126688`	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53464	53464	0	0.0
			.data	1004	1004	0	0.0
			.text	486036	486036	0	0.0
	lock-app	qpg6100+debug	.bss	52408	52408	0	0.0
			.data	960	960	0	0.0
			.text	462120	462120	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	27752	27752	0	0.0
			.data	372	372	0	0.0
			.text	149896	149896	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0	0.0
			noinit	33216	33216	0	0.0
			text	457612	457612	0	0.0

woody-apple · 2021-10-23T06:15:21Z

/rebase

github-actions · 2021-10-23T16:10:49Z

PR #10838: Size comparison from afd63a1 to 9e50a6e

8 builds (for k32w, p6, qpg, telink)

platform	target	config	section	`afd63a1`	`9e50a6e`
k32w	lock-app	k32w061+debug	.bss	69228	69228
			.data	1864	1864
			.text	515076	515076
	shell	k32w061+debug	.bss	63256	63256
			.data	672	672
			.text	359556	359556
	lighting-app	k32w061+se05x+release	.bss	78744	78744
			.data	1900	1900
			.text	613792	613792
p6	lock-app	default	.bss	67208	67208
			.data	2416	2416
			.heap	963720	963720
			.text	1125992	1125992
qpg	lighting-app	qpg6100+debug	.bss	52456	52456
			.data	1004	1004
			.text	485048	485048
	lock-app	qpg6100+debug	.bss	51400	51400
			.data	960	960
			.text	461188	461188
	persistent-storage-app	qpg6100+debug	.bss	27752	27752
			.data	372	372
			.text	149896	149896
telink	lighting-app	tlsr9518adk80d	bss	69988	69988
			noinit	33216	33216
			text	457670	457670

Increases above 1.0% from afd63a1 to 9e50a6e:

platform	target	config	section	`afd63a1`	`9e50a6e`	change	% change
linux	all-clusters-app	debug	.bss	50192	51216	1024	2.0
			.text	1353266	1369362	16096	1.2
	chip-tool	debug	.data.rel.ro	94016	95264	1248	1.3
			.text	3618293	3700501	82208	2.3

12 builds (for efr32, linux)

platform	target	config	section	`afd63a1`	`9e50a6e`	change	% change
efr32	lighting-app	BRD4161A	.bss	113716	113716	0	0.0
			.data	1752	1752	0	0.0
			.text	735768	735768	0	0.0
	lock-app	BRD4161A	.bss	111572	111572	0	0.0
			.data	1712	1712	0	0.0
			.text	714984	714984	0	0.0
	window-app	BRD4161A	.bss	111884	111884	0	0.0
			.data	1716	1716	0	0.0
			.text	715812	715812	0	0.0
	lighting-app	BRD4161A+rpc	.bss	130220	130220	0	0.0
			.data	1852	1852	0	0.0
			.text	723184	723184	0	0.0
linux	all-clusters-app	debug	.bss	50192	51216	1024	2.0
			.data	978	978	0	0.0
			.data.rel.ro	60448	60576	128	0.2
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	134485	135573	1088	0.8
			.text	1353266	1369362	16096	1.2
	chip-tool	debug	.bss	17712	17712	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	94016	95264	1248	1.3
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	207140	208604	1464	0.7
			.text	3618293	3700501	82208	2.3
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110344	110344	0	0.0
			.text	1023554	1023554	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	25800	25800	0	0.0
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128424	128424	0	0.0
			.text	`1142274`	`1142274`	0	0.0
	shell	debug	.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76495	76495	0	0.0
			.text	599506	599506	0	0.0
	tv-app	debug	.bss	215568	215568	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	57408	57408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	151944	151944	0	0.0
			.text	1454306	1454306	0	0.0
	bridge-app	debug+rpc	.bss	51888	51888	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27112	27112	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	109740	109740	0	0.0
			.text	1064085	1064085	0	0.0
	lighting-app	debug+rpc	.bss	41208	41208	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53808	53808	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	126897	126897	0	0.0
			.text	`1262034`	`1262034`	0	0.0

3 builds (for mbed)

platform	target	config	section	`afd63a1`	`9e50a6e`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	171092	171092
			.data	5464	5464
			.heap	859888	859888
			.text	`1219112`	`1219112`
	lock-app	CY8CPROTO_062_4343W+release	.bss	170012	170012
			.data	5432	5432
			.heap	861000	861000
			.text	1197072	1197072
	pigweed-app	CY8CPROTO_062_4343W+release	.bss	11760	11760
			.data	4360	4360
			.heap	1020328	1020328
			.text	103064	103064

Increases above 1.0% from afd63a1 to 9e50a6e:

platform	target	config	section	`afd63a1`	`9e50a6e`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	58272	59296	1024	1.8
		m5stack	.dram0.bss	60776	61800	1024	1.7

12 builds (for esp32, nrfconnect)

platform	target	config	section	`afd63a1`	`9e50a6e`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	58272	59296	1024	1.8
			.dram0.data	16464	16464	0	0.0
			.flash.rodata	197936	199088	1152	0.6
			.flash.text	874314	877234	2920	0.3
			.iram0.text	57564	57564	0	0.0
		m5stack	.dram0.bss	60776	61800	1024	1.7
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	206696	207848	1152	0.6
			.flash.text	905471	908111	2640	0.3
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112168	112168	0	0.0
			rodata	97100	97100	0	0.0
			text	577208	577208	0	0.0
	lock-app	nrf52840dk_nrf52840	bss	111240	111240	0	0.0
			rodata	93500	93500	0	0.0
			text	558696	558696	0	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111300	111300	0	0.0
			rodata	94396	94396	0	0.0
			text	561852	561852	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111236	111236	0	0.0
			rodata	93476	93476	0	0.0
			text	558488	558488	0	0.0
	shell	nrf52840dk_nrf52840	bss	109072	109072	0	0.0
			rodata	72536	72536	0	0.0
			text	520316	520316	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108408	108408	0	0.0
			rodata	87876	87876	0	0.0
			text	550400	550400	0	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113540	113540	0	0.0
			rodata	92340	92340	0	0.0
			text	506680	506680	0	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112612	112612	0	0.0
			rodata	88760	88760	0	0.0
			text	488160	488160	0	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056	0	0.0
			rodata	67180	67180	0	0.0
			text	440924	440924	0	0.0

github-actions · 2021-10-23T17:15:37Z

Size increase report for "esp32-example-build" from afd63a1

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	2920	2920
chip-all-clusters-app.elf	.flash.rodata	1152	1152
chip-all-clusters-app.elf	.dram0.bss	0	1024

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,103268
.debug_str,0,16443
.debug_line,0,15711
.debug_loc,0,13206
.debug_ranges,0,3920
.strtab,0,3791
.flash.text,2920,2920
.debug_frame,0,1808
.flash.rodata,1152,1152
.dram0.bss,1024,0
.symtab,0,432
.debug_aranges,0,240
.debug_abbrev,0,238
[Unmapped],0,24
.riscv.attributes,0,2
.shstrtab,0,1

woody-apple · 2021-10-25T16:35:35Z

Fast tracking this, as the previous PR has been up for a long while.

…p#10838)" This reverts commit e173300.

This reverts commit e173300.

…p#10838)" (project-chip#10926) This reverts commit e173300.

boring-cyborg bot added app controller darwin examples labels Oct 22, 2021

pullapprove bot requested review from vivien-apple, wbschiller, woody-apple and yufengwangca October 22, 2021 11:02

pullapprove bot added the review - pending label Oct 22, 2021

bzbarsky-apple approved these changes Oct 22, 2021

View reviewed changes

src/app/zap-templates/zcl/data-model/chip/bridged-actions-cluster.xml Show resolved Hide resolved

woody-apple approved these changes Oct 22, 2021

View reviewed changes

pjzander-signify force-pushed the issue_10694 branch from eeeb89d to 23b78c2 Compare October 22, 2021 17:56

woody-apple added the has conflicts label Oct 23, 2021

pullapprove bot requested a review from tecimovic October 23, 2021 03:06

pjzander-signify added 2 commits October 23, 2021 17:40

Add Bridged Actions Cluster

a32184c

Replace OCTET_STRING with now supported CHAR_STRING

9e50a6e

pjzander-signify force-pushed the issue_10694 branch from 23b78c2 to 9e50a6e Compare October 23, 2021 15:47

woody-apple merged commit e173300 into project-chip:master Oct 25, 2021

bzbarsky-apple mentioned this pull request Oct 25, 2021

[Mbed] Add all-clusters-app example #10442

Merged

andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Oct 25, 2021

Revert "Add Bridged Actions Cluster (project-chip#10694) (project-chi…

5cca8d8

…p#10838)" This reverts commit e173300.

andy31415 added a commit that referenced this pull request Oct 25, 2021

Revert "Add Bridged Actions Cluster (#10694) (#10838)" (#10926)

66f4ec6

This reverts commit e173300.

pjzander-signify deleted the issue_10694 branch October 26, 2021 15:28

JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021

Revert "Add Bridged Actions Cluster (project-chip#10694) (project-chi…

bbf0cfc

…p#10838)" (project-chip#10926) This reverts commit e173300.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bridged Actions Cluster (#10694) #10838

Add Bridged Actions Cluster (#10694) #10838

pjzander-signify commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 22, 2021 •

edited

Loading

woody-apple commented Oct 22, 2021

github-actions bot commented Oct 22, 2021

woody-apple commented Oct 23, 2021

github-actions bot commented Oct 23, 2021 •

edited

Loading

github-actions bot commented Oct 23, 2021

woody-apple commented Oct 25, 2021

Add Bridged Actions Cluster (#10694) #10838

Add Bridged Actions Cluster (#10694) #10838

Conversation

pjzander-signify commented Oct 22, 2021 • edited Loading

Problem

Change overview

Testing

github-actions bot commented Oct 22, 2021 • edited Loading

woody-apple commented Oct 22, 2021

github-actions bot commented Oct 22, 2021

woody-apple commented Oct 23, 2021

github-actions bot commented Oct 23, 2021 • edited Loading

github-actions bot commented Oct 23, 2021

woody-apple commented Oct 25, 2021

pjzander-signify commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 23, 2021 •

edited

Loading