Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pull pigweed (#10792)" #10797

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

andy31415
Copy link
Contributor

Builds seem to fail:

20211021 20:09:52 ERR Build error for
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex.NO_BACKEND_SET(//third_party/connectedhomeip/config/esp32/toolchain:esp32):
20211021 20:09:52 ERR
20211021 20:09:52 ERR   Attempted to build the
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex
facade with no backend.
20211021 20:09:52 ERR
...

This reverts commit bb96f04.

Builds seem to fail:

```
20211021 20:09:52 ERR Build error for
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex.NO_BACKEND_SET(//third_party/connectedhomeip/config/esp32/toolchain:esp32):
20211021 20:09:52 ERR
20211021 20:09:52 ERR   Attempted to build the
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex
facade with no backend.
20211021 20:09:52 ERR
...
```

This reverts commit bb96f04.
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Oct 21, 2021
@andy31415
Copy link
Contributor Author

For the original PR, I had waited for some CI to pass, but apparently not enough. I learned that "wait for all CI" should probably still remain a requirement for any fast track.

@tcarmelveilleux tcarmelveilleux self-requested a review October 21, 2021 20:22
@andy31415 andy31415 merged commit 49727db into project-chip:master Oct 21, 2021
@github-actions
Copy link

github-actions bot commented Oct 21, 2021

PR #10797: Size comparison from 114d413 to aeed08c

8 builds (for k32w, p6, qpg, telink)
platform target config section 114d413 aeed08c change % change
k32w lock-app k32w061+debug .bss 69060 69060 0 0.0
.data 1864 1864 0 0.0
.text 514680 514680 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357416 357416 0 0.0
lighting-app k32w061+se05x+release .bss 78584 78584 0 0.0
.data 1900 1900 0 0.0
.text 613464 613464 0 0.0
p6 lock-app default .bss 68208 68208 0 0.0
.data 2416 2416 0 0.0
.heap 962720 962720 0 0.0
.text 1125456 1125456 0 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 996 996 0 0.0
.text 485628 485628 0 0.0
lock-app qpg6100+debug .bss 52496 52496 0 0.0
.data 952 952 0 0.0
.text 461716 461716 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102756 102756 0 0.0
telink lighting-app tlsr9518adk80d bss 70992 70992 0 0.0
noinit 33216 33216 0 0.0
text 457314 457314 0 0.0
10 builds (for linux, mbed)
platform target config section 114d413 aeed08c change % change
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 59072 59072 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 136117 136117 0 0.0
.text 1340098 1340098 0 0.0
chip-tool debug .bss 17520 17520 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 91984 91984 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 183524 183524 0 0.0
.text 3456325 3456325 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23176 23176 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 109960 109960 0 0.0
.text 1009058 1009058 0 0.0
ota-requestor-app debug .bss 205696 205696 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128104 128104 0 0.0
.text 1127602 1127602 0 0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71855 71855 0 0.0
.text 570242 570242 0 0.0
tv-app debug .bss 216560 216560 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 56096 56096 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152616 152616 0 0.0
.text 1441122 1441122 0 0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110460 110460 0 0.0
.text 1048965 1048965 0 0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1138 1106 -32 -2.8
.data.rel.ro 52496 52496 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128145 127633 -512 -0.4
.text 1250898 1249186 -1712 -0.1
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172092 172092 0 0.0
.data 5464 5464 0 0.0
.heap 858888 858888 0 0.0
.text 1219200 1219200 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171012 171012 0 0.0
.data 5432 5432 0 0.0
.heap 860000 860000 0 0.0
.text 1197032 1197032 0 0.0

@andy31415 andy31415 deleted the revert_pw_update branch October 28, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants