-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Pull pigweed (#10792)" #10797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds seem to fail: ``` 20211021 20:09:52 ERR Build error for //third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex.NO_BACKEND_SET(//third_party/connectedhomeip/config/esp32/toolchain:esp32): 20211021 20:09:52 ERR 20211021 20:09:52 ERR Attempted to build the //third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex facade with no backend. 20211021 20:09:52 ERR ... ``` This reverts commit bb96f04.
For the original PR, I had waited for some CI to pass, but apparently not enough. I learned that "wait for all CI" should probably still remain a requirement for any fast track. |
tcarmelveilleux
approved these changes
Oct 21, 2021
PR #10797: Size comparison from 114d413 to aeed08c 8 builds (for k32w, p6, qpg, telink)
10 builds (for linux, mbed)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds seem to fail:
This reverts commit bb96f04.