Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull pigweed #10792

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Pull pigweed #10792

merged 1 commit into from
Oct 21, 2021

Conversation

andy31415
Copy link
Contributor

Especially interested in google/pigweed@cd40577 that speeds up bootstrap time.

@andy31415
Copy link
Contributor Author

Fast track rationale: submodule pull. CI will validate.

@andy31415 andy31415 merged commit bb96f04 into project-chip:master Oct 21, 2021
@github-actions
Copy link

PR #10792: Size comparison from 40f6345 to ab6e5f4

Increases above 1.0% from 40f6345 to ab6e5f4:

platform target config section 40f6345 ab6e5f4 change % change
linux lighting-app debug+rpc .data 1106 1138 32 2.9
18 builds (for k32w, linux, mbed, p6, qpg, telink)
platform target config section 40f6345 ab6e5f4 change % change
k32w lock-app k32w061+debug .bss 69060 69060 0 0.0
.data 1864 1864 0 0.0
.text 515200 515200 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357416 357416 0 0.0
lighting-app k32w061+se05x+release .bss 78584 78584 0 0.0
.data 1900 1900 0 0.0
.text 613984 613984 0 0.0
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 59072 59072 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 136213 136213 0 0.0
.text 1341410 1341410 0 0.0
chip-tool debug .bss 17520 17520 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 91984 91984 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 183524 183524 0 0.0
.text 3456293 3456293 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23176 23176 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 109960 109960 0 0.0
.text 1009010 1009010 0 0.0
ota-requestor-app debug .bss 205696 205696 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128104 128104 0 0.0
.text 1127554 1127554 0 0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71855 71855 0 0.0
.text 570242 570242 0 0.0
tv-app debug .bss 216560 216560 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 56096 56096 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152712 152712 0 0.0
.text 1442434 1442434 0 0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110556 110556 0 0.0
.text 1050277 1050277 0 0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1106 1138 32 2.9
.data.rel.ro 52496 52496 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127729 128241 512 0.4
.text 1250498 1252210 1712 0.1
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172092 172092 0 0.0
.data 5464 5464 0 0.0
.heap 858888 858888 0 0.0
.text 1219720 1219720 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171012 171012 0 0.0
.data 5432 5432 0 0.0
.heap 860000 860000 0 0.0
.text 1197616 1197616 0 0.0
p6 lock-app default .bss 68208 68208 0 0.0
.data 2416 2416 0 0.0
.heap 962720 962720 0 0.0
.text 1126088 1126088 0 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 996 996 0 0.0
.text 486164 486164 0 0.0
lock-app qpg6100+debug .bss 52496 52496 0 0.0
.data 952 952 0 0.0
.text 462240 462240 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102756 102756 0 0.0
telink lighting-app tlsr9518adk80d bss 70992 70992 0 0.0
noinit 33216 33216 0 0.0
text 457820 457820 0 0.0

andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Oct 21, 2021
@andy31415
Revert "Pull pigweed (project-chip#10792)"
aeed08c 
Builds seem to fail:

```
20211021 20:09:52 ERR Build error for
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex.NO_BACKEND_SET(//third_party/connectedhomeip/config/esp32/toolchain:esp32):
20211021 20:09:52 ERR
20211021 20:09:52 ERR   Attempted to build the
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex
facade with no backend.
20211021 20:09:52 ERR
...
```

This reverts commit bb96f04.
andy31415 added a commit that referenced this pull request Oct 21, 2021
@andy31415
Revert "Pull pigweed (#10792)" (#10797)
49727db 
Builds seem to fail:

```
20211021 20:09:52 ERR Build error for
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex.NO_BACKEND_SET(//third_party/connectedhomeip/config/esp32/toolchain:esp32):
20211021 20:09:52 ERR
20211021 20:09:52 ERR   Attempted to build the
//third_party/connectedhomeip/third_party/pigweed/repo/pw_sync:mutex
facade with no backend.
20211021 20:09:52 ERR
...
```

This reverts commit bb96f04.
@andy31415 andy31415 deleted the pull_pigweed branch October 28, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhst saurabhst saurabhst approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @saurabhst